Status Update
Comments
ag...@google.com <ag...@google.com> #2
It would also be nice to be able to set different maxLines
for the large and small titles. For example, setting maxLines = 2
for the large title and maxLines = 1
for the small title.
This functionality is something that would also be possible with TwoRowsTopAppBar
being publicly exposed.
pr...@gmail.com <pr...@gmail.com> #3
@Nick - Having the app bar adjust to its content height is quite tricky here, mainly when there are other constraints that involve the scroll behavior.
What we did at maxLines
will still be applied to the Text
, however, the height set up is going to be done programmatically on the top app bar you chose.
ag...@google.com <ag...@google.com> #4
@sgibly We don't really need the app bar to adjust to its content height. What we are asking for is a way to configure the title based on expanded/collapsed state. TwoRowsTopAppBar
provides a way to handle this, but is a private composable.
Our goal:
- use a slightly larger font size than the current default when in the expanded state
- allow the title to wrap 2 lines when in the expanded state
- confine the tile to a single line when in the collapsed state
As a workaround we have forked ExtraLargeTopAppBar
composable that we use throughout our application:
pr...@gmail.com <pr...@gmail.com> #5
Similar to this request, I would like to request just that the smallTitle
field of TwoRowsTopAppBar
is exposed in LargeTopAppBar
, defaulting to the title
composable. We currently are awkwardly manually handling the transition of large to small and back based on the collapsed fraction of the scroll state, but it seems like the title
/smalltitle
solution is already there and probably superior.
The problem that comes up with both rows of the TwoRowsTopAppBar
being set to a large title
is that on large font sizes/display sizes there is far too much white space for the invisible first app bar.
mk...@google.com <mk...@google.com> #6
pr...@gmail.com <pr...@gmail.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.4.0-alpha07
androidx.compose.material3:material3-android:1.4.0-alpha07
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha07
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha07
ze...@google.com <ze...@google.com>
ze...@google.com <ze...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
Author: Shalom Gibly <
Link:
Update the TwoRowsTopAppBar API
Expand for full commit details
Update the TwoRowsTopAppBar API
- Update the API to the feedback from the API council.
- Remove the `expanded` lambda parameter and have a separate params for
the expanded and collapsed heights.
Test: Updated
Bug: 306697446
Bug: 229134133
Bug: 268068946
Fixes: 394144086
Relnote: "Updates to the TowRowsTopAppBar API. We removed the `expanded`
lambda parameters and added separate parameters for the expanded and
collapsed heights."
Change-Id: Idd6777bc381871b9e77c040762c6bca7355cda8a
Files:
- M
compose/material3/material3/api/current.txt
- M
compose/material3/material3/api/restricted_current.txt
- M
compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/AppBarSamples.kt
- M
compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/AppBarTest.kt
- M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt
Hash: e414ed68307128f55615f1e482bee2212677098c
Date: Thu Feb 06 13:54:36 2025
ap...@google.com <ap...@google.com> #9
Branch: main
commit b14927241155613d1aa8de398494d84fdec68f55
Author: Ian Zerny <zerny@google.com>
Date: Tue Apr 19 14:38:06 2022
Regression test for insertion of multiple interface bridges.
Bug:
Change-Id: I7591d8c02847a8908397a8a7966875b40dcd0fc1
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/main/java/com/android/tools/r8/shaking/RootSetUtils.java
A src/test/java/com/android/tools/r8/shaking/interfacebridge/MultipleRulesRegression228791247Test.java
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/utils/DepthFirstTopDownClassHierarchyTraversal.java
ap...@google.com <ap...@google.com> #10
Branch: main
commit f3628f7a1f18b25b04d25342da87985e3e573ee0
Author: Ian Zerny <zerny@google.com>
Date: Wed Apr 20 08:09:32 2022
Maintain canonical interface bridges.
Bug:
Change-Id: I81e2d06133c15a57c0547c66313cc7fdddafe1cc
M src/main/java/com/android/tools/r8/shaking/RootSetUtils.java
M src/test/java/com/android/tools/r8/shaking/methods/interfaces/MultipleRulesRegression228791247Test.java
ze...@google.com <ze...@google.com> #11
The reproduction in
We need to check the presence of this issue on our release branches so keeping this open until resolved on branches.
ap...@google.com <ap...@google.com> #12
Branch: 3.2
commit d883e9f3f238a0f9c9c9e3ec7ae3edd8be415bf9
Author: Ian Zerny <zerny@google.com>
Date: Thu Apr 21 11:12:10 2022
Version 3.2.57
Bug:
Change-Id: I134b9f021a6f8d1637d1a79c004ae0aa7a9ae434
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #13
Branch: 3.2
commit bc81e378b114b907afb0f5b75a4aa19421cd8541
Author: Ian Zerny <zerny@google.com>
Date: Thu Apr 21 11:11:02 2022
Maintain canonical interface bridges.
Bug:
Change-Id: I81e2d06133c15a57c0547c66313cc7fdddafe1cc
M src/main/java/com/android/tools/r8/shaking/RootSetUtils.java
M src/test/java/com/android/tools/r8/shaking/methods/interfaces/MultipleRulesRegression228791247Test.java
ap...@google.com <ap...@google.com> #14
Branch: 3.2
commit 19a4c33e710e4add60553f40c13afa1070f9bfab
Author: Ian Zerny <zerny@google.com>
Date: Thu Apr 21 11:08:43 2022
Regression test for insertion of multiple interface bridges.
Bug:
Change-Id: I7591d8c02847a8908397a8a7966875b40dcd0fc1
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/main/java/com/android/tools/r8/shaking/RootSetUtils.java
A src/test/java/com/android/tools/r8/shaking/interfacebridge/MultipleRulesRegression228791247Test.java
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/utils/DepthFirstTopDownClassHierarchyTraversal.java
ap...@google.com <ap...@google.com> #15
Branch: 3.1
commit 58b10fa7a87dd760a3a8dab1b9b3467ef0f25c22
Author: Ian Zerny <zerny@google.com>
Date: Thu Apr 21 11:29:47 2022
Version 3.1.72
Bug:
Change-Id: Ib8e3ff51d53a856b8c9b7cfdbba8a68890f795f2
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #16
Branch: 3.1
commit 7fb677412dfba1863e05eb2a74088ccd22d59942
Author: Ian Zerny <zerny@google.com>
Date: Thu Apr 21 11:28:35 2022
Maintain canonical interface bridges.
Bug:
Change-Id: I81e2d06133c15a57c0547c66313cc7fdddafe1cc
M src/main/java/com/android/tools/r8/shaking/RootSetUtils.java
M src/test/java/com/android/tools/r8/shaking/methods/interfaces/MultipleRulesRegression228791247Test.java
ap...@google.com <ap...@google.com> #17
Branch: 3.1
commit e939877e9a6c3c0537e08cddcbef06f87bcdb4b5
Author: Ian Zerny <zerny@google.com>
Date: Thu Apr 21 11:18:16 2022
Regression test for insertion of multiple interface bridges.
Bug:
Change-Id: I7591d8c02847a8908397a8a7966875b40dcd0fc1
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/main/java/com/android/tools/r8/shaking/RootSetUtils.java
A src/test/java/com/android/tools/r8/shaking/interfacebridge/MultipleRulesRegression228791247Test.java
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/utils/DepthFirstTopDownClassHierarchyTraversal.java
ap...@google.com <ap...@google.com> #18
Branch: 3.3
commit 312b16c970407cac05ee598180021714ea5d2e79
Author: Ian Zerny <zerny@google.com>
Date: Thu Apr 21 09:53:58 2022
Version 3.3.30
Bug:
Change-Id: I1ecdd5f31da25ce88c6e6fd4f2240cee3435e814
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #19
Branch: 3.3
commit a93207ef765f5cb22814c5d4d5e0b3b4e7228e2d
Author: Ian Zerny <zerny@google.com>
Date: Thu Apr 21 09:52:07 2022
Maintain canonical interface bridges.
Bug:
Change-Id: I81e2d06133c15a57c0547c66313cc7fdddafe1cc
M src/main/java/com/android/tools/r8/shaking/RootSetUtils.java
M src/test/java/com/android/tools/r8/shaking/methods/interfaces/MultipleRulesRegression228791247Test.java
ap...@google.com <ap...@google.com> #20
Branch: 3.3
commit e75e0e5696ba55c160fc1fe05d98f28542ee17f4
Author: Ian Zerny <zerny@google.com>
Date: Thu Apr 21 09:06:53 2022
Regression test for insertion of multiple interface bridges.
Bug:
Change-Id: I7591d8c02847a8908397a8a7966875b40dcd0fc1
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/main/java/com/android/tools/r8/shaking/RootSetUtils.java
A src/test/java/com/android/tools/r8/shaking/interfacebridge/MultipleRulesRegression228791247Test.java
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/utils/DepthFirstTopDownClassHierarchyTraversal.java
ap...@google.com <ap...@google.com> #21
Branch: 3.2
commit bc81e378b114b907afb0f5b75a4aa19421cd8541
Author: Ian Zerny <zerny@google.com>
Date: Thu Apr 21 11:11:02 2022
Maintain canonical interface bridges.
Bug:
Change-Id: I81e2d06133c15a57c0547c66313cc7fdddafe1cc
M src/main/java/com/android/tools/r8/shaking/RootSetUtils.java
M src/test/java/com/android/tools/r8/shaking/methods/interfaces/MultipleRulesRegression228791247Test.java
ap...@google.com <ap...@google.com> #22
Branch: 3.2
commit 19a4c33e710e4add60553f40c13afa1070f9bfab
Author: Ian Zerny <zerny@google.com>
Date: Thu Apr 21 11:08:43 2022
Regression test for insertion of multiple interface bridges.
Bug:
Change-Id: I7591d8c02847a8908397a8a7966875b40dcd0fc1
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/main/java/com/android/tools/r8/shaking/RootSetUtils.java
A src/test/java/com/android/tools/r8/shaking/interfacebridge/MultipleRulesRegression228791247Test.java
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/utils/DepthFirstTopDownClassHierarchyTraversal.java
ap...@google.com <ap...@google.com> #23
Branch: 3.3
commit a93207ef765f5cb22814c5d4d5e0b3b4e7228e2d
Author: Ian Zerny <zerny@google.com>
Date: Thu Apr 21 09:52:07 2022
Maintain canonical interface bridges.
Bug:
Change-Id: I81e2d06133c15a57c0547c66313cc7fdddafe1cc
M src/main/java/com/android/tools/r8/shaking/RootSetUtils.java
M src/test/java/com/android/tools/r8/shaking/methods/interfaces/MultipleRulesRegression228791247Test.java
ap...@google.com <ap...@google.com> #24
Branch: 3.3
commit e75e0e5696ba55c160fc1fe05d98f28542ee17f4
Author: Ian Zerny <zerny@google.com>
Date: Thu Apr 21 09:06:53 2022
Regression test for insertion of multiple interface bridges.
Bug:
Change-Id: I7591d8c02847a8908397a8a7966875b40dcd0fc1
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/main/java/com/android/tools/r8/shaking/RootSetUtils.java
A src/test/java/com/android/tools/r8/shaking/interfacebridge/MultipleRulesRegression228791247Test.java
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/utils/DepthFirstTopDownClassHierarchyTraversal.java
pr...@gmail.com <pr...@gmail.com> #25
I wasn't able to test it on a running application of mine yet, because of another issue, but it probably should work fine!
ze...@google.com <ze...@google.com> #26
Thanks for confirming and again for taking the time to report the issue! The fix has now been included on release branches back to 3.1
Description
Description has been deleted.