AndroidTest.packaging.jniLibs.keepDebugSymbols doesn't affect androidTest packaging [228846664]

Fixed

Bug

Status Update

No update yet.

Description

sp...@google.com

created issue #1

Apr 11, 2022 05:02PM

Currently, AndroidTest.packaging.jniLibs.keepDebugSymbols has no effect on native library stripping in androidTest APKs... native libraries are packaged unstripped regardless.

Proposal: For androidTest APKs, AGP should continue to package unstripped native libraries by default, but if AndroidTest.packaging.jniLibs.keepDebugSymbols contains any patterns, only the matching native libraries should be packaged unstripped.

See Issue 228627720 for context.

Edit: See #3 for new proposal.

Comments

au...@google.com <au...@google.com> #2Dec 21, 2022 12:13AM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

sp...@google.com <sp...@google.com> #3Dec 28, 2022 07:01PM

Almost 2 months later and this is still broken

Message last modified on Jan 3, 2023 08:24PM

je...@google.com <je...@google.com> #4Jan 3, 2023 08:19PM

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

sp...@google.com <sp...@google.com> #5Jan 3, 2023 08:24PM

jb...@google.com What is the update on this?

sp...@google.com <sp...@google.com> #6Jan 5, 2023 05:58PM

Reassigned to jo...@google.com.

What is the status of this item?

da...@google.com <da...@google.com> #7Jan 19, 2023 07:44PM

Reassigned to sp...@google.com.

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

sp...@google.com <sp...@google.com> #8Jan 19, 2023 11:12PM

Any ETA on next release?

da...@google.com <da...@google.com> #9Jan 19, 2023 11:29PM

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

em...@google.com <em...@google.com> #10Jan 20, 2023 12:20AM

Comfirmed that this seems to still be broken. Can we have an update please?

```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1

(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```

sp...@google.com <sp...@google.com> #11Jan 20, 2023 05:20AM

Hi, is there any update to this issue? Thanks.

sp...@google.com <sp...@google.com> #12Jan 23, 2023 07:59PM

Hi Google. You claim it's been fixed on master, but we haven't had a new release since the broken version 26.1.1. Can you please release the fix?

sp...@google.com <sp...@google.com> #13Feb 7, 2023 07:48PM

Yeah, still not fixed --'

au...@google.com <au...@google.com> #14May 3, 2023 11:44PM

Can't believe this still isn't fixed 2 years later for a command line utility that sits on the main dev site.

sp...@google.com <sp...@google.com> #15May 4, 2023 06:06PM

Reassigned to em...@google.com.

Any updates on this? The help for this command clearly states this argument is supported.

em...@google.com <em...@google.com> #16May 4, 2023 08:48PM

Has anyone re-tried it? We switched back to RUN sdkmanager --package_file=$ANDROID_HOME/packages.txt in our Dockerfile back in March of 2021.

au...@google.com <au...@google.com> #17May 4, 2023 08:51PM

For what it's worth, I did a quick test with the latest CLI: 11076708 (https://developer.android.com/studio#downloads) on OSX and tried it with a simple:

./sdkmanager --sdk_root="../sdk" --package_file=deps.txt

Deps.txt:

platform-tools
extras;google;instantapps
build-tools;35.0.0-rc3

So perhaps this is now resolved? I haven't tried it with more packages

sp...@google.com <sp...@google.com> #18May 4, 2023 09:06PM

Before looking into this, it would be nice to create a simple test app that demonstrates the problem.

Would it make sense to go ahead and merge ag/21235820 on the AGP side, and then I expect the repro project from Issue 268223043 would demonstrate the problem after updating to the version of AGP with the fix.

em...@google.com <em...@google.com> #19May 6, 2023 01:13AM

The test app from Issue 268223043 (MyApplication29.zip) is rather trivial, debugging the instrumented test in that app already works (after patching your ag/21235820 + building/using AGP 8.2.0-dev) without any additional modifications on Android Studio native debuggers side.

A more complex test app would have:

An 'app' module with native code.
A 'lib' module with native code.
An app-to-lib androidTestImplementation dependency.

And, test cases:

Run instrumented test of 'app' module, verify:
a. hit native breakpoints in 'app' module
b. hit native breakpoints in 'lib' module
Run instrumented test of 'lib' module, verify:
a. hit native breakpoints in 'lib' module.

Current Status (studio-main, around Hedgehog canary 3):

The following tests pass: 1(a), 2(a)
The following tests fail: 1(b)

I prepared ag/23066587, which also makes 1(b) pass. I need to add some integration tests to that change.

spollom@ Feel free to submit your ag/21235820.

sp...@google.com <sp...@google.com> #20May 6, 2023 03:36AM

Thanks, Emre!

sp...@google.com <sp...@google.com> #21May 8, 2023 05:59PM

spollom@ Feel free to submit your ag/21235820.

Just merged it.

em...@google.com <em...@google.com> #22May 10, 2023 10:13PM

Marked as fixed.

I just merged ag/23066587, which should fix the debugger for 1(b) in comment19. Adding integration tests is still WIP, it's done but is flaky due to some unexpected resource leaks.

au...@google.com <au...@google.com> #23May 10, 2023 10:31PM

Is it too risky to cp this to 8.1.0?

sp...@google.com <sp...@google.com> #24May 10, 2023 10:40PM

ag/21235820 is not too risky, but I assume if we CP it, we'd need to CP ag/23066587 and any other necessary changes in the IDE... not sure if those are too risky.

au...@google.com <au...@google.com> #25May 10, 2023 10:47PM

I'd love to see https://googleplex-android-review.git.corp.google.com/c/platform/tools/base/+/21235820 in 8.1.0

hs...@gmail.com <hs...@gmail.com> #26Oct 14, 2023 07:58AM

Could someone share in which version of AGP this issue is (planned to be) fixed?

em...@google.com <em...@google.com> #27Oct 16, 2023 08:04AM

The fix is in 8.2.0 and newer. It's currently in beta, but a stable version will be available soon.