painterResource Doesn't recompose on config changes like the other *Resource functions [228862715]

Fixed

Bug

Status Update

No update yet.

Description

jo...@veeva.com

created issue #1

Apr 11, 2022 06:57PM

Jetpack Compose version: 1.2.0-alpha07
Jetpack Compose component used: androidx.compose.ui.res.painterResource
Android Studio Build:
Android Studio Bumblebee | 2021.1.1 Patch 3
Build #AI-211.7628.21.2111.8309675, built on March 16, 2022
Runtime version: 11.0.11+0-b60-7590822 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 11.6.5
GC: G1 Young Generation, G1 Old Generation
Memory: 4096M
Cores: 16
Registry: external.system.auto.import.disabled=true, ide.instant.shutdown=false
Non-Bundled Plugins: com.dubreuia (2.2.0), com.intellij.javafx (1.0.4), org.jetbrains.kotlin (211-1.6.20-release-275-AS7442.40), com.intellij.lang.jsgraphql (3.1.2), org.intellij.plugins.markdown (211.7142.37),

com.jetbrains.edu (2022.1-2021.1-1326)

Kotlin version: 1.6.10

Steps to Reproduce or Code Sample to Reproduce:
1. Display an Image composable using a painterResource, where the drawable resource has both a light and a night version.
2. Add the following to your activity in your AndroidManifest.xml: android:configChanges="colorMode|density|fontScale|keyboard|keyboardHidden|layoutDirection|locale|mcc|mnc|navigation|orientation|screenLayout|screenSize|smallestScreenSize|touchscreen|uiMode"
3. Rebuild and run the application and view your image from step 1.
4. Toggle the Night/Light Mode setting on the device
5. See that the displayed image is not updated to utilize the night mode version of the resource.

KotlinLang Slack discussion for more context/Info:

https://kotlinlang.slack.com/archives/CJLTWPH7S/p1649700912623109

Stack trace (if applicable):

Comments

ae...@google.com <ae...@google.com> Apr 12, 2022 11:57PM

Assigned to nj...@google.com.

al...@mercari.com <al...@mercari.com> #2Aug 9, 2022 08:51AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a19b9ecab7e78804a61ba8481cc14cdb25d4d675
Author: Ralston Da Silva <ralu@google.com>
Date: Thu Dec 03 16:09:45 2020

Renaming focusObserver

Renaming Modifier.focusObserver() to Modifier.onFocusEvent() and Modifier.onFocusChanged

Bug: 168511863
Bug: 168511484
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.FocusChangedCountTest
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.FocusEventCountTest
Relnote: Modifier.focusObserver is deprecated. Use Modifier.onFocusChanged or Modifier.onFocusEvent instead
Change-Id: I30f17d06d60fa9b8c510ee0468464258894a467b

M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeInputFieldFocusTransition.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/TextFieldCursorTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/TextFieldFocusTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/TextFieldTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldInputServiceIntegrationTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Focusable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/OutlinedTextFieldTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/TextFieldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/autofill/ExplicitAutofillTypesDemo.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/FocusableDemo.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/ReuseFocusRequester.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/keyinput/KeyInputDemo.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/CaptureFocusTest.kt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusChangedCountTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusChangedTest.kt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusEventCountTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusManagerAmbientTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusModifierAttachDetachTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusRequesterTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FreeFocusTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/OwnerFocusTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/ReusedFocusRequesterCaptureFocusTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/ReusedFocusRequesterFreeFocusTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/ReusedFocusRequesterTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/SetRootFocusTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/FocusModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/FocusObserverModifier.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusChangedModifier.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusEventModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/DelegatingLayoutNodeWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/InnerPlaceable.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/ModifiedFocusEventNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/ModifiedFocusNode.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/focus/FocusChangedModifierTest.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/focus/FocusEventModifierTest.kt

https://android-review.googlesource.com/1516789

be...@google.com <be...@google.com> Aug 12, 2022 08:50PM

Reassigned to be...@google.com.

ap...@google.com <ap...@google.com> #3Aug 13, 2022 02:02PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 72bcfb498302e80563b2eb6037ef54079eb5bb55
Author: Ben Trengrove <bentrengrove@google.com>
Date: Wed Aug 10 20:49:34 2022

Fix painterResource not subscribing to configuration changes

Fixes: 228862715
Test: PainterResourcesDemo
Relnote: Fixed an issue where painterResource wouldn't update on configuration changes
Change-Id: I58e732cd43766d41a7f8f732c6bf519548a695d7

A compose/ui/ui/integration-tests/ui-demos/src/main/res/drawable-night/ic_painterresource.xml
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/UiDemos.kt
A compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/PainterResourcesDemo.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/res/VectorResources.android.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/res/StringResources.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidCompositionLocals.android.kt
M compose/ui/ui/api/restricted_current.txt
A compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/res/Resources.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/res/PainterResources.android.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/AndroidManifest.xml
A compose/ui/ui/integration-tests/ui-demos/src/main/res/drawable/ic_painterresource.xml
M compose/ui/ui/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2182977

Issue 228862715

Description

Issue summary

Comments

ae...@google.com <ae...@google.com> Apr 12, 2022 11:57PM

al...@mercari.com <al...@mercari.com> #2Aug 9, 2022 08:51AM

be...@google.com <be...@google.com> Aug 12, 2022 08:50PM

ap...@google.com <ap...@google.com> #3Aug 13, 2022 02:02PM

Add comment

Issue metadata