DeleteSurroundingTextCommand tries to replace with negative end index [228862731]

Obsolete

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Apr 12, 2022 03:30PM

Jetpack Compose version: 1.2.0 alpha 7
Jetpack Compose component used: M3 1.0 alpha 9
Android Studio Build: AGP 7.3 A6
Kotlin version: 1.6.20
Devices/Android versions reproduced on: Pixel 5
Keyboard (i.e. Gboard, Samsung, etc): Don't know

Since updating compose / M3 I'm getting crash report from Play Store pre launch reports on Pixel 5 / Android 11 locale el_GR

See attached video from pre launch crash occurs near 2:00

Full pre launch log cat included too.

Not able to reproduce on my devices or emulators

Stack trace:

java.lang.IllegalArgumentException: end cannot negative. [end: -1]
        at androidx.compose.ui.text.TextRangeKt.packWithCheck(TextRange.kt:124)
        at androidx.compose.ui.text.TextRangeKt.TextRange(TextRange.kt:37)
        at androidx.compose.ui.text.input.EditingBuffer.delete$ui_text_release(EditingBuffer.kt:205)
        at androidx.compose.ui.text.input.DeleteSurroundingTextCommand.applyTo(EditCommand.kt:271)
        at androidx.compose.ui.text.input.EditProcessor.apply(EditProcessor.java:110)
        at androidx.compose.foundation.text.TextFieldKeyInput.apply(TextFieldKeyInput.kt:62)
        at androidx.compose.foundation.text.TextFieldKeyInput.access$apply(TextFieldKeyInput.java:49)
        at androidx.compose.foundation.text.TextFieldKeyInput$process$2.invoke(TextFieldKeyInput.java:134)
        at androidx.compose.foundation.text.TextFieldKeyInput$process$2.invoke(TextFieldKeyInput.java:102)
        at androidx.activity.compose.BackHandlerKt$BackHandler$2.invoke$bridge(BackHandler.kt:0)
        at androidx.compose.foundation.text.TextFieldKeyInput.commandExecutionContext(TextFieldKeyInput.java:211)
        at androidx.compose.foundation.text.TextFieldKeyInput.process-ZmokQxo(TextFieldKeyInput.java:102)
        at androidx.compose.foundation.text.TextFieldKeyInputKt$textFieldKeyInput$2$1.invoke-ZmokQxo(TextFieldKeyInput.kt:243)
        at androidx.compose.foundation.text.TextFieldKeyInputKt$textFieldKeyInput$2$1.invoke(TextFieldKeyInput.kt:243)
        at androidx.compose.animation.core.InfiniteTransition$run$1$1.invoke$bridge(InfiniteTransition.kt:0)
        at androidx.compose.ui.input.key.KeyInputModifier.propagateKeyEvent-ZmokQxo(KeyInputModifier.kt:124)
        at androidx.compose.ui.input.key.KeyInputModifier.processKeyInput-ZmokQxo(KeyInputModifier.java:103)
        at androidx.compose.ui.platform.AndroidComposeView.sendKeyEvent-ZmokQxo(AndroidComposeView.android.kt:584)
        at androidx.compose.ui.platform.AndroidComposeView.dispatchKeyEvent(AndroidComposeView.android.kt:591)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1959)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1959)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1959)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1959)
        at com.android.internal.policy.DecorView.superDispatchKeyEvent(DecorView.java:476)
        at com.android.internal.policy.PhoneWindow.superDispatchKeyEvent(PhoneWindow.java:1863)
        at android.app.Activity.dispatchKeyEvent(Activity.java:4085)
        at androidx.core.app.ComponentActivity.superDispatchKeyEvent(ComponentActivity.java:124)
        at androidx.core.view.KeyEventDispatcher.dispatchKeyEvent(KeyEventDispatcher.java:86)
        at androidx.core.app.ComponentActivity.dispatchKeyEvent(ComponentActivity.java:142)
        at com.android.internal.policy.DecorView.dispatchKeyEvent(DecorView.java:390)
        at android.view.ViewRootImpl$ViewPostImeInputStage.processKeyEvent(ViewRootImpl.java:5953)
        at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:5821)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5316)
        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5373)
        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5339)
        at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5491)
        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5347)
        at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:5548)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5320)
        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5373)
        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5339)
        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5347)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5320)
        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5373)
        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5339)
        at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5524)
        at android.view.ViewRootImpl$ImeInputStage.onFinishedInputEvent(ViewRootImpl.java:5682)
        at android.view.inputmethod.InputMethodManager$PendingEvent.run(InputMethodManager.java:3180)
        at android.view.inputmethod.InputMethodManager.invokeFinishedInputEventCallback(InputMethodManager.java:2722)
        at android.view.inputmethod.InputMethodManager.finishedInputEvent(InputMethodManager.java:2713)
        at android.view.inputmethod.InputMethodManager$ImeInputEventSender.onInputEventFinished(InputMethodManager.java:3157)
        at android.view.InputEventSender.dispatchInputEventFinished(InputEventSender.java:143)
        at android.os.MessageQueue.nativePollOnce(Native Method)
        at android.os.MessageQueue.next(MessageQueue.java:335)
        at android.os.Looper.loop(Looper.java:183)
        at android.app.ActivityThread.main(ActivityThread.java:7664)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

video (1).mp4

2 MB

Download

logcat.txt

3.4 MB

View

Download

Comments

re...@gmail.com <re...@gmail.com> #2May 6, 2022 06:52AM

Possibly duplicate of 199919707

so...@google.com <so...@google.com> #3Jul 12, 2022 10:02AM

From duplicate tickets this was also reported with

Jetpack Compose version:1.0.5

Kotlin version:1.5.31

kl...@google.com <kl...@google.com> Jul 12, 2022 04:54PM

Reassigned to kl...@google.com.

ah...@gmail.com <ah...@gmail.com> #4Jul 13, 2022 12:37PM

same error too.

kl...@google.com <kl...@google.com> Jul 13, 2022 07:04PM

Accepted by kl...@google.com.

ap...@google.com <ap...@google.com> #5Jul 14, 2022 04:41PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9bfe4c74872d0d4c9e0386382b126a9d56b8b7a7
Author: Zach Klippenstein <klippenstein@google.com>
Date: Tue Jul 12 10:49:46 2022

Add validation to troubleshoot

b/228862731

.

Adds runtime checks in PartialGapBuffer.replace to ensure the incoming
indices are valid, some tests, and adds information to exceptions thrown
when applying an EditCommand batch that describes the batch and buffer
state.

Bug:

b/228862731

Test: ./gradlew :compose:ui:ui-text:test
Relnote: "Added `toStringForLog()` method to `EditCommand` to help
troubleshoot text editing issues."
Change-Id: I53354b781acb7c000c57a293aaf8bc030ac0e484

M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/EditProcessorTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextRange.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/GapBuffer.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/EditingBufferTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/EditCommand.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/GapBufferTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/EditingBuffer.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/EditProcessor.kt
M compose/ui/ui-text/api/current.txt

https://android-review.googlesource.com/2151717

si...@google.com <si...@google.com> #6Aug 16, 2022 11:44PM

One thing I didnt understand in the video is: do you click on hardware keyboard delete when the screen crashes?

because i couldnt see the touch indicator

kl...@google.com <kl...@google.com> #7Sep 21, 2023 11:21PM

Status: Won't Fix (Obsolete)

The only open bug report with the new diagnostics is b/246635327. Closing as obsolete in favor of that one.