Fixed
Status Update
Comments
jn...@google.com <jn...@google.com> #2
Regression appears to have been caused by aosp/2758367
mk...@google.com <mk...@google.com>
ap...@google.com <ap...@google.com> #3
We should probably update the benchmark to use the new flags to turn off the animations.
mk...@google.com <mk...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 136cfb249a9623d712b82db6b0832ccd63e3e582
Author: mkulaha <mkulaha@google.com>
Date: Wed Oct 04 08:05:18 2023
Possible fix for performance drop in PositionIndicator. Additional microbenchmark tests were added.
We saw some performance drops in PositionIndicator, that might happen due to chained snapshotFlow, which slows down the `firstPixel` benchmark.
Extra tests were added to separately check animated and non-animated PositionIndicator
Doc with benchmark results go/position-indicator-aosp_2770702
Bug: 302399827
Test: PositionIndicatorBenchmark.kt
Relnote: "Fixed performance issues in PositionIndicator"
Change-Id: I1c6546abc834f718c9d8f11d756262d507590acc
M wear/compose/compose-material/benchmark/src/androidTest/java/androidx/wear/compose/material/benchmark/PositionIndicatorBenchmark.kt
M wear/compose/compose-material/src/main/java/androidx/wear/compose/material/PositionIndicator.kt
https://android-review.googlesource.com/2770702
Branch: androidx-main
commit 136cfb249a9623d712b82db6b0832ccd63e3e582
Author: mkulaha <mkulaha@google.com>
Date: Wed Oct 04 08:05:18 2023
Possible fix for performance drop in PositionIndicator. Additional microbenchmark tests were added.
We saw some performance drops in PositionIndicator, that might happen due to chained snapshotFlow, which slows down the `firstPixel` benchmark.
Extra tests were added to separately check animated and non-animated PositionIndicator
Doc with benchmark results go/position-indicator-aosp_2770702
Bug: 302399827
Test: PositionIndicatorBenchmark.kt
Relnote: "Fixed performance issues in PositionIndicator"
Change-Id: I1c6546abc834f718c9d8f11d756262d507590acc
M wear/compose/compose-material/benchmark/src/androidTest/java/androidx/wear/compose/material/benchmark/PositionIndicatorBenchmark.kt
M wear/compose/compose-material/src/main/java/androidx/wear/compose/material/PositionIndicator.kt
Description
Version used: Alpha20
Close if intentional.
I'm using the same component in the list page, and then as one item in the detail page. AppCard requires an onClick, and doesn't allow setting enabled = false.
So I'll have to duplicate the whole AppCard to make it look the same but not clickable. It doesn't make sense for it to have a ripple and do nothing when clicked.
```
@Composable
public fun AppCard(
onClick: () -> Unit,
appName: @Composable () -> Unit,
time: @Composable () -> Unit,
title: @Composable () -> Unit,
modifier: Modifier = Modifier,
appImage: @Composable (() -> Unit)? = null,
backgroundPainter: Painter = CardDefaults.cardBackgroundPainter(),
appColor: Color = MaterialTheme.colors.onSurfaceVariant,
timeColor: Color = MaterialTheme.colors.onSurfaceVariant,
titleColor: Color = MaterialTheme.colors.onSurface,
contentColor: Color = MaterialTheme.colors.onSurfaceVariant,
content: @Composable () -> Unit,
) {
Card(
onClick = onClick,
modifier = modifier,
backgroundPainter = backgroundPainter,
enabled = true,
```