Fixed
Status Update
No update yet.
Comments
jn...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt - M
compose/foundation/foundation/api/restricted_current.txt - M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt - M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt - M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt - M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
mk...@google.com
ap...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06androidx.compose.foundation:foundation-android:1.8.0-alpha06androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
mk...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e3d0f4f6616e50bda19930ae0277094401052257
Author: mkulaha <mkulaha@google.com>
Date: Thu Apr 14 11:12:24 2022
Add more tests fort AppCard and TitleCard
Bug: 228869805
Test: wear.compose.material.CardTest
Relnote: "Add more tests fort AppCard and TitleCard"
Change-Id: I85391f610a7ff821796a10cf94045d0c009c2803
M wear/compose/compose-material/src/androidAndroidTest/kotlin/androidx/wear/compose/material/CardTest.kt
https://android-review.googlesource.com/2063833
Branch: androidx-main
commit e3d0f4f6616e50bda19930ae0277094401052257
Author: mkulaha <mkulaha@google.com>
Date: Thu Apr 14 11:12:24 2022
Add more tests fort AppCard and TitleCard
Bug: 228869805
Test: wear.compose.material.CardTest
Relnote: "Add more tests fort AppCard and TitleCard"
Change-Id: I85391f610a7ff821796a10cf94045d0c009c2803
M wear/compose/compose-material/src/androidAndroidTest/kotlin/androidx/wear/compose/material/CardTest.kt
Description
Version used: Alpha20
Close if intentional.
I'm using the same component in the list page, and then as one item in the detail page. AppCard requires an onClick, and doesn't allow setting enabled = false.
So I'll have to duplicate the whole AppCard to make it look the same but not clickable. It doesn't make sense for it to have a ripple and do nothing when clicked.
```
@Composable
public fun AppCard(
onClick: () -> Unit,
appName: @Composable () -> Unit,
time: @Composable () -> Unit,
title: @Composable () -> Unit,
modifier: Modifier = Modifier,
appImage: @Composable (() -> Unit)? = null,
backgroundPainter: Painter = CardDefaults.cardBackgroundPainter(),
appColor: Color = MaterialTheme.colors.onSurfaceVariant,
timeColor: Color = MaterialTheme.colors.onSurfaceVariant,
titleColor: Color = MaterialTheme.colors.onSurface,
contentColor: Color = MaterialTheme.colors.onSurfaceVariant,
content: @Composable () -> Unit,
) {
Card(
onClick = onClick,
modifier = modifier,
backgroundPainter = backgroundPainter,
enabled = true,
```