startActivityAndWait doesn't work on Automated Test Devices [228946895]

Fixed

Bug

Status Update

No update yet.

Description

wk...@google.com

created issue #1

Apr 12, 2022 12:30PM

startActivityAndWait can't detect Activity launch on Automated Test Devices, a type of Gradle Managed Device that is headless:

android {
    ...
    testOptions {
        managedDevices {
            devices {
                rootedDeviceAtd (com.android.build.api.dsl.ManagedVirtualDevice) {
                    device = "Pixel 2"
                    // Use only API levels 27 and higher
                    apiLevel = 31
                    // To include Google services, use "google"
                    systemImageSource = "aosp-atd" // <- WORKS WITH "aosp", NOT "aosp-atd"
                }
            }
        }
    }
}

It seems that no frames in framestats are marked with 0x1 flag, so lastLaunchNs is always null. Could you fall back to lastFrameNs in that case or think of something else?

I'll try to add someone from ATD here to weigh in on this from the ATD side and why it doesn't produce launch frames.

Comments

br...@google.com <br...@google.com> #2Apr 19, 2022 12:43AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

cc...@google.com <cc...@google.com> #3Apr 19, 2022 05:19PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

br...@google.com <br...@google.com> #4Apr 19, 2022 05:26PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

wk...@google.com <wk...@google.com> #5Apr 20, 2022 07:40AM

@ccraik - yes, this is for baseline profiles. This is low priority, but I thought I'd file it anyway in case it's a symptom of some larger problem either with our Activity launch detection or with ATDs.

More context why I'm investigating this: I want to make it as easy as possible for apps and libraries to integrate generating profiles into their build/CIs, and with Gradle Managed Devices it becomes really easy and we can give folks a copy-pasteable recipe for doing it in Gradle, regardless of CI system used etc.

Using Automated Test Device images (when running with Gradle Managed Devices) would be even faster and require fewer resources (important for example on CIs with limited RAM etc), but it's not critical, hence the lower priority.

cc...@google.com <cc...@google.com> #6Apr 26, 2022 12:07AM

How do I download the managed device? The only docs I see don't say. Using your definition above in AndroidX (Dolphin Canary 7), I run:

./gradlew wear:compose:integration-tests:macrobenchmark:rootedDeviceAtdDebugAndroidTest

(Tried also with -Pandroid.sdk.channel=3)

and I get the error:

> Task :wear:compose:integration-tests:macrobenchmark:rootedDeviceAtdSetup FAILED
WARNING:system-images;android-31;default;x86_64 package is not installed.

...

* What went wrong:
Execution failed for task ':wear:compose:integration-tests:macrobenchmark:rootedDeviceAtdSetup'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.ManagedDeviceSetupTask$ManagedDeviceSetupRunnable
   > Generated invalid hash string "system-images;android-31;default;x86_64" from the DSL. This should not occur.

wk...@google.com <wk...@google.com> #7Apr 26, 2022 11:08AM

they should be downloaded automatically, but I vaguely remember having a similar problem... I think this mention in the docs was what helped me:

Before getting started, make sure you update the Android Emulator to the latest available version

Can you launch the canary version of Android Studio and "Check for updates..." to make sure you have the latest version of emulator installed? You could also try deleting ~/.android/gradle/avd

Let me know if that helped and if not I can look into it more

cc...@google.com <cc...@google.com> #8Apr 26, 2022 05:29PM

Tried updating to "Android Emulator (revision: 31.3.7)", which didn't help.

I don't see ~/.android/gradle/avd, did you mean ~/.android/avd? Should this be separate from all my standard emulators?

I'll just upload a speculative fix, and let you try it out with a snapshot, since that's easy.

Message last modified on Apr 26, 2022 05:30PM

ar...@google.com <ar...@google.com> #9Apr 26, 2022 08:31PM

Daniel, can you help with the download issue?

da...@google.com <da...@google.com> #10Apr 26, 2022 10:57PM

Generated invalid hash string "system-images;android-31;default;x86_64" from the DSL. This should not occur.

That looks like an aosp ("default") image not an atd image (would be system-images;android-31;aosp_atd;x86_64).

Can you run:

./gradlew --info wear:compose:integration-tests:macrobenchmark:rootedDeviceAtdSetup

And send the output?

wk...@google.com <wk...@google.com> #11May 6, 2022 02:39PM

Hey Chris, I know this is probably low priority, but just in case you did upload any fixes, I tried on latest snapshot of Macrobenchmark today and still got the same error

ap...@google.com <ap...@google.com> #12Sep 9, 2022 08:55PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 597e8b0ade2b28bd01657b806307c6838dea54e7
Author: Chris Craik <ccraik@google.com>
Date: Thu Sep 08 16:51:06 2022

Remove check for launch flag for launch confirmation

Fixes: 244594339
Fixes: 228946895
Test: ./gradlew bench:b-m:cC

Relnote: "Fix bug where startActivityAndWait would timeout trying to
wait forlaunch completion on emulators by reducing strictness of frame
detection."

Change-Id: Ibe2c6c5519973f5c3311f4abb02e21c66a77bd2e

M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/FrameStatsResult.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MacrobenchmarkScope.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/FrameStatsResultTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MacrobenchmarkScopeTest.kt

https://android-review.googlesource.com/2212663

cc...@google.com <cc...@google.com> Sep 9, 2022 08:59PM