Lint visitAnnotationUsage not called for usages of annotated classes in variable declarations [228961124]

Fixed

Bug

Status Update

No update yet.

Description

al...@google.com

created issue #1

Apr 12, 2022 02:46PM

Originally found in b/227166311 for @RequiresOptIn detector.

For the following usage where AnnotatedJavaClass is annotated with an applicable annotation:

    /**
     * Unsafe references to experimental Java class in variable declaration.
     */
    void unsafeDeclarationUsage() {
        AnnotatedJavaClass obj = null;
        obj = new AnnotatedJavaClass();
    }

A lint detector will receive a callback to visitAnnotationUsage for the constructor call; however, it will not receive a callback for the variable declaration on the preceding line.

There's possibly an argument to be made for the usage of obj on the LHS of the assignment with the constructor, as well. The Kotlin compiler will raise three warnings in its own implementation of @RequiresOptIn detection: the declaration of obj, the reference on the LHS of the assignment, and the constructor call on the RHS of the assignment.

Comments

jo...@google.com <jo...@google.com> Apr 12, 2022 02:51PM

Assigned to an...@google.com.

er...@google.com <er...@google.com> #2May 22, 2023 06:19PM

I'd like to fix the formatting but I can't edit my issue.

an...@google.com <an...@google.com> #3Jun 22, 2023 08:01AM

Status: Won't Fix (Not Reproducible)

Our team is also running into this because we use kotlin reflection to set up mock data for previews.

Can you suggest any workaround that we can apply locally to make layout lib include kotlin reflect until it is officially fixed? We are obviously including it as a build dependency but the layout lib preview doesn't pick it up for some reason.

al...@google.com <al...@google.com> #4Jun 22, 2023 01:35PM

Status: Assigned (reopened)

I do not see this issue in Electric Eel Beta 4, but I do see it in Flamingo Canary 6.

al...@google.com <al...@google.com> #5Jun 22, 2023 01:37PM

I do not see this issue in Electric Eel Beta 4, but I do see it in Flamingo Canary 6.

Is it with the very same project? I'm trying to rule out whether this is related to specific library/compiler versions.

Thanks!

bl...@google.com <bl...@google.com> Sep 14, 2023 08:12PM

Reassigned to bl...@google.com.

bl...@google.com <bl...@google.com> Sep 19, 2023 07:14PM

Marked as fixed.

an...@google.com <an...@google.com> #6Sep 21, 2023 09:04PM

Yes, that was with the same project. I can double check with the latest versions of each IDE and get back to you though.

bl...@google.com <bl...@google.com> #7Sep 29, 2023 10:36PM

Status: Assigned (reopened)

Correction: I was either mistaken before, or behavior has changed, but I am now getting the KotlinReflectionNotSupportedError issue for IDE compose previews in both EE Beta 5 and Flamingo Canary 8.

Kotlin 1.6.21 AGP 7.3

bl...@google.com <bl...@google.com> Oct 24, 2023 11:47PM