Lint visitAnnotationUsage not called for usages of annotated classes in variable declarations [228961124]

Fixed

Bug

Status Update

No update yet.

Description

al...@google.com

created issue #1

Apr 12, 2022 02:46PM

Originally found in b/227166311 for @RequiresOptIn detector.

For the following usage where AnnotatedJavaClass is annotated with an applicable annotation:

    /**
     * Unsafe references to experimental Java class in variable declaration.
     */
    void unsafeDeclarationUsage() {
        AnnotatedJavaClass obj = null;
        obj = new AnnotatedJavaClass();
    }

A lint detector will receive a callback to visitAnnotationUsage for the constructor call; however, it will not receive a callback for the variable declaration on the preceding line.

There's possibly an argument to be made for the usage of obj on the LHS of the assignment with the constructor, as well. The Kotlin compiler will raise three warnings in its own implementation of @RequiresOptIn detection: the declaration of obj, the reference on the LHS of the assignment, and the constructor call on the RHS of the assignment.

Comments

jo...@google.com <jo...@google.com> Apr 12, 2022 02:51PM

Assigned to an...@google.com.

er...@google.com <er...@google.com> #2May 22, 2023 06:19PM

Thanks for the feedback. We are sorry it took so long for us to get to this report. We would really appreciate it if you could confirm that this is still an issue for you and if so we will route it to the right team. For information of what’s needed in the report please don’t forget to read this guide at https://developer.android.com/studio/report-bugs

an...@google.com <an...@google.com> #3Jun 22, 2023 08:01AM

Status: Won't Fix (Not Reproducible)

Our team had requested additional information for this issue which was not provided within 30 days. Unfortunately there is not enough information for us to proceed and this issue is now closed.

In the future, if you encounter this or any other issue, please read

https://developer.android.com/studio/report-bugs.html and file a new bug report with all the required information. This will help ensure the team can correctly triage, reproduce, and resolve your issue.

Thank you!

al...@google.com <al...@google.com> #4Jun 22, 2023 01:35PM

Status: Assigned (reopened)

Thanks for the feedback. We are sorry it took so long for us to get to this report. We would really appreciate it if you could confirm that this is still an issue for you and if so we will route it to the right team.

Yes.

al...@google.com <al...@google.com> #5Jun 22, 2023 01:37PM

aosp/2060764 contains the regression test for AndroidX and it is still failing.

bl...@google.com <bl...@google.com> Sep 14, 2023 08:12PM

Reassigned to bl...@google.com.

bl...@google.com <bl...@google.com> Sep 19, 2023 07:14PM

Marked as fixed.

an...@google.com <an...@google.com> #6Sep 21, 2023 09:04PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Iguana | 2023.2.1 Canary 5
Android Gradle Plugin 8.3.0-alpha05

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

bl...@google.com <bl...@google.com> #7Sep 29, 2023 10:36PM

Status: Assigned (reopened)

Fix reverted due to b/296372320 - will revise the change and restore the fix.

bl...@google.com <bl...@google.com> Oct 24, 2023 11:47PM