[Material 3] Separate content for collapsed and extended state of LargeTopAppBar [229134133]

Fixed

Feature Request

Status Update

No update yet.

Description

mi...@gmail.com

created issue #1

Apr 14, 2022 06:30PM

For the LargeTopAppBar, please consider providing 2 composable slots (as internally it uses TwoRowsTopAppBar) so that we can use different content for different states.

The most common use case might be showing a backdrop image in the expanded state, while showing only text in the collapsed state.

Comments

ae...@google.com <ae...@google.com> Apr 15, 2022 08:26PM

Assigned to je...@google.com.

bl...@gmail.com <bl...@gmail.com> #2May 18, 2022 10:58AM

The internal systemBarsForVisualComponents right now only uses systemBars, which doesn't include the display cutout: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/internal/SystemBarsDefaultInsets.android.kt;l=24;drc=dcaa116fbfda77e64a319e1668056ce3b032469f

Updating to systemBars.union(displayCutout) should fix this, if that's a change we can make.

co...@google.com <co...@google.com> Mar 27, 2024 08:07PM

Reassigned to sg...@google.com.

sg...@google.com <sg...@google.com> Jan 10, 2025 12:38AM

Accepted by sg...@google.com.

sg...@google.com <sg...@google.com> #3Jan 15, 2025 12:06AM

Marked as fixed.

Thank you for looking into this! It would be crucial to get this right soon as the edge2edge project depends on handling this properly :)

na...@google.com <na...@google.com> #4Jan 29, 2025 06:11PM

Not taking the display cutout into account will impact cars heavily, since some have very large display cutouts:

https://developer.android.com/codelabs/build-a-parked-app#10

ap...@google.com <ap...@google.com> #5Feb 10, 2025 10:14PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Alex Vanyo <vanyo@google.com>
Link: https://android-review.googlesource.com/3422569

Add displayCutout to default Material insets

Expand for full commit details

Add displayCutout to default Material insets 
 
Relnote: "Adds displayCutout to the group of insets that Material 
components take into account by default, to avoid content overlapping 
with the display cutout. 
 
This is a behavior change that will impact how inset-aware 
components behave around a display cutout. This includes the default 
value of the WindowInsets parameter for inset-aware Material 3 
components, and the WindowInsets values provided in the component 
Defaults objects for both Material 2 and Material 3. 
If this change causes undesirable behavior, 
manually specify the WindowInsets parameter on a per-component basis." 
 
Fixes: 362508045 
 
Change-Id: I43ee9ad12db0450ebb9c65ce10d5c39d12628b6c

Files:

M compose/material/material/src/androidMain/kotlin/androidx/compose/material/SystemBarsDefaultInsets.android.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/MaterialComponentsInsetSupportTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/internal/SystemBarsDefaultInsets.android.kt

Hash: 692b440ac97b1831d5b35aafff241a98aeeacb93
Date: Wed Dec 18 19:49:15 2024