imePadding doesn't work inside Dialog [229378542]

Fixed

Bug

Status Update

No update yet.

Description

ph...@gmail.com

created issue #1

Apr 16, 2022 06:29PM

Jetpack Compose version: 1.2.0-alpha07

Below code should align TextField in the center of space left after keyboard appearance(when it's on the screen)

Dialog({}) {
    Box( // fix for https://issuetracker.google.com/issues/221643630
        contentAlignment = Alignment.Center,
        modifier = Modifier.fillMaxSize()
    ) {
        Box(
            contentAlignment = Alignment.Center,
            modifier = Modifier
                .fillMaxWidth()
                .sizeIn(maxWidth = 560.dp)
                .imePadding()
        ) {
            TextField(
                "", {},
                modifier = Modifier
            )
        }
    }
}

On API 32 Emulator sometimes it works fine, and sometimes it doesn't - I wasn't being able to figure out the difference. On API 27 Emulator it never works - imePadding is ignored. Works fine outside of the Dialog

Accompanist version of imePadding works fine on both devices.

Comments

an...@google.com <an...@google.com> Apr 21, 2022 02:43PM

Assigned to mo...@google.com.

mo...@google.com <mo...@google.com> #2Jul 18, 2022 11:55PM

Accepted by mo...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit bbe1d83f1c87167b0da0104a8cc997db7b00f498
Author: Anastasia Soboleva <soboleva@google.com>
Date: Mon Sep 25 09:38:18 2023

Add Uspecified to Hyphens, LineBreak, TextAlign, TextDirection

ParagraphStyle and TextStyle takes these as non-null params in ctors, copy and merge to avoid boxing.

Deprecated getTextAlign and similar public getters nullable for binary compat. Introduced non-null counterparts that compile into primitives.

Before:
5,150 ns 5 allocs Trace Method Trace EMULATOR_AllAppsWithSpans.draw[size=2, spanCount=4]
18,965 ns 99 allocs Trace Method Trace EMULATOR_AllAppsWithSpans.recomposeOnly[size=2, spanCount=4]
44,769 ns 208 allocs Trace Method Trace EMULATOR_AllAppsWithSpans.recomposeMeasureLayout[size=2, spanCount=4]

After:
5,265 ns 5 allocs Trace Method Trace EMULATOR_AllAppsWithSpans.draw[size=2, spanCount=4]
19,054 ns 99 allocs Trace Method Trace EMULATOR_AllAppsWithSpans.recomposeOnly[size=2, spanCount=4]
44,617 ns 201 allocs Trace Method Trace EMULATOR_AllAppsWithSpans.recomposeMeasureLayout[size=2, spanCount=4]

Before:
159,575 ns 647 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.toggleRectangleColor_measure[10]
138,596 ns 580 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.layout[10]
191,924 ns 715 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.first_measure[10]
1,653,166 ns 6220 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.toggleRectangleColor_measure[100]
1,246,603 ns 5490 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.layout[100]
1,529,656 ns 6859 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.first_measure[100]

After:
177,292 ns 597 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.toggleRectangleColor_measure[10]
139,119 ns 550 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.layout[10]
186,741 ns 645 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.first_measure[10]
1,642,789 ns 5500 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.toggleRectangleColor_measure[100]
1,352,991 ns 5231 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.layout[100]
1,570,829 ns 6159 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.first_measure[100]

Test: ui:ui-text:test, ui:ui-text:cC
Test: benchmarks
Bug: 299490814

Relnote: "Introduced a special Unspecified value for TextAlign, TextDirection, Hyphens and LineBreak fields of the ParagraphTextStyle to replace “null”. Because these classes are inline classes, by replacing nullable with the Unspecified, we avoid primitive type boxing.
Constructors, getters and other methods in TextStyle and Paragraph style were update to accept the mentioned parameters as non-null types."

Change-Id: I4197ea85db556846ecad27ca8f561955e2370951

M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Text.kt
M compose/ui/ui-inspection/src/androidTest/java/androidx/compose/ui/inspection/inspector/ParameterFactoryTest.kt
M compose/ui/ui-text/api/current.ignore
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/restricted_current.ignore
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/AndroidParagraphTest.kt
M compose/ui/ui-text/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/AndroidParagraphTextDirectionTest.kt
M compose/ui/ui-text/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/MultiParagraphIntegrationTextDirectionTest.kt
M compose/ui/ui-text/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationTextDirectionTest.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/AndroidParagraph.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraphIntrinsics.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/style/LineBreak.android.kt
M compose/ui/ui-text/src/androidUnitTest/kotlin/androidx/compose/ui/text/ParagraphStyleTest.kt
M compose/ui/ui-text/src/androidUnitTest/kotlin/androidx/compose/ui/text/TextStyleLayoutAttributesTest.kt
M compose/ui/ui-text/src/androidUnitTest/kotlin/androidx/compose/ui/text/TextStyleTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/MultiParagraphIntrinsics.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/ParagraphStyle.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/SpanStyle.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextStyle.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/Hyphens.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/LineBreak.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/TextAlign.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/TextDirection.kt
M compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/platform/SkiaParagraph.skiko.kt
M compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/style/LineBreak.skiko.kt
M tv/tv-material/src/main/java/androidx/tv/material3/Text.kt
M wear/compose/compose-material-core/src/main/java/androidx/wear/compose/materialcore/Text.kt

https://android-review.googlesource.com/2763568

va...@google.com <va...@google.com> #3Jul 19, 2022 12:08AM

Project: platform/frameworks/support
Branch: androidx-main

commit e21f04493c5ee666dc8fc472ff3e085e4ab88945
Author: Anastasia Soboleva <soboleva@google.com>
Date: Mon Oct 09 12:16:50 2023

Replace TextAlign? parameter with TextAlign in tv Text

Since tv's Text is still experimental, we better replace nullable with non-null to avoid primitive type boxing

Bug: 299490814
Test: TextTest
Relnote: "TV Text component's TextAlign parameter is now non-null"

Change-Id: Ib73b136b5d997de3869ca63e7c6dcad5e513ec1e

M tv/tv-material/api/current.txt
M tv/tv-material/api/restricted_current.txt
M tv/tv-material/src/main/java/androidx/tv/material3/Text.kt

https://android-review.googlesource.com/2775146

mo...@google.com <mo...@google.com> #4Jul 20, 2022 09:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.6.0-alpha08
androidx.compose.material:material-android:1.6.0-alpha08
androidx.compose.material:material-desktop:1.6.0-alpha08
androidx.compose.material3:material3:1.2.0-alpha10
androidx.compose.material3:material3-android:1.2.0-alpha10
androidx.compose.material3:material3-desktop:1.2.0-alpha10
androidx.compose.ui:ui-text:1.6.0-alpha08
androidx.compose.ui:ui-text-android:1.6.0-alpha08
androidx.compose.ui:ui-text-desktop:1.6.0-alpha08
androidx.wear.compose:compose-material-core:1.3.0-alpha08

va...@google.com <va...@google.com> #5Jul 20, 2022 09:54PM

I think the soft input mode also needs to be adjustResize due to IME compatability. So in addition to calling WindowCompat.setDecorFitsSystemWindows(window, false) on the Dialog's Window, you also need to call window.setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_ADJUST_RESIZE) on the Dialog's Window.

ap...@google.com <ap...@google.com> #6Aug 13, 2022 01:23AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 6148d601d58a8529e532cfc00602173570d352fc
Author: George Mount <mount@google.com>
Date: Wed Jul 20 11:45:05 2022

Support WindowInsets in Dialogs

Fixes: 229378542

Dialogs were not supporting WindowInsets.

Relnote: "Added DialogProperties.decorFitsSystemWindows property
to allow Dialogs to support WindowInsets."

Test: new test, manual tests
Change-Id: I577429919e87610107d6fd476538d8904866b5ce

A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/ActivityWithInsets.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidDialog.android.kt
M compose/ui/ui/src/androidAndroidTest/AndroidManifest.xml
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/DialogWithInsetsTest.kt
M compose/ui/ui/src/androidMain/res/values/styles.xml
M compose/ui/ui/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2161544

rh...@gmail.com <rh...@gmail.com> #7Sep 23, 2022 01:40PM

The fix via the `DialogProperties.decorFitsSystemWindows property` adds an odd margin to the top of the dialog that cannot be removed:

https://issuetracker.google.com/issues/248529694

ha...@ziprecruiter.com <ha...@ziprecruiter.com> #8Apr 19, 2023 06:06PM

replying to previous comment of
"I need to add the ability for a Dialog to setDecorFitsSystemWindows(false)"
can this be added for the popup composable as well please?

I'd like to get the ime height using it and don't want to set that to false on my fragment as it'll cause so many other issues and adjustments i'd need to make
if you have any advice there for me i'd take it

mo...@google.com <mo...@google.com> #9Apr 20, 2023 06:21PM

WindowInsetsCompat can give you the IME height if you aren't in compose. WindowInsets.ime can give you the IME height if you're using compose. I don't normally recommend accessing the IME's size during composition because the IME size changes after composition, but before layout, so if the IME changes size, it will only be available in composition on the following frame.