imePadding doesn't work inside Dialog [229378542]

Fixed

Bug

Status Update

No update yet.

Description

ph...@gmail.com

created issue #1

Apr 16, 2022 06:29PM

Jetpack Compose version: 1.2.0-alpha07

Below code should align TextField in the center of space left after keyboard appearance(when it's on the screen)

Dialog({}) {
    Box( // fix for https://issuetracker.google.com/issues/221643630
        contentAlignment = Alignment.Center,
        modifier = Modifier.fillMaxSize()
    ) {
        Box(
            contentAlignment = Alignment.Center,
            modifier = Modifier
                .fillMaxWidth()
                .sizeIn(maxWidth = 560.dp)
                .imePadding()
        ) {
            TextField(
                "", {},
                modifier = Modifier
            )
        }
    }
}

On API 32 Emulator sometimes it works fine, and sometimes it doesn't - I wasn't being able to figure out the difference. On API 27 Emulator it never works - imePadding is ignored. Works fine outside of the Dialog

Accompanist version of imePadding works fine on both devices.

Comments

an...@google.com <an...@google.com> Apr 21, 2022 02:43PM

Assigned to mo...@google.com.

mo...@google.com <mo...@google.com> #2Jul 18, 2022 11:55PM

Accepted by mo...@google.com.

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

va...@google.com <va...@google.com> #3Jul 19, 2022 12:08AM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

mo...@google.com <mo...@google.com> #4Jul 20, 2022 09:11PM

deleted

va...@google.com <va...@google.com> #5Jul 20, 2022 09:54PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ap...@google.com <ap...@google.com> #6Aug 13, 2022 01:23AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 6148d601d58a8529e532cfc00602173570d352fc
Author: George Mount <mount@google.com>
Date: Wed Jul 20 11:45:05 2022

Support WindowInsets in Dialogs

Fixes: 229378542

Dialogs were not supporting WindowInsets.

Relnote: "Added DialogProperties.decorFitsSystemWindows property
to allow Dialogs to support WindowInsets."

Test: new test, manual tests
Change-Id: I577429919e87610107d6fd476538d8904866b5ce

A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/ActivityWithInsets.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidDialog.android.kt
M compose/ui/ui/src/androidAndroidTest/AndroidManifest.xml
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/DialogWithInsetsTest.kt
M compose/ui/ui/src/androidMain/res/values/styles.xml
M compose/ui/ui/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2161544

rh...@gmail.com <rh...@gmail.com> #7Sep 23, 2022 01:40PM

The fix via the `DialogProperties.decorFitsSystemWindows property` adds an odd margin to the top of the dialog that cannot be removed:

https://issuetracker.google.com/issues/248529694

ha...@ziprecruiter.com <ha...@ziprecruiter.com> #8Apr 19, 2023 06:06PM

replying to previous comment of
"I need to add the ability for a Dialog to setDecorFitsSystemWindows(false)"
can this be added for the popup composable as well please?

I'd like to get the ime height using it and don't want to set that to false on my fragment as it'll cause so many other issues and adjustments i'd need to make
if you have any advice there for me i'd take it

mo...@google.com <mo...@google.com> #9Apr 20, 2023 06:21PM

WindowInsetsCompat can give you the IME height if you aren't in compose. WindowInsets.ime can give you the IME height if you're using compose. I don't normally recommend accessing the IME's size during composition because the IME size changes after composition, but before layout, so if the IME changes size, it will only be available in composition on the following frame.