imePadding doesn't work inside Dialog [229378542]

Fixed

Bug

Status Update

No update yet.

Description

ph...@gmail.com

created issue #1

Apr 16, 2022 06:29PM

Jetpack Compose version: 1.2.0-alpha07

Below code should align TextField in the center of space left after keyboard appearance(when it's on the screen)

Dialog({}) {
    Box( // fix for https://issuetracker.google.com/issues/221643630
        contentAlignment = Alignment.Center,
        modifier = Modifier.fillMaxSize()
    ) {
        Box(
            contentAlignment = Alignment.Center,
            modifier = Modifier
                .fillMaxWidth()
                .sizeIn(maxWidth = 560.dp)
                .imePadding()
        ) {
            TextField(
                "", {},
                modifier = Modifier
            )
        }
    }
}

On API 32 Emulator sometimes it works fine, and sometimes it doesn't - I wasn't being able to figure out the difference. On API 27 Emulator it never works - imePadding is ignored. Works fine outside of the Dialog

Accompanist version of imePadding works fine on both devices.

Comments

an...@google.com <an...@google.com> Apr 21, 2022 02:43PM

Assigned to mo...@google.com.

mo...@google.com <mo...@google.com> #2Jul 18, 2022 11:55PM

Accepted by mo...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

va...@google.com <va...@google.com> #3Jul 19, 2022 12:08AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

mo...@google.com <mo...@google.com> #4Jul 20, 2022 09:11PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

va...@google.com <va...@google.com> #5Jul 20, 2022 09:54PM

I think the soft input mode also needs to be adjustResize due to IME compatability. So in addition to calling WindowCompat.setDecorFitsSystemWindows(window, false) on the Dialog's Window, you also need to call window.setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_ADJUST_RESIZE) on the Dialog's Window.

ap...@google.com <ap...@google.com> #6Aug 13, 2022 01:23AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 6148d601d58a8529e532cfc00602173570d352fc
Author: George Mount <mount@google.com>
Date: Wed Jul 20 11:45:05 2022

Support WindowInsets in Dialogs

Fixes: 229378542

Dialogs were not supporting WindowInsets.

Relnote: "Added DialogProperties.decorFitsSystemWindows property
to allow Dialogs to support WindowInsets."

Test: new test, manual tests
Change-Id: I577429919e87610107d6fd476538d8904866b5ce

A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/ActivityWithInsets.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidDialog.android.kt
M compose/ui/ui/src/androidAndroidTest/AndroidManifest.xml
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/DialogWithInsetsTest.kt
M compose/ui/ui/src/androidMain/res/values/styles.xml
M compose/ui/ui/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2161544

rh...@gmail.com <rh...@gmail.com> #7Sep 23, 2022 01:40PM

The fix via the `DialogProperties.decorFitsSystemWindows property` adds an odd margin to the top of the dialog that cannot be removed:

https://issuetracker.google.com/issues/248529694

ha...@ziprecruiter.com <ha...@ziprecruiter.com> #8Apr 19, 2023 06:06PM

replying to previous comment of
"I need to add the ability for a Dialog to setDecorFitsSystemWindows(false)"
can this be added for the popup composable as well please?

I'd like to get the ime height using it and don't want to set that to false on my fragment as it'll cause so many other issues and adjustments i'd need to make
if you have any advice there for me i'd take it

mo...@google.com <mo...@google.com> #9Apr 20, 2023 06:21PM

WindowInsetsCompat can give you the IME height if you aren't in compose. WindowInsets.ime can give you the IME height if you're using compose. I don't normally recommend accessing the IME's size during composition because the IME size changes after composition, but before layout, so if the IME changes size, it will only be available in composition on the following frame.