IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date:   Wed Sep 18 16:55:49 2019

    Change the way to detect mismatch between POJO and query
   
    This fixes cursor mismatch warnings with expandProjection.
   
    Bug: 140759491
    Test: QueryMethodProcessorTest
    Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M       room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

  The following changes were cherrypicked through Coastguard (https://android-build.googleplex.com/coastguard/)
  Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
  Created: 2019-10-14 17:23:42.610596+00:00
  Changes: aosp/1123258
 

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date:   Thu Apr 16 16:47:05 2020

    Re-factor how errors are dismissed when query is re-written
   
    This CL changes how we handle errors/warnings if query is
    re-written.
    There was a bug in expandProjection where we would report warnings
    for things that Room already fixes automatically (b/140759491).
    The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
    solved it by deferring validating of columns until after re-write
    decision is made. Unfortunately, this required changing PojoRowAdapter
    to have a dummy mapping until it is validating, make it hard to use
    as it does have a non-null mapping which is not useful.
   
    This CL partially reverts that change and instead rely on the log
    deferring logic we have in Context. This way, we don't need to break
    the stability of PojoRowAdapter while still having the ability to
    drop warnings that room fixes. This will also play nicer when we
    have different query re-writing options that can use more information
    about the query results.
   
    Bug: 153387066
    Bug: 140759491
    Test: existing tests pass
    Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M       room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

Thanks for quick debug!

Project: platform/frameworks/support
Branch: androidx-main

commit 9cedb659c54d88390e88ff3677446dea1624110d
Author: Sean McQuillan <seanmcq@google.com>
Date:   Thu Apr 28 16:47:12 2022

    Ensure that text layout changes invalidate draw
   
    Previous behavior: Text layout changes could display a stale render if
    text layout is modified after the first draw without resizing either the
    Text or TextField.
   
    New behavior: Text layout changes will always restart draw.
   
    This was especially visible when layout changes were triggered by
    downloadable fonts. In a situation where size did not change during font
    load, the text would not redraw until the next event that invalidated
    the draw.
   
    Bug: b/229727404
    Test: # manual & demo
    Test: ./gradlew :compose:found:found:cAT :compose:found:found:test
    Relnote: "Downloadable font resolution that does not change the layout
    size of Text or TextField previously would not redraw, leading to stale
    font display. This bugfix ensures that text layout always triggers
    redraw (b/229727404)."
   
    Change-Id: I1d49e9b977c234c9bc0317def7918d7821b321eb

M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/FontFamilyDemo.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
A       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextStateTest.kt
A       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/TextControllerTest.kt
A       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextFieldStateTest.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt

https://android-review.googlesource.com/2080780

Project: platform/frameworks/support
Branch: androidx-main

commit ec61b87882c98346c9dfcb5ff714546a66363b22
Author: Sean McQuillan <seanmcq@google.com>
Date:   Thu Jun 02 18:35:57 2022

    Revert "Revert "Ensure that text layout changes invalidate draw""
   
    This reverts commit a80e6400dd5e0aab4ab6a1936c9d96223c68c86f.
   
    Reason for revert: Applying fine grained state reads for Text
   
    Instead of making layoutResult state, limit restarts to just drawScope
   
    Test: ./gradlew :compose:foundation:foundation:cAT
    Test: integration demo
    Bug: b/229727404
    Bug: b/231492643
   
    Change-Id: Ia78b31307e9b7bc05685cee17470f5bb9cae0341

M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/FontFamilyDemo.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
A       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextStateTest.kt
A       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/TextControllerTest.kt
A       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextFieldStateTest.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt

https://android-review.googlesource.com/2115537