bundletool does not package baseline profiles correctly [230361284]

Verified

Bug

Status Update

No update yet.

Description

ra...@google.com

created issue #1

Apr 25, 2022 06:33PM

go/baseline-profiles for context.

Currently when building app bundles, baseline profiles are not being packaged into assets/dexopt/baseline.prof.

This causes the profiles to get dropped and the app is no longer optimized.

Comments

je...@google.com <je...@google.com> Apr 25, 2022 07:37PM

Assigned to al...@google.com.

ra...@google.com <ra...@google.com> #2Apr 27, 2022 05:12PM

[Comment deleted]

ra...@google.com <ra...@google.com> #3Apr 27, 2022 05:17PM

[Comment deleted]

je...@google.com <je...@google.com> #4Apr 27, 2022 06:21PM

Also of note is the adb error when trying to install bad APK: INSTALL_FAILED_DEXOPT

wk...@google.com <wk...@google.com> #5Apr 28, 2022 09:30AM

load dex files over 5Gb. -> load dex files over 5Mb.

al...@google.com <al...@google.com> Apr 29, 2022 02:06PM

Accepted by al...@google.com.

al...@google.com <al...@google.com> #6Apr 29, 2022 03:17PM

Same here! Looking forward to a solution :)

Android Studio version: 0.8.12
buildToolsVersion 21.0.1
Gradle 1.11

Message last modified on Apr 29, 2022 03:42PM

al...@google.com <al...@google.com> #7Apr 29, 2022 03:42PM

There is already an option in dx allowing to force generation of smaller dex files:
--set-max-idx-number=<value>
Unfortunately changing the default is not a solution since the linearAlloc limit can be reached at very different levels depending on the classes hierarchy and other criteria.

In addition for most applications, moving to multidex will only help to workaround the linearalloc limit for the installation. But the application will still crash against the same limit at execution. The only working use case where I know multidex can help with linearalloc is when the apk does not contains one application but distinct pieces running in separate process.

ca...@google.com <ca...@google.com> #8Apr 29, 2022 06:47PM

Thanks for your quick response.

It's nice to know about that command line option. I do not see it in the output of 'dx --help', might be good to add that.

I'm not very familiar with the 'linearAlloc limit' issue outside of the context of the dexopt step. My sample app is able to run once the lower idx value is set, although I do not actually call into any of the library code that is bundled with the app. I assume it's undefined when/if the 'linearAlloc limit' will be hit in a large application on gb.

I'm a bit confused as to the platform compatibility of multidex given the 'linearAlloc limit' bug. What specific versions of Android are supported? The multidex code implies back to v4 (

https://android.googlesource.com/platform/frameworks/multidex/+/master/library/src/android/support/multidex/MultiDex.java) but it would seem that ICS is the earliest supported platform. Is this correct?

Message last modified on Apr 29, 2022 06:48PM

al...@google.com <al...@google.com> Apr 29, 2022 08:41PM

Marked as fixed.

ra...@google.com <ra...@google.com> #9May 2, 2022 03:49PM

The option is not documented in --help because it was designed for testing and we're not capable of documenting a reliable way to use it as a workaround of the linearalloc limit.

The linearalloc limit is reached when loading classes. At install time dexopt is loading all classes contained in the dex so it's facing the limit immediately. At execution the limit may be reached after some delay dependending of the usage you have of the packaged classes. If you face it at install time but not at execution, this means you never trigger the loading of some classes. In a real application those never loaded classes should have been shrinked away manually or by Proguard. The exception is when there are different groups of classes in the dex files used in separate process.

About multidex library supported versions I've merged recently a change to try to be clearer

https://android-review.googlesource.com/#/c/108023/
The summary is that the library should work down to API 4 (Donut), but below ICS applications will probably be hit by the linearalloc limit

al...@google.com <al...@google.com> #10May 4, 2022 06:44PM

for Android studio use:
dexOptions {
additionalParameters = ['--multi-dex', '--set-max-idx-number=40000']
}

wk...@google.com <wk...@google.com> #11May 5, 2022 11:46AM

I still have this issue and it's driving me nuts

je...@google.com <je...@google.com> #12May 5, 2022 02:32PM

smgshantokhan55698@gmail.com

Message last modified on May 5, 2022 02:32PM

ke...@gmail.com <ke...@gmail.com> #13May 30, 2022 06:07AM

https://twitter.com/Shanto59597264?t=AcggXWk2PPhi4bU9UC3YHA&s=09 @shantokhan59597264

je...@google.com <je...@google.com> #14May 31, 2022 03:06PM

Marked as fixed.

it will only show up in beta02 for 7.3

ly...@gmail.com <ly...@gmail.com> #15Jun 2, 2022 12:06PM

Is there release date of bundletool 1.11 with support for copying profiles into generated apk from bundles as follows from the comment #5?

vi...@spotify.com <vi...@spotify.com> #16Jun 3, 2022 06:56AM

Is there any plan to have a backport support in 7.2.1?

al...@google.com <al...@google.com> #17Jun 7, 2022 08:42PM

Fix is merged into 7.2 branch and will be available in Chipmunk/AGP 7.2 Patch 2 Release

li...@pinterest.com <li...@pinterest.com> #18Jun 7, 2022 09:16PM

Any chance to backport it to 7.1.0 as well?

de...@google.com <de...@google.com> #19Jun 10, 2022 09:33PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Dolphin Beta 2 (2021.3.1.11)
Android Gradle Plugin 7.3.0-beta02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

je...@gmail.com <je...@gmail.com> #20Jun 16, 2022 01:10AM

Hi guys new here.. need your help to fix things right. Not for me I give you my word.. I had already refunded 2 times.. please don’t let your good system get exploited by malicious user that prey on end user. Really hope good pro skill guys like you all can keep a good image and uphold what’s right! Thanks again

je...@gmail.com <je...@gmail.com> #21Jun 16, 2022 01:50AM

Even now I just notices the report I wrote to raise here but not under my name!? So many other user!!! Please help!

sh...@pinterest.com <sh...@pinterest.com> #22Jul 19, 2022 06:55PM

Do you have an ETA of when Chipmunk/AGP 7.2 Patch 2 would be released? Thank you.

jb...@twitter.com <jb...@twitter.com> #23Jul 29, 2022 07:58PM

Hi there - just for clarification: the release notes here say this fix was merged for 7.2.1, back in May (patch 1): https://developer.android.com/studio/releases/gradle-plugin#7-2-0

However the discussion here in June indicates this will be part of 7.2.2 (which is unreleased afaik). Can anyone clear up this discrepancy?

jb...@twitter.com <jb...@twitter.com> #24Aug 4, 2022 10:58PM

FYI for those following - it looks like AGP 7.2.2 was released yesterday so we should be unblocked to use baseline profiles with app bundles (I haven't yet verified personally).

ju...@arkea.com <ju...@arkea.com> #25Nov 29, 2022 09:16AM

Hi everyone,

I have similar issue and just try it out the AGP 7.3.1.
The bad location of profile still remain in this release (com.android.tools.build.profiles instead of assets.dexopt)

Any update about this ?

Thanks

be...@google.com <be...@google.com> #26Nov 29, 2022 09:47AM

Verified by be...@google.com.

Using the macrobenchmark sample and bundletool 1.13.1 i was able to verify the fix.

Build release bundle
Extract apks
Extract universal apk
Inspect apk in Android Studio

The Baseline Profile can be found under assets/dexopt/baseline.prof{m} when inspecting an apk, even though it is under com.android.tools.build.profiles when inspecting an aab.

Message last modified on Nov 29, 2022 10:13AM

se...@gmail.com <se...@gmail.com> #27Jan 3, 2023 10:29AM

I am seeing size difference in the baseline.prof file between legacy apks and apks created from app bundle. In the legacy apk, the size of baseline.prof is 31.6 KB whereas in the apk created from app bundles, it is 21.6 KB. Is this expected?

je...@google.com <je...@google.com> #28Jan 3, 2023 06:01PM

#27, please file a new bug, bonus if you include a repro case.

lg...@gmail.com <lg...@gmail.com> #29
Restricted+
Jun 11, 2023 01:17AM

Comment has been deleted.