Text with emoji cannot support BackgroundColorSpan [230525134]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Apr 27, 2022 09:54AM

Component used: Emoji2
Version used:
Devices/Android versions reproduced on:

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).

SpannableString name = new SpannableString("Test 🫃🫃🫄 emoji");
name.setSpan(new BackgroundColorSpan(Color.RED), 0, name.length(), Spannable.SPAN_EXCLUSIVE_EXCLUSIVE);

Textview tv = findViewbyId(R.id.text)
tv.setText(name);

Wed Apr 27 2022 17:54:03 GMT+0800 (China Standard Time).png

9.4 KB

View

Download

Comments

[Deleted User] <[Deleted User]> #2Apr 27, 2022 09:57AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

Wed Apr 27 2022 17:59:06 GMT+0800 (China Standard Time).png

18 KB

View

Download

so...@google.com <so...@google.com> #3May 3, 2022 11:15AM

Reassigned to no...@google.com.

Nona, could you please help triaging this one? Thanks!

se...@google.com <se...@google.com> #4May 3, 2022 03:48PM

Reassigned to se...@google.com.

Grabbing this.

se...@google.com <se...@google.com> #5Jul 14, 2022 11:20PM

Accepted by se...@google.com.

Thanks for the report!

I will fix the background issue on this bug.

Looking at the clickable link, it appears correct in my quick repro. Please file a separate bug for that with repro screenshot and code listing, thanks!

se...@google.com <se...@google.com> #6Jul 14, 2022 11:21PM

Assigned to bu...@google.com.

Bugjuggler: https://android-review.googlesource.com/c/platform/frameworks/support/+/2153805

se...@google.com <se...@google.com> #7Jul 15, 2022 04:05PM

Reassigned to se...@google.com.

Bugjuggler: https://android-review.googlesource.com/c/platform/frameworks/support/+/2153805

se...@google.com <se...@google.com> #8Jul 15, 2022 04:06PM

Reassigned to se...@google.com.

Bugjuggler: aosp/2153805

bu...@google.com <bu...@google.com> #9Jul 15, 2022 04:07PM

Hi. I've received your bug and will wait until

https://android-review.googlesource.com/2153805 is closed and then unCc myself.

se...@google.com <se...@google.com> #10Jul 15, 2022 04:07PM

Reassigned to bu...@google.com.

Bugjuggler: aosp/2153805

bu...@google.com <bu...@google.com> #11Jul 15, 2022 04:07PM

Accepted by bu...@google.com.

Hi. I've received your bug and will wait until

https://android-review.googlesource.com/2153805 is closed and then assign the bug to seanmcq@google.com and unCc myself.

ap...@google.com <ap...@google.com> #12Jul 15, 2022 10:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit 15ef5cb171dd7b91555fda17a41a12029b60f320
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Jul 14 16:11:33 2022

Draw background in EmojiSpan

TextLine draws ReplacementSpans prior to configuring BackgroundSpans,
in a separate for loop. As a result, replacement spans don't honor surrounding
backgrounds.

Change EmojiSpan to apply background itself, as if TextLayout had correctly
rastered behind the replacement span or updated the TextPaint with bgColor.

Test: ./gradlew :e2:e2:cAT
Bug:

b/230525134

Relnote: "Emoji2 will now correctly draw backgrounds from BackgroundSpan."
Change-Id: Ide6a8542179a2676cefc16dcf3f3d43e6f376de6

M emoji2/emoji2/src/androidTest/java/androidx/emoji2/text/EmojiSpanTest.java
M samples/SupportEmojiDemos/src/main/java/com/example/android/support/text/emoji/MainFragment.java
M emoji2/emoji2/src/main/java/androidx/emoji2/text/TypefaceEmojiSpan.java
M samples/SupportEmojiDemos/src/main/java/com/example/android/support/text/emoji/ConfigLayout.java

https://android-review.googlesource.com/2153805

bu...@google.com <bu...@google.com> #13Jul 15, 2022 10:29PM

Assigned to se...@google.com.

Back to you.

se...@google.com <se...@google.com> Jul 15, 2022 10:36PM

Marked as fixed.

na...@google.com <na...@google.com> #14Jan 11, 2023 08:12PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.emoji2:emoji2:1.3.0-alpha01

Issue 230525134

Description

Issue summary

Comments

[Deleted User] <[Deleted User]> #2Apr 27, 2022 09:57AM

so...@google.com <so...@google.com> #3May 3, 2022 11:15AM

se...@google.com <se...@google.com> #4May 3, 2022 03:48PM

se...@google.com <se...@google.com> #5Jul 14, 2022 11:20PM

se...@google.com <se...@google.com> #6Jul 14, 2022 11:21PM

se...@google.com <se...@google.com> #7Jul 15, 2022 04:05PM

se...@google.com <se...@google.com> #8Jul 15, 2022 04:06PM

bu...@google.com <bu...@google.com> #9Jul 15, 2022 04:07PM

se...@google.com <se...@google.com> #10Jul 15, 2022 04:07PM

bu...@google.com <bu...@google.com> #11Jul 15, 2022 04:07PM

ap...@google.com <ap...@google.com> #12Jul 15, 2022 10:29PM

bu...@google.com <bu...@google.com> #13Jul 15, 2022 10:29PM

se...@google.com <se...@google.com> Jul 15, 2022 10:36PM

na...@google.com <na...@google.com> #14Jan 11, 2023 08:12PM

Add comment

Issue metadata