QualitySelector fails to use UHD when a fallback strategy is enabled [230651237]

Fixed

Bug

Status Update

No update yet.

Description

da...@gmail.com

created issue #1

Apr 27, 2022 09:12PM

When we create a QualitySelector with the following code, it doesn't use UHD even when UHD is supported:

QualitySelector.fromOrderedList(Quality.UHD, FallbackStrategy.lowerQualityOrHigherThan(Quality.UHD)

We had to implement a workaround for this in our app:

https://github.com/GrapheneOS/Camera

// work around CameraX QualitySelector bug
private fun Quality.withFallbackIfUnsupported(): QualitySelector {
    return if (QualitySelector.isQualitySupported(camera!!.cameraInfo, this)) {
        QualitySelector.from(this)
    } else {
        QualitySelector.from(this, FallbackStrategy.higherQualityOrLowerThan(this))
    }
}

This works but led to a regression (a crash) because camera is null when the app is being opened immediately to video mode via the standard Android video capture intent. We'll try some other approaches to using QualitySector but it doesn't seem that FallbackStrategy works correctly at the moment.

Our app is open source if for some reason you can't reproduce this yourselves.

https://github.com/GrapheneOS/Camera

Comments

da...@gmail.com <da...@gmail.com> #2Apr 27, 2022 10:33PM

Running into a similar issue, any update on this?

da...@gmail.com <da...@gmail.com> #3Apr 27, 2022 10:39PM

This is a platform behavior change.

b/236862874 is related.

da...@gmail.com <da...@gmail.com> #4Apr 27, 2022 11:40PM

Reassigning to current owner per go/androidx/owners.

wu...@google.com <wu...@google.com> #5Apr 28, 2022 06:44AM

Reassigned to da...@gmail.com.

Re-triaging by request.

da...@gmail.com <da...@gmail.com> #6Apr 28, 2022 06:47AM

Any progress?

wu...@google.com <wu...@google.com> #7Apr 28, 2022 06:51AM

Reassigned to ca...@google.com.

deleted

le...@google.com <le...@google.com> #8Apr 28, 2022 11:25AM

Thanks for the comment#1 report. The bug in how those older versions of the framework dispatch insets does make handling insets difficult. It's on our roadmap for early 2025 to prepare an AndroidX-side workaround.

da...@gmail.com <da...@gmail.com> #9Apr 28, 2022 11:01PM

Any possible workaround for us before that ? We're currently migrating our app to be edge-to-edge as per Android 15 migration and this would force us to make API 30-specific cases everywhere

da...@gmail.com <da...@gmail.com> #10Apr 28, 2022 11:08PM

This issue is also stopping us from being able to support edge-to-edge in Android 15. Given it's a enforced requirement for targeting Android 15, couldn't this be prioritised higher? Companies like us have hundreds of screens to fix so waiting until 2025 for a workaround is going to be tough work.

le...@google.com <le...@google.com> #11Apr 29, 2022 07:58AM

Reassigned to le...@google.com.

Maybe you can create a static method, com.your.company.ViewGroupCompat#installCompatInsetsDispatch, like this: https://android-review.googlesource.com/c/platform/frameworks/support/+/3310617/2/core/core/src/main/java/androidx/core/view/ViewGroupCompat.java ?

After creating the method, you need to call ViewGroupCompat.installCompatInsetsDispatch(getWindow().getDecorView()) in onCreate() of your activity to make the behavior compatible with API 30+.

When the new library with the API is released, you can replace com.your.company.ViewGroupCompat with androidx.core.view.ViewGroupCompat.

le...@google.com <le...@google.com> May 3, 2022 05:56AM

Accepted by le...@google.com.

le...@google.com <le...@google.com> #12May 3, 2022 12:04PM

Wow quick response, thanks! I just tried applying that workaround to our root view and can confirm it fixes the issue. (Also FYI there's a typo in the PR; "comsumed")

ap...@google.com <ap...@google.com> #13May 5, 2022 01:02PM

I'm getting a crash when using new version of ktx-core 1.16.0-alpha01 with fixed ViewCompat and ViewGroupCompat on API < 30. This is related to FragmentContainerView:

java.lang.NullPointerException: Parameter specified as non-null is null: method androidx.fragment.app.FragmentContainerView.setOnApplyWindowInsetsListener, parameter listener
	at androidx.fragment.app.FragmentContainerView.setOnApplyWindowInsetsListener(Unknown Source:2)
	at androidx.core.view.ViewGroupCompat.dispatchApplyWindowInsets(ViewGroupCompat.java:255)
	at androidx.core.view.ViewGroupCompat.dispatchApplyWindowInsets(ViewGroupCompat.java:264)
	at androidx.core.view.ViewGroupCompat.dispatchApplyWindowInsets(ViewGroupCompat.java:264)
	at androidx.core.view.ViewGroupCompat.dispatchApplyWindowInsets(ViewGroupCompat.java:264)
	at androidx.core.view.ViewGroupCompat.dispatchApplyWindowInsets(ViewGroupCompat.java:264)
	at androidx.core.view.ViewGroupCompat.dispatchApplyWindowInsets(ViewGroupCompat.java:264)
	at androidx.core.view.ViewGroupCompat.dispatchApplyWindowInsets(ViewGroupCompat.java:264)
	at androidx.core.view.ViewGroupCompat.lambda$installCompatInsetsDispatch$0(ViewGroupCompat.java:218)
	at androidx.core.view.ViewGroupCompat$$ExternalSyntheticLambda1.onApplyWindowInsets(D8$$SyntheticClass:0)
	at android.view.View.dispatchApplyWindowInsets(View.java:10499)
	at android.view.ViewGroup.dispatchApplyWindowInsets(ViewGroup.java:7191)
	at android.view.ViewRootImpl.dispatchApplyInsets(ViewRootImpl.java:1925)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2030)
	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1721)
	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7598)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:966)
	at android.view.Choreographer.doCallbacks(Choreographer.java:790)
	at android.view.Choreographer.doFrame(Choreographer.java:725)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:951)
	at android.os.Handler.handleCallback(Handler.java:883)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7356)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

le...@google.com <le...@google.com> #14May 10, 2022 03:28AM

Marked as fixed.

Re comment#13:

I think the @NonNull annotation of androidx.fragment.app.FragmentContainerView.setOnApplyWindowInsetsListener has been removed since If694a3b70bf84f03c95d67d20e58485135ab7d86 which has been included since androidx.fragment 1.4.0-alpha09.

Do you mind upgrading your androidx.fragment version to 1.4.0-alpha09 or above? The latest version is 1.8.5.