IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit cb1afd67dacbf14cd22206c6f5b543dbf18cec1f
Author: Tony Mak <tonymak@google.com>
Date:   Thu Jan 06 14:52:58 2022

    Deprecate all the APIs in textclassifier
   
    Bug: 210509084
   
    Test: Check api/current.txt and ensure all classes are deprecated
   
    Relnote: "Deprecate all the APIs in the textclassifier module"
   
    Change-Id: Idc18063196531c0e926162fefeadf2dc5f559da1

M       textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextSelection.java
M       textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinks.java
M       textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationSessionId.java
M       textclassifier/textclassifier/api/public_plus_experimental_current.txt
M       textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassification.java
M       textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationManager.java
M       textclassifier/textclassifier/api/current.txt
M       textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationContext.java
M       textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinksParams.java
M       textclassifier/textclassifier/api/restricted_current.txt
M       textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationAction.java
M       textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassifier.java
M       textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationActions.java
M       textclassifier/textclassifier/src/main/java/androidx/textclassifier/ExtrasUtils.java

https://android-review.googlesource.com/1938773

Project: platform/frameworks/support
Branch: androidx-main

commit 19ed7e69823a09f3c63f8c8cdf339af8ca1645ab
Author: Alan Viverette <alanv@google.com>
Date:   Mon Mar 14 15:18:16 2022

    Bump textclassifier for final release and turn-down
   
    Bug: 210509084
    Change-Id: Ib8b2386903bb49baa3211f7de7fe1587fdda1483
    Test: ./gradlew checkApi

M       libraryversions.toml

https://android-review.googlesource.com/2024823

Hi. I've received your bug and will wait until 2022-03-23 00:00 -0400 EDT and then assign the bug to alanv@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 787a2f8056da406e0631a6c27b3ea67252e05f46
Author: Zach Klippenstein <klippenstein@google.com>
Date:   Thu Jun 23 15:15:48 2022

    Update ScrollState's maxValue in measure, not place.
   
    The old behavior, setting maxValue in the placement pass, prevented
    Modifier.scrollable from dispatching scroll events in onRemeasured,
    which is called after the measurement pass but before placement.
   
    Test: ./gradlew :compose:f:f:cDAT
    Bug: b/230756508
    Change-Id: I68ad542100438c8a6b4430827f28c2ccbfa6a037

M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Scroll.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollTest.kt

https://android-review.googlesource.com/2137003

Project: platform/frameworks/support
Branch: androidx-main

commit cb90e2addc50ff6f4e7f48df0dc0a03343898ccb
Author: Zach Klippenstein <klippenstein@google.com>
Date:   Wed Jun 15 12:13:03 2022

    Fix scrollable focused child tracking.
   
    When calculating whether we need to scroll to keep the focused child
    in-view after the scrollable viewport is resized, we were using the
    bounds of the focused child to figure out if it was previously visible.
    That was incorrect, because if the viewport is animating while the
    scroll animation is running, it's possible for the viewport to shrink
    fast enough that the focused child isn't actually visible, but would
    have eventually became visible after the animation, so we need to
    continue to animate.
   
    This approach is documented as Option 0 in the design doc:
    https://docs.google.com/document/d/16yYJOIcde0Pm7vB--ExSdrY7lrZQ2rqHIn6nYWb7ccg/edit#heading=h.ytkawqefedyn
   
    Note that while this fixes b/230756508 and will cause the animations to
    end up in the correct final state, it makes b/220119990 more visible,
    since it looks like the scroll animation doesn't start at all until the
    viewport animation stops.
   
    Fixes: b/230756508
    Test: Manually using the 'Foundation > Scrollable with focused child"
        and "Text > Input fields > Inside scrollable" demos."
    Test: ./gradlew :compose:f:f:cDAT
    Relnote: "When a scrollable has a focused child, it will now correctly
        scroll to keep the focused child in view when its size is decreased,
        even when the size is animated."
    Change-Id: I8086717b14174e566b299f2643f1dd6c0b250773

M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableFocusableInteractionTest.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/ScrollableFocusedChildDemo.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt

https://android-review.googlesource.com/2127984

Project: platform/frameworks/support
Branch: androidx-main

commit 7e77bb541331ce0d62cabad732e43eca41ac978a
Author: Zach Klippenstein <klippenstein@google.com>
Date:   Wed Jul 06 11:42:21 2022

    Move BringIntoView queueing into the scrollable implementation.
   
    This change removes the over-complicated coroutine-based queuing of
    bringIntoView requests in the BringIntoViewResponder, which now is only
    responsible for dispatching the request to the actual responder
    interface and propagating it up the modifier local chain.
   
    This gives the actual responder implementation (i.e. in
    Modifier.scrollable) all the information about conflicting
    requests and manage the queue of ongoing requests with an actual,
    explicit queue that is much more straightforward than the previous
    coroutine job chaining mess. Each request is stored in an actual list
    along with the continuation from the request, and requests are
    explicitly resumed or cancelled when needed. This also makes debugging
    easier, because there's an actual queue data structure we can inspect,
    which contains all the actual information about each request.
   
    It also completely changes how the scroll animation is performed.
    On every frame, the scroll target is recomputed to account for
    changes in the viewport size, the request size, or the set of active
    requests since the last frame, while still keeping the animation
    smooth. The animation logic is in its own class, which allows a single
    suspend animation call to animate to a target value that can be updated
    while the animation is running.
   
    While this change is a valuable cleanup on its own, it also fixes
    b/241591211, and paves the way for replacing scrollable's implicit
    focused child tracking with an explicit API for keeping a thing in view.
   
    Fixes: b/241591211
    Bug: b/192043120
    Bug: b/237190748
    Bug: b/230756508
    Bug: b/239451114
    Test: ScrollableFocusableInteractionTest
    Test: androidx.compose.foundation.relocation.*
    Test: RebasableAnimationStateTest
    Test: BringIntoViewRequestPriorityQueueTest
    Relnote: "Rewrote the way scrollables respond to
        `bringIntoViewRequesters` and focusables to better model the
        complexity of those operations and handle more edge cases."
    Change-Id: I2e5fec8c8582a8fe1f191e37fd0f4f9165678664

M       compose/foundation/foundation/api/current.txt
M       compose/foundation/foundation/api/public_plus_experimental_current.txt
M       compose/foundation/foundation/api/restricted_current.txt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/ScrollableFocusedChildDemo.kt
A       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/relocation/BringIntoViewResponderDemo.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/relocation/BringRectangleIntoViewDemo.kt
M       compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/BringIntoViewSamples.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableFocusableInteractionTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/list/LazyListFocusMoveTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/relocation/BringIntoViewResponderTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/relocation/BringIntoViewScrollableInteractionTest.kt
A       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/BringIntoViewRequestPriorityQueue.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/ContentInViewModifier.kt
A       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/UpdatableAnimationState.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/relocation/BringIntoViewResponder.kt
A       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/gestures/BringIntoViewRequestPriorityQueueTest.kt
A       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/gestures/UpdatableAnimationStateTest.kt

https://android-review.googlesource.com/2178020