Status Update
No update yet.
Comments
yu...@schimke.ee
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt - M
compose/foundation/foundation/api/restricted_current.txt - M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt - M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt - M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt - M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
st...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06androidx.compose.foundation:foundation-android:1.8.0-alpha06androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
st...@google.com
Having looked into this in more detail, GoogleMap does not support nested scrolling, so it's not compatible with Modifier.edgeSwipeToDismiss. Instead, we've seen that adding an 'enabled' parameter to SwipeDismissableNavHost and setting enabled = !cameraPositionState.isMoving would allow panning horizontally and vertically in the map (and adding a button to dismiss the screen). NB caveat is that there's a bug where the initial swipe needs to be vertical to avoid the parent handling it - this affects other scroll types as well as the Wear SwipeToDismiss.
We will look at adding the enabled parameter to Wear Compose in the near future (after release of 1.0).
st...@google.com
ra...@google.com
jo...@gmail.com
ap...@google.com
Branch: androidx-main
commit 9ca92a49e6529a24f9678b319074a9c7c532d74b
Author: Rajat Biswas <rajatbiswas@google.com>
Date: Tue Jul 04 11:16:50 2023
userSwipeEnabled param added to SwipeDismissableNavHost
Bug: 230865655
Test: androidx.wear.compose.navigation.SwipeDismissableNavHostTest
Relnote: "Added a param userSwipeEnabled to SwipeDismissableNavHost
which can disable swipe gesture if turned false."
Change-Id: Id2a0befd6895598967ccc6d617a7d4b52756b8c6
M wear/compose/compose-navigation/api/current.txt
M wear/compose/compose-navigation/api/restricted_current.txt
M wear/compose/compose-navigation/src/androidTest/kotlin/androidx/wear/compose/navigation/SwipeDismissableNavHostTest.kt
M wear/compose/compose-navigation/src/main/java/androidx/wear/compose/navigation/SwipeDismissableNavHost.kt
ra...@google.com
jo...@gmail.com
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.wear.compose:compose-navigation:1.3.0-alpha02
Description
Version used: 1.0.0-Alpha21
Devices/Android versions reproduced on: emulator
Google Map at top level - works well, scrolling around map is fine.
Google Map inside SwipeToDismissBox - scrolling disabled, swipe to dismiss from any point in the map.
Google Map inside SwipeDismissableNavHost - same scrolling issue.