Status Update
Comments
so...@google.com <so...@google.com>
zs...@salesforce.com <zs...@salesforce.com> #2
Hello,
Thank you for contacting the Google Cloud support team.
I have gone through your reported issue, however it seems like this is an issue observed specifically at your end within your project environment. It would need more specific debugging and analysis. To ensure a faster resolution and dedicated support for your issue, I kindly request you to file a support ticket by clicking
Please note that the Issue Tracker is primarily meant for reporting commonly observed issues and requesting new features. For individual support issues, it is best to utilize the support ticketing system. I'm going to close this issue which will no longer be monitored. If you have any additional issues or concerns, please don’t hesitate to create a new issue on the
Thank you, we appreciate your cooperation!
kl...@google.com <kl...@google.com> #3
I think we need to add some sort of UrlAnnotation
to AnnotatedString
to support this, like we did for TtsAnnotation
. We could do this before implementing support for actual clickable links, to at least support a11y.
so...@google.com <so...@google.com> #4
cl...@google.com <cl...@google.com> #6
is this a P4?
so...@google.com <so...@google.com> #7
To
Re-assigning back to Zach. As discussed, we'll proceed with
kl...@google.com <kl...@google.com>
ap...@google.com <ap...@google.com> #8
Branch: androidx-main
commit 0c11fb9996e4baf9bf46dc57de9df714b7f61214
Author: Zach Klippenstein <klippenstein@google.com>
Date: Thu May 26 17:01:28 2022
Introduce UrlAnnotation to support link a11y.
This change is basically just a copy of `VerbatimTtsAnnotation`.
Includes the new annotation type, methods on `AnnotatedString` and
`Builder`, a new `Saver`, support for converting to `URLSpan`s when creating
`SpannableString`s, a demo, and tests including a missing test for
`VerbatimTtsAnnotation`. All new APIs are marked experimental.
Fixes:
Test: ./gradlew :compose:ui:ui-text:test
Test: Tested TalkBack integration manually
Relnote: "Introduced the `UrlAnnotation` annotation type and associated
methods to support TalkBack link support in `AnnotatedString`s."
Change-Id: I1c754dfa0ce88a36989888b43816333dfc94b0aa
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/UrlAnnotation.kt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/AnnotatedString.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/platform/AndroidAccessibilitySpannableStringTest.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/AnnotatedStringBuilderTest.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SaversTest.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/TextFieldValueTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeTextAccessibility.kt
A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/UrlAnnotationExtensions.android.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidAccessibilitySpannableString.android.kt
M compose/ui/ui-text/api/current.txt
[Deleted User] <[Deleted User]> #9
Should I open a new issue to track this?
br...@monzo.com <br...@monzo.com> #10
I'm also just trying this for the first time and:
a) can confirm the above issue. When double clicking on a link in the accessibility menu, nothing happens.
b) even if the click handler ran, it would just launch an ACTION_VIEW intent, but this default behaviour isn't good enough for our use case. We want to be able to intercept the link in our Compose code and handle it appropriately.
Description
I'm currently exploring rendering markdown-style links using ClickableText/AnnotatedStrings, similar to how JetChat works here:https://github.com/android/compose-samples/blob/ee198110d8a7575da281de9bd0f84e91970468ca/Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/Conversation.kt#L481
I'm running into issues with matching the accessibility experience of the old View system. In the old system, URLSpans automatically provided a great accessibility UX:
This doesn't seem to be possible to replicate in Compose. All I can find in the semantics API is "custom actions", which is a similar but worse experience (no ding sound, no specific "links" submenu, no hint to the user that there's links to be clicked, etc).
I think this inconsistency will be confusing for accessibility users. Can we get a new API to help replicate the functionality of the View system? For example, could we add an annotation to indicate to TalkBack where the links are?
Thanks!