Unable to find common super type for <class_name> and <class_name> [231997058]

Fixed

Bug

Status Update

No update yet.

Description

ro...@sentry.io

created issue #1

May 10, 2022 10:04AM

Using the new Instrumentation API, I noticed that sometimes I have the following messages when the instrumentation transforms run (this is just one example of those):

Unable to find common super type for java/lang/Object and kotlin/coroutines/Continuation.
Unable to find common super type for kotlin/coroutines/Continuation and java/lang/Throwable.
Unable to find common super type for java/lang/reflect/Method and kotlin/Result$Companion.
Unable to find common super type for kotlin/KotlinNullPointerException and kotlin/coroutines/Continuation.

After checking the sources, I found out the warnings are being printed here, which gave me an impression that I cannot actually fix this on my site.

Some background on my instrumentation: I am looking at all classes (so not filtering anything in the isInstrumentable method) and then replacing some method calls with my static instrumented method calls. So I'd need those classes to be gone through the FixFramesClassWriter as well.

If there's nothing I can fix on my site, can this at least be an info or debug level log? It seems it doesn't affect the instrumentation or the runtime behavior of the app, so sounds like this can be avoided to pollute users' console log.

Studio Build: N/A Version of Gradle Plugin: 7.2 Version of Gradle: N/A Version of Java: 11 OS: N/A

Comments

lu...@google.com <lu...@google.com> May 10, 2022 10:05AM

Assigned to an...@google.com.

je...@google.com <je...@google.com> May 10, 2022 03:17PM

Reassigned to am...@google.com.

am...@google.com <am...@google.com> #2May 11, 2022 11:25AM

Here is the stacktrace:

java.lang.VerifyError: Verifier rejected class WN: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent) failed to verify: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent): [0x4]  can't resolve returned type 'Reference: android.app.Notification$Style' or 'Unresolved Reference: android.app.Notification$CallStyle' (declaration of 'WN' appears in base.apk!classes4.dex)
	at Tj.<init>(SourceFile:17)
	at kT1.<init>(SourceFile:23)
	at aL1.<init>(SourceFile:293)
	at bh4.get(SourceFile:1606)
	at cL1.a(SourceFile:29)
	at cL1.e(SourceFile:17)
	at s1i.getValue(Unknown Source:17)
	at dL1.a(SourceFile:11)
	at RQ1.b(Unknown Source:2)
	at EQ1.execute(SourceFile:15)
	at lU1.handleMessage(SourceFile:18)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at N52.dispatchMessage(SourceFile:7)
	at android.os.Looper.loop(Looper.java:237)
	at android.os.HandlerThread.run(HandlerThread.java:67)

Unfortunately, I can't share the dex2oat logs for this as I'm running into this problem on Android 11 emulator and I don't have a rooted Android 11 device on-hand.

ro...@sentry.io <ro...@sentry.io> #3May 11, 2022 03:48PM

Thanks for the report. Can you share the APK failing and give suggestions to force the error such that I can see the entire logcat on device. The outline is looking correct so I believe the error is someplace else and logcat will show that.

Message last modified on May 16, 2022 07:15AM

am...@google.com <am...@google.com> #4May 26, 2022 02:15PM

I shared the APK and instructions to reproduce over email. Let me know if you have any trouble reproing the crash.

ro...@sentry.io <ro...@sentry.io> #5May 30, 2022 08:53AM

Thank you for the dump and information. Turns out that behavior of the verifier changed on Android 11 and 12 but was reverted again. I am working on a fix that should be easy to merge to the 4.0 branch.

Note that the verification error is actually also easy to create by manual outlining, but our pattern just emphasize it.

am...@google.com <am...@google.com> #6May 31, 2022 01:25PM

Project: r8
Branch: main

commit b7b22190797c9b74218fb1d2fdfb497a9be9fb3b
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Mar 20 13:03:38 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

Change-Id: I2479d669217d90f057fa248fcea0f0f27faf91a6

M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
M src/main/java/com/android/tools/r8/ir/code/Return.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java
M src/main/java/com/android/tools/r8/ir/desugar/apimodel/ApiInvokeOutlinerDesugaring.java
A src/main/java/com/android/tools/r8/ir/optimize/RemoveVerificationErrorForUnknownReturnedValues.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelManualOutlineWithUnknownReturnTypeTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineHorizontalMergingTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineInstanceInitializerTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineWithUnknownReturnTypeTest.java

https://r8-review.googlesource.com/77221

ro...@sentry.io <ro...@sentry.io> #7Jun 13, 2022 10:09AM

Project: r8
Branch: main

commit 88dd6ed0006725301bcbe88942e474569c9aa1b1
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Mar 20 12:43:54 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

Change-Id: I5684a12bf42422bb96122422e063ffd0503fb5e5

M src/main/java/com/android/tools/r8/utils/AndroidApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelManualOutlineWithUnknownReturnTypeTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineWithUnknownReturnTypeTest.java

https://r8-review.googlesource.com/77180

Message last modified on Jun 13, 2022 10:13AM

ro...@sentry.io <ro...@sentry.io> #8Jun 27, 2022 11:24AM

thanks for the fix. if this can be backported to 4.0 that would be great

am...@google.com <am...@google.com> #9Sep 29, 2022 12:41PM

Marked as fixed.

Project: r8
Branch: 8.0

commit e1cdcb66b3a225076a41b646a2684d150a594693
Author: Rico Wind <ricow@google.com>
Date: Tue Mar 21 18:58:29 2023

Version 8.0.39

Bug:

b/272725341

Change-Id: Iad8a15631027cf587871f6c8df12a8b4c601296c

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77428

ro...@sentry.io <ro...@sentry.io> #10Sep 29, 2022 01:01PM

Project: r8
Branch: 8.0

commit 7248df9f87378eda019093887585afba9631a669
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Mar 21 13:59:20 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

https://r8-review.googlesource.com/77425

ke...@gmail.com <ke...@gmail.com> #11Jun 19, 2023 10:30AM

Project: r8
Branch: 8.0

commit 4c0694de75503094bb84d6e28fd091453b172e2e
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Mar 21 13:59:12 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

https://r8-review.googlesource.com/77424

Issue 231997058

Description

Issue summary

Comments

lu...@google.com <lu...@google.com> May 10, 2022 10:05AM

je...@google.com <je...@google.com> May 10, 2022 03:17PM

am...@google.com <am...@google.com> #2May 11, 2022 11:25AM

ro...@sentry.io <ro...@sentry.io> #3May 11, 2022 03:48PM

am...@google.com <am...@google.com> #4May 26, 2022 02:15PM

ro...@sentry.io <ro...@sentry.io> #5May 30, 2022 08:53AM

am...@google.com <am...@google.com> #6May 31, 2022 01:25PM

ro...@sentry.io <ro...@sentry.io> #7Jun 13, 2022 10:09AM

ro...@sentry.io <ro...@sentry.io> #8Jun 27, 2022 11:24AM

am...@google.com <am...@google.com> #9Sep 29, 2022 12:41PM

ro...@sentry.io <ro...@sentry.io> #10Sep 29, 2022 01:01PM

ke...@gmail.com <ke...@gmail.com> #11Jun 19, 2023 10:30AM

Add comment

Issue metadata