Unable to find common super type for <class_name> and <class_name> [231997058]

Fixed

Bug

Status Update

No update yet.

Description

ro...@sentry.io

created issue #1

May 10, 2022 10:04AM

Using the new Instrumentation API, I noticed that sometimes I have the following messages when the instrumentation transforms run (this is just one example of those):

Unable to find common super type for java/lang/Object and kotlin/coroutines/Continuation.
Unable to find common super type for kotlin/coroutines/Continuation and java/lang/Throwable.
Unable to find common super type for java/lang/reflect/Method and kotlin/Result$Companion.
Unable to find common super type for kotlin/KotlinNullPointerException and kotlin/coroutines/Continuation.

After checking the sources, I found out the warnings are being printed here, which gave me an impression that I cannot actually fix this on my site.

Some background on my instrumentation: I am looking at all classes (so not filtering anything in the isInstrumentable method) and then replacing some method calls with my static instrumented method calls. So I'd need those classes to be gone through the FixFramesClassWriter as well.

If there's nothing I can fix on my site, can this at least be an info or debug level log? It seems it doesn't affect the instrumentation or the runtime behavior of the app, so sounds like this can be avoided to pollute users' console log.

Studio Build: N/A Version of Gradle Plugin: 7.2 Version of Gradle: N/A Version of Java: 11 OS: N/A

Comments

lu...@google.com <lu...@google.com> May 10, 2022 10:05AM

Assigned to an...@google.com.

je...@google.com <je...@google.com> May 10, 2022 03:17PM

Reassigned to am...@google.com.

am...@google.com <am...@google.com> #2May 11, 2022 11:25AM

Thank you for the report and the supplied dump with the reproduction. I can confirm that the NPE is also present on HEAD, and I will look into it.

Quite a few of the class files in the dump has malformed inner-class attribute, where R8 reports e.g.:

Info in /tmp/tmpo67ucguh/program.jar:ofifmwrrhhmodsc/ψξψξψξξ.class:
Malformed inner-class attribute:
	outerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ
	innerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ$ψξξψξξξ
	innerName: ψξψξψξξ$ψξξψξξξ

These are ignored, so they should not be the reason for the NPE, but something to also look into.

ro...@sentry.io <ro...@sentry.io> #3May 11, 2022 03:48PM

Project: r8
Branch: main

commit e59500ca4445f5fb5d2ccc1114acbf66df11d196
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:55 2023

Insert patched frame instructions in the right place

Fixes:

b/274337639

Change-Id: Iae204ed529f9af5bf5fa3eaacba45128dfa6fd9e

M src/main/java/com/android/tools/r8/graph/LazyCfCode.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77390

Message last modified on May 16, 2022 07:15AM

am...@google.com <am...@google.com> #4May 26, 2022 02:15PM

Project: r8
Branch: main

commit 780c2e83c8c033e7594d61894fa1b3dbcad6630b
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:13 2023

Add reproduction of

b/274337639

Bug:

b/274337639

Change-Id: I7573883d6a649eed47b10d7bf0cdea2e11710268

M build.gradle
M src/main/java/com/android/tools/r8/cf/code/frame/UninitializedNew.java
A src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77389

ro...@sentry.io <ro...@sentry.io> #5May 30, 2022 08:53AM

I will backport this to the 8.0 and 4.0 branches.

am...@google.com <am...@google.com> #6May 31, 2022 01:25PM

Thank you very much for taking a look at this!

Is this fix related to the nullpointer or the malformed inner-class attributes ?

Do you have a separated ticket for it? Could you share it?

ro...@sentry.io <ro...@sentry.io> #7Jun 13, 2022 10:09AM

Project: r8
Branch: 4.0

commit 6edb00fb23e41b28d4794cfa69d706d5c5aa3fba
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:55:01 2023

Version 4.0.56

Bug:

b/274337639

Change-Id: I88a20fc922ce892d38fa3a34f9a3f1f4714354ae

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77447

Message last modified on Jun 13, 2022 10:13AM

ro...@sentry.io <ro...@sentry.io> #8Jun 27, 2022 11:24AM

Project: r8
Branch: 4.0

commit d9215af3b02f64d1207b9ebd63a6925229307b9d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:50 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77446

am...@google.com <am...@google.com> #9Sep 29, 2022 12:41PM

Marked as fixed.

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77445

ro...@sentry.io <ro...@sentry.io> #10Sep 29, 2022 01:01PM

Project: r8
Branch: 8.0

commit 6686e7dffea83ea894438b496c065d0a18cda206
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:53:01 2023

Version 8.0.37

Bug:

b/274337639

Change-Id: I43a723a94638088d921cd3fb6e22ef6e41f07d5f

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77444

ke...@gmail.com <ke...@gmail.com> #11Jun 19, 2023 10:30AM

Project: r8
Branch: 8.0

commit 57f55fb70aa678a61f9c7ff1826fbc695faeac7d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:52:27 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77443

Issue 231997058

Description

Issue summary

Comments

lu...@google.com <lu...@google.com> May 10, 2022 10:05AM

je...@google.com <je...@google.com> May 10, 2022 03:17PM

am...@google.com <am...@google.com> #2May 11, 2022 11:25AM

ro...@sentry.io <ro...@sentry.io> #3May 11, 2022 03:48PM

am...@google.com <am...@google.com> #4May 26, 2022 02:15PM

ro...@sentry.io <ro...@sentry.io> #5May 30, 2022 08:53AM

am...@google.com <am...@google.com> #6May 31, 2022 01:25PM

ro...@sentry.io <ro...@sentry.io> #7Jun 13, 2022 10:09AM

ro...@sentry.io <ro...@sentry.io> #8Jun 27, 2022 11:24AM

am...@google.com <am...@google.com> #9Sep 29, 2022 12:41PM

ro...@sentry.io <ro...@sentry.io> #10Sep 29, 2022 01:01PM

ke...@gmail.com <ke...@gmail.com> #11Jun 19, 2023 10:30AM

Add comment

Issue metadata