Unable to find common super type for <class_name> and <class_name> [231997058]

Fixed

Bug

Status Update

No update yet.

Description

ro...@sentry.io

created issue #1

May 10, 2022 10:04AM

Using the new Instrumentation API, I noticed that sometimes I have the following messages when the instrumentation transforms run (this is just one example of those):

Unable to find common super type for java/lang/Object and kotlin/coroutines/Continuation.
Unable to find common super type for kotlin/coroutines/Continuation and java/lang/Throwable.
Unable to find common super type for java/lang/reflect/Method and kotlin/Result$Companion.
Unable to find common super type for kotlin/KotlinNullPointerException and kotlin/coroutines/Continuation.

After checking the sources, I found out the warnings are being printed here, which gave me an impression that I cannot actually fix this on my site.

Some background on my instrumentation: I am looking at all classes (so not filtering anything in the isInstrumentable method) and then replacing some method calls with my static instrumented method calls. So I'd need those classes to be gone through the FixFramesClassWriter as well.

If there's nothing I can fix on my site, can this at least be an info or debug level log? It seems it doesn't affect the instrumentation or the runtime behavior of the app, so sounds like this can be avoided to pollute users' console log.

Studio Build: N/A Version of Gradle Plugin: 7.2 Version of Gradle: N/A Version of Java: 11 OS: N/A

Comments

lu...@google.com <lu...@google.com> May 10, 2022 10:05AM

Assigned to an...@google.com.

je...@google.com <je...@google.com> May 10, 2022 03:17PM

Reassigned to am...@google.com.

am...@google.com <am...@google.com> #2May 11, 2022 11:25AM

Will be this fix also part of 4.2 please?

ro...@sentry.io <ro...@sentry.io> #3May 11, 2022 03:48PM

for the "out" bundle issue, this seems indeed an issue. for the second one reported adding "debugUpdateAPKArtifact" to the path, this WAI as there can more more than one transformer and we need to automatically separate them so they do not use the same output folder. for #3, I will look at it but it might be difficult to change it at this time.

Message last modified on May 16, 2022 07:15AM

am...@google.com <am...@google.com> #4May 26, 2022 02:15PM

I understand that if there is more transformer is necessary to make every folder different, but there is the main problem, that the final one (last transform) is inside of the intermediate folder. The last transformation should end in the standard location, right? Maybe also with the default name not?

ro...@sentry.io <ro...@sentry.io> #5May 30, 2022 08:53AM

Hello, this is a P1 S1 issue for a while now, and it's blocking us from upgrading to AGP 4.2 and further. What's the current status? And do you have plans to backport it to 4.2.x?

am...@google.com <am...@google.com> #6May 31, 2022 01:25PM

no we don't have a plan to backport this. why is this blocking you from upgrading ?

ro...@sentry.io <ro...@sentry.io> #7Jun 13, 2022 10:09AM

We sign apk's and bundles via internal service, and i don't know another way to interact with artifacts; Yesterday i ended up with some ugly workaround: https://github.com/avito-tech/avito-android/pull/1085/files#diff-b898cc20fedebe394439bb37ffb91d3366a1f9a6d359dbdebca79af8a079f911 I'd be glad if you'll point me out how can it be done better.

Message last modified on Jun 13, 2022 10:13AM

ro...@sentry.io <ro...@sentry.io> #8Jun 27, 2022 11:24AM

I commented on the merge request but to summarize :

you can set your signing tasks output folder to wherever you need to be :

artifacts.use(target.tasks.signedApkTaskProvider(this)).configure { signedDirProperty.set(File("/path/to/where/you/want/your/signed/files")) }

if you don't set it, then we will set a directory automatically.

am...@google.com <am...@google.com> #9Sep 29, 2022 12:41PM

Marked as fixed.

Thanks, Jerome!

ro...@sentry.io <ro...@sentry.io> #10Sep 29, 2022 01:01PM

I checked that we do have correct behavior for FILE based artifacts like bundle :

> Task :app:debugUpdateArtifact
originalArtifact: /usr/local/google/home/jedo/src/studio-main/out/apiTests/Kotlin/bugTest/app/build/intermediates/bundle/debug/signDebugBundle/app-debug.aab
updatedArtifact: /usr/local/google/home/jedo/src/studio-main/out/apiTests/Kotlin/bugTest/app/build/outputs/bundle/debug/app-debug.aab

however, we still seem to not be consistent for the DIRECTORY based artifacts like APK:

> Task :app:debugUpdateAPKArtifact
Input folder: /usr/local/google/home/jedo/src/studio-main/out/apiTests/Kotlin/bugTest/app/build/outputs/apk/debug
Output folder: /usr/local/google/home/jedo/src/studio-main/out/apiTests/Kotlin/bugTest/app/build/intermediates/apk/debug
Input file: /usr/local/google/home/jedo/src/studio-main/out/apiTests/Kotlin/bugTest/app/build/outputs/apk/debug/app-debug.apk

Alex, can you have a look ?

ke...@gmail.com <ke...@gmail.com> #11Jun 19, 2023 10:30AM

correction, I was not correct about FILE being correct.

Instead of :

updatedArtifact: /usr/local/google/home/jedo/src/studio-main/out/apiTests/Kotlin/bugTest/app/build/outputs/bundle/debug/app-debug.aab

it should be

updatedArtifact: /usr/local/google/home/jedo/src/studio-main/out/apiTests/Kotlin/bugTest/app/build/outputs/app-debug.aab
``