Animation: keyframes API support percentage of animation in addition to millis [232059455]

Fixed

Feature Request

Status Update

No update yet.

Description

ri...@google.com

created issue #1

May 10, 2022 09:13AM

Jetpack Compose version: 1.2.0 Jetpack Compose component used: Animation

Currently the keyframes() spec API only supports setting a keyframe at a millis point, this means if you change your duration of the whole animation, you will need to change all the millis checkpoints again.

Would it be possible to add another method for keyframes that lets you work in percentages? This would also conform more to the keyframes spec of CSS.

https://developer.mozilla.org/en-US/docs/Web/CSS/@keyframes

Example of such function that works with range:

fun <T> KeyframesSpec.KeyframesSpecConfig<T>.atOffset(
    @FloatRange(from = 0.0, to = 1.0) offset: Float,
    value: T
): KeyframesSpec.KeyframeEntity<T> {
    return value at (durationMillis * offset).roundToInt()
}

Comments

ri...@google.com <ri...@google.com> May 12, 2022 09:54AM

Reassigned to ti...@google.com.

ri...@google.com <ri...@google.com> Jul 4, 2022 03:03PM

Reassigned to ri...@google.com.

ap...@google.com <ap...@google.com> #2Aug 2, 2022 07:32AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ri...@google.com <ri...@google.com> Aug 2, 2022 07:45AM

Marked as fixed.

Issue 232059455

Description

Issue summary

Comments

ri...@google.com <ri...@google.com> May 12, 2022 09:54AM

ri...@google.com <ri...@google.com> Jul 4, 2022 03:03PM

ap...@google.com <ap...@google.com> #2Aug 2, 2022 07:32AM

ri...@google.com <ri...@google.com> Aug 2, 2022 07:45AM

Add comment

Issue metadata