Fixed
Status Update
Comments
ow...@google.com <ow...@google.com>
al...@google.com <al...@google.com>
il...@google.com <il...@google.com>
jb...@google.com <jb...@google.com> #2
Another alternative may be to add a MergeAdapter.Config.Builder
constructor that accepts a seed configuration as a parameter, so that one could write
mAdapter = MergeAdapter(
MergeAdapter.Config.Builder(MergeAdapter.Config.DEFAULT)
.setStableIdMode(ISOLATED_STABLE_IDS)
.build(),
adapter1,
adapter2
)
etc.
to...@yahoo.com <to...@yahoo.com> #3
Sorry for the delay.
I think this is a very good point. Forwarding onto a colleague to see what they think.
ap...@google.com <ap...@google.com> #4
this makes sense but a bit risky because it will be a behavior change and we usually don't do those in beta. on the other hand, if not now, it will be never so might be better to just make the change instead.
jb...@google.com <jb...@google.com> #5
in fact, the docs say isolateViewTypes
defaults to true which it does not :).
I'll try to fix this before rc
yu...@gmail.com <yu...@gmail.com> #7
Thanks for the fix, folks! :)
Description
Please see https://issuetracker.google.com/227376894
and the earlier related issue(s)
This needs to be re-opened as the fix mentioned in
is itself introducing a new bug; please the source code for that fix.
Please may I remind you about the contract for onPrepareMenu: called when the menu is first shown
But in your code, you now simply call onPrepareMenu during the onCreateMenu phase.
I realise that Toolbar did/does not implement onPrepareMenu properly up to now, but it never promised to do, so that was ok up to now.
However, if you're adding support for MenuProvider (thank you!) then it has to be implemented such that it's contract is fulfilled. Right now, the contract of the MenuProvider is broken in Toolbar.