Have AppCompat Toolbar call onPrepareMenu() at the correct time [232206677]

Fixed

Bug

Status Update

No update yet.

Description

to...@yahoo.com

created issue #1

May 11, 2022 04:59PM

Please see https://issuetracker.google.com/227376894

and the earlier related issue(s)

This needs to be re-opened as the fix mentioned in

https://issuetracker.google.com/issues/227376894#comment3

is itself introducing a new bug; please the source code for that fix.

AppCompat 1.5.0-alpha01.

Please may I remind you about the contract for onPrepareMenu: called when the menu is first shown

But in your code, you now simply call onPrepareMenu during the onCreateMenu phase.

I realise that Toolbar did/does not implement onPrepareMenu properly up to now, but it never promised to do, so that was ok up to now.

However, if you're adding support for MenuProvider (thank you!) then it has to be implemented such that it's contract is fulfilled. Right now, the contract of the MenuProvider is broken in Toolbar.

Comments

ow...@google.com <ow...@google.com> May 20, 2022 01:28PM

Assigned to al...@google.com.

al...@google.com <al...@google.com> May 20, 2022 01:53PM

Reassigned to sa...@google.com.

il...@google.com <il...@google.com> Jun 16, 2022 09:37PM

Reassigned to jb...@google.com.

jb...@google.com <jb...@google.com> #2Jun 30, 2022 12:43AM

Alternatively, we could make all of the drawable compat classes public.

to...@yahoo.com <to...@yahoo.com> #3Jun 30, 2022 10:26AM

Needs to wait until we're back to alpha.

Bugjuggler: wait until 2022-07-21

MenuProv.zip

612 KB

Download

ap...@google.com <ap...@google.com> #4Aug 3, 2022 09:07PM

Hi. I've received your bug and will wait until 2022-07-21 00:00 -0400 EDT and then assign the bug to alanv@google.com.

jb...@google.com <jb...@google.com> #5Aug 3, 2022 09:10PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit de70044326e54d6a50f0745f481bd46927cb777a
Author: Alan Viverette <alanv@google.com>
Date: Thu Jul 28 13:03:36 2022

Move AppCompat's drawable compat classes to public API

Nullability is missing because the platform classes are also missing
nullability.

Relnote: "Move DrawableWrapper, DrawableContainer, and StateListDrawable
compat classes to public API."
Fixes: 227789566
Test: DrawableContainerCompatTest, AnimatedStateListDrawableCompatTest
Change-Id: I37f3e188d926628853c3ef37ce7a32f28afd2823

A appcompat/appcompat-resources/api/restricted_current.ignore
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/DrawableWrapperCompat.java
M appcompat/appcompat-resources/lint-baseline.xml
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/DrawableContainerCompat.java
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/AnimatedStateListDrawableCompat.java
M appcompat/appcompat-resources/api/api_lint.ignore
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/StateListDrawableCompat.java
M appcompat/appcompat-resources/src/androidTest/java/androidx/appcompat/graphics/drawable/DrawableContainerCompatTest.kt
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/DropDownListView.java
M appcompat/appcompat-resources/api/public_plus_experimental_current.txt
M appcompat/appcompat-resources/api/current.txt
M appcompat/appcompat-resources/api/restricted_current.txt
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/widget/DrawableUtils.java

https://android-review.googlesource.com/2120177

ju...@gmail.com <ju...@gmail.com> #6Jan 26, 2023 01:12AM

deleted

yu...@gmail.com <yu...@gmail.com> #7Feb 9, 2024 11:23PM

deleted