Provide access to ClassReader in Instrumentation API [232682821]

Assigned

Feature Request

Status Update

No update yet.

Description

ro...@sentry.io

created issue #1

May 16, 2022 07:14AM

Would it be possible to expose the ClassReader that is used to read classes' bytecode in the new Instrumentation API? I know it's probably gonna be a breaking change for createClassVisitor method, but perhaps this could be part of InstrumentationContext or something alike?

My use-case is I'd like to read some constants (in particular, the R8 marker) from the classes' constant pool and now I need to do a bunch of reflection to reach the originating ClassReader, which isn't great obviously.

Studio Build: N/A Version of Gradle Plugin: 7.2.0 Version of Gradle: N/A Version of Java: N/A OS: N/A

Comments

ro...@sentry.io <ro...@sentry.io> #2May 16, 2022 05:32PM

I think this should be under AGP's issue tracker

ro...@sentry.io <ro...@sentry.io> #3Jun 12, 2022 10:13PM

Please move this to the AGP tracker.

Thanks.

am...@google.com <am...@google.com> #4Sep 29, 2022 03:15PM

Assigned to am...@google.com.

We can add the class reader object to ClassContext, however, we'll need to restrict calling certain methods in ClassReader which might impact the transformation later.

ro...@sentry.io <ro...@sentry.io> #5Sep 29, 2022 03:32PM

Makes sense, this is all I'm currently interested in, if it helps. Not sure if those members/methods need to be restricted.

am...@google.com <am...@google.com> Feb 8, 2024 03:16PM

Reassigned to an...@google.com.

je...@google.com <je...@google.com> Feb 9, 2024 11:51PM

Reassigned to cm...@google.com.

Issue 232682821