IssueTracker

The new Variant API SourceDirectoriesImpl.addGeneratedSourceDirectory() allows to add a custom task generating source files that need to be compiled within the build process, but does not add the generated source directory to the IDE model in TaskProviderBasedDirectoryEntryImpl.

It is used in replacement of the old API BaseVariantImpl.registerJavaGeneratingTask() that automatically added the generated source directories to the IDE model.

It seems to me that the old behavior should be maintained, i.e., either:

• set shouldBeAddedToIdeModel to true by default in the constructor of TaskProviderBasedDirectoryEntryImpl,
• pass shouldBeAddedToIdeModel = true when creating TaskProviderBasedDirectoryEntryImpl in addGeneratedSourceDirectory,
• add an optional argument to addGeneratedSourceDirectory for letting the user set the desired value of shouldBeAddedToIdeModel.

Note that it should go the same way with SourceDirectoriesImpl.addStaticSourceDirectory().

Also, I would personally not set the path of the output directory here if it has already been set by the user before calling addGeneratedSourceDirectory, since this overwriting is not documented and not obvious to the user. Or similarly to shouldBeAddedToIdeModel, this behavior (setting or not the output directory) could be controlled through an optional argument to addGeneratedSourceDirectory.

Please consider this other issue too that might be relevant as well (I did not try to reproduce it), it apppears not only in TaskProviderBasedDirectoryEntryImpl but also in ProviderBasedDirectoryEntryImpl.

---

Studio Build: #AI-213.7172.25.2211.8571212 (Android Studio Electric Eel | 2022.1.1 Canary 2)

Version of Gradle Plugin: 7.4.0-alpha02

Version of Gradle: 7.5-rc-1

Version of Java: 1.8

OS: Ubuntu 18.04