Status Update
Comments
[Deleted User] <[Deleted User]> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Hao Dong <
Link:
Update documentation and annotations
Expand for full commit details
Update documentation and annotations
1. Update BiometricPrompt documentation with strength info
2. Add @Deprecated annotation for IdentityCredential to keep
consistent with framework.
3. Use rule instead of MockitoAnnotations
Fixes: 140252778
Fixes: 217942278
Fixes: 251211046
Fixes: 239955609
Relnote: "Add @Deprecated annotation for IdentityCredential to keep
consistent with framework."
Test: ./gradlew biometric:biometric:assemble
Test: ./gradlew biometric:biometric:updateApi
Change-Id: I6ac906032150503829af6a4aca028037be7934af
Files:
- M
biometric/biometric/api/current.txt
- M
biometric/biometric/api/restricted_current.txt
- M
biometric/biometric/lint-baseline.xml
- M
biometric/biometric/src/androidTest/java/androidx/biometric/DeviceUtilsTest.java
- M
biometric/biometric/src/main/java/androidx/biometric/BiometricPrompt.java
- M
biometric/biometric/src/main/java/androidx/biometric/CryptoObjectUtils.java
- M
biometric/biometric/src/test/java/androidx/biometric/AuthenticationCallbackProviderTest.java
- M
biometric/biometric/src/test/java/androidx/biometric/BiometricManagerTest.java
- M
biometric/biometric/src/test/java/androidx/biometric/CancellationSignalProviderTest.java
- M
biometric/biometric/src/test/java/androidx/biometric/CryptoObjectUtilsTest.java
- M
biometric/biometric/src/test/java/androidx/biometric/KeyguardUtilsTest.java
- M
biometric/biometric/src/test/java/androidx/biometric/PackageUtilsTest.java
- M
credentials/credentials/src/main/java/androidx/credentials/provider/utils/CryptoObjectUtils.kt
Hash: 65b837ca1bbe66dafeab43b78bca416d6abc04fc
Date: Tue Nov 12 18:27:57 2024
ge...@gmail.com <ge...@gmail.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.credentials:credentials:1.5.0-rc01
ds...@google.com <ds...@google.com>
ds...@google.com <ds...@google.com> #4
in...@nplan.io <in...@nplan.io> #5
As the issue has been resolved, can you please elaborate how we can request extra disk space? Thank you
ma...@flyrlabs.com <ma...@flyrlabs.com> #6
ds...@google.com <ds...@google.com> #7
Hello,
This has been forwarded to the Vertex AI Engineering Team so that they may evaluate it. Note that there are no ETAs or guarantees of implementation for feature requests. All communication regarding this feature request is to be done here .
je...@ml6.eu <je...@ml6.eu> #8
Really in need of this functionality. The current workaround using create_custom_training_job_op_from_component
works, but is cumbersome.
li...@snyk.io <li...@snyk.io> #9
Also in need of this. The bigger GPU instances are pointless with such small defaults disk volume
li...@snyk.io <li...@snyk.io> #10
I don't know if Google never plan on looking into this or is this perceived to be messy since kfp package only has set_cpu_limit
, set_gpu_limit
, set_memory_limit
, but not disk limit. (You can guess these API are designed by Google since they never need to write to local disk ... ). So adding a new setter method would require work from both kfp open source and Vertex AI.
Just in case it helps Vertex AI team: the existing add_node_selector_constraint
appears to be a potentially a good place to implement this on Vertex AI side. The spirit of this API is to allow arbitrary constraints passed to workers. Vertex AI already use this picking GPU, which eventually arrives at workerPoolSpecs
, where diskSpec
also resides. So the implementation might not be that hard.
li...@snyk.io <li...@snyk.io> #11
Like others mentioned, create_custom_training_job_op_from_component
works but is a bit problematic. Here's my hack (in case anyone on this thread still uses Vertex AI despite such issues)
my_comp = create_custom_training_job_from_component(adhoc_comp)(
project=PROJECT_ID, location=REGION, timeout="1209600s",
command=CLI_COMMAND)
my_comp.set_display_name("ad hoc")
worker_pool_spec = my_comp.component_spec.inputs["worker_pool_specs"].default[0]
worker_pool_spec["disk_spec"]["boot_disk_size_gb"] = 500
adhoc_comp is my kfp component and command
is my component's parameter.
Description
It would be really nice/convenient if customers are able to request the disk space for a python function based component, just like requests for CPU, Memory and GPUs when Specifying machine types for a Vertex AI pipeline[1].
How this might work:
Be able to specify Disk size just like specifying CUP, Memory when Specifying machine types for a Vertex AI pipeline[1].
If applicable, reasons why alternative solutions are not sufficient:
Currently the boot_disk_size_gb option[2] could help increase the disk size, however, it is a little bit inconvenient. Specifying machine types for a Vertex AI pipeline[1] with disk option available is more straightforward.
Other information (workarounds you have tried, documentation consulted, etc):
[1]
[2]