Add additional transform APIs to Compose Path [233772232]

Fixed

Feature Request

Status Update

No update yet.

Description

nj...@google.com

created issue #1

May 24, 2022 06:38PM

We should introduce additional transform facilities on Compose's Path API to streamline scale/translation/rotation operations

Right now attempting to scale a Compose Path looks like the following which we can probably improve upon:

asAndroidPath().apply { transform(scaleMatrix(1.5f, 1.5f)) }.asComposePath()

Comments

nj...@google.com <nj...@google.com> #2May 3, 2023 11:07PM

Marked as fixed.

Can you please attach a minimal repro, and provide more information about the system (device etc.) The fonts in the screenshots are different and I do not know how to reproduce the error.

ap...@google.com <ap...@google.com> #3May 3, 2023 11:07PM

Hello!

I created a small sample to replicate the issue. It looks like the font family selector is not able to pick the correct weight when the medium font is in the family. I used the Butler to replicate the issue, but I could get the same behaviour with many proprietary fonts with ExtraLigth weight.

It looks like the issue is not present in Android 10 and 11.

ju...@google.com <ju...@google.com> #4May 24, 2023 07:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit f6fd709160fbc240e49710c9b248cd14394f64e2
Author: haoyu <haoyuchang@google.com>
Date: Fri Feb 05 17:28:12 2021

Fix: font weight might not work under API 28

Bug: 177423444
Test: ./gradlew test
Test: ./gradlew compose:ui:ui-text:connectedAndroidTest
RelNote: "FontSpan and FontWeigthStyleSpan are no longer used and removed."
Change-Id: Ie5b5611883bc6a44577ae47572754f3d988526ba

M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/platform/AndroidParagraphTest.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/platform/SpannableExtensionsTest.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/TextPaintExtensions.kt
D text/text/src/androidTest/java/androidx/compose/ui/text/android/style/FontSpanTest.kt
D text/text/src/androidTest/java/androidx/compose/ui/text/android/style/FontWeightStyleSpanTest.kt
D text/text/src/main/java/androidx/compose/ui/text/android/style/FontSpan.kt
D text/text/src/main/java/androidx/compose/ui/text/android/style/FontWeightStyleSpan.kt

https://android-review.googlesource.com/1579109

Issue 233772232

Description

Issue summary

Comments

nj...@google.com <nj...@google.com> #2May 3, 2023 11:07PM

ap...@google.com <ap...@google.com> #3May 3, 2023 11:07PM

ju...@google.com <ju...@google.com> #4May 24, 2023 07:37PM

Add comment

Issue metadata