ConcurrentModificationException in SnapshotStateObserver [233929916]

Assigned

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

May 26, 2022 04:32PM

Jetpack Compose version: Snapshot 8610790 Jetpack Compose component used: Many Android Studio Build: EE alpha 2 Kotlin version: 1.6.21

Got the following stack trace in Play Console, never seen it locally and it does not have any information for me to repro.

java.util.ConcurrentModificationException:
  at java.util.HashMap$HashIterator.nextNode (HashMap.java:1441)
  at java.util.HashMap$KeyIterator.next (HashMap.java:1465)
  at androidx.compose.runtime.snapshots.SnapshotStateObserver$ApplyMap.callOnChanged (SnapshotStateObserver.java:270)
  at androidx.compose.runtime.snapshots.SnapshotStateObserver.callOnChanged (SnapshotStateObserver.java:207)
  at androidx.compose.runtime.snapshots.SnapshotStateObserver.access$callOnChanged (SnapshotStateObserver.java:24)
  at androidx.compose.runtime.snapshots.SnapshotStateObserver$applyObserver$1$2.invoke (SnapshotStateObserver.java:43)
  at androidx.compose.foundation.Clickable_androidKt$isComposeRootInScrollableContainer$1.h (Clickable.android.kt:298)
  at androidx.compose.ui.platform.AndroidComposeView$snapshotObserver$1.invoke$lambda-0 (AndroidComposeView.java:290)
  at android.os.Handler.handleCallback (Handler.java:938)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loopOnce (Looper.java:201)
  at android.os.Looper.loop (Looper.java:288)
  at android.app.ActivityThread.main (ActivityThread.java:7870)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:548)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1003)

Would be nice to have some insight on possible cause to try to repro.

Comments

lp...@google.com <lp...@google.com> May 26, 2022 05:22PM

Assigned to ch...@google.com.

vi...@gmail.com <vi...@gmail.com> #2Jun 20, 2022 07:40AM

I proposed this which I think it is better than the actual behavior, and could let the developers work with more room to be creative.

https://code.google.com/p/android/issues/detail?id=58318

ch...@google.com <ch...@google.com> #3Jun 23, 2022 05:14PM

The presentation link doesn't work.

ma...@gmail.com <ma...@gmail.com> #4Jul 20, 2022 01:58PM

In Custom Notification Layouts section of the Notification API Guides, it states: "The height available for a custom notification layout depends on the notification view. Normal view layouts are limited to 64 dp, and expanded view layouts are limited to 256 dp". I guess it means the width is 512 dp and the height is 256 dp (if following the 2:1 aspect ratio)?

http://developer.android.com/guide/topics/ui/notifiers/notifications.html#CustomNotification

ma...@gmail.com <ma...@gmail.com> #5Jul 20, 2022 02:01PM

Here is the presentation:

http://commondatastorage.googleapis.com/io2012/presentations/live%20to%20website/105.pdf

ch...@google.com <ch...@google.com> #6Jul 25, 2022 10:42PM

https://code.google.com/p/android/issues/detail?id=58318http://developer.android.com/reference/android/app/Notification.BigPictureStyle.html#bigPicture(android.graphics.Bitmap)

st...@google.com <st...@google.com> #7Jul 26, 2022 10:19AM

Any update on this?

Message last modified on Jul 26, 2022 10:20AM

ma...@gmail.com <ma...@gmail.com> #8Sep 5, 2022 08:16AM

Thank you for your feedback. We assure you that we are doing our best to address all issues reported. For now, we will be closing the issue as won't fix obsolete. If this issue currently still exists, we request that you log a new issue along with the bug report here

https://goo.gl/TbMiIO and reference this bug for context.

Message last modified on Sep 5, 2022 08:18AM

ch...@google.com <ch...@google.com> #9Sep 7, 2022 08:59PM

1.2.0 does not have this fix. It will first appear in a stable build in 1.3.0 which just entered beta 2 and will be going to RC soon.

12...@qq.com <12...@qq.com> #10Jan 4, 2023 08:05AM

We got the following crash:

java.util.ConcurrentModificationException
	at java.util.ArrayList$Itr.next(ArrayList.java:860)
	at java.util.AbstractList.equals(AbstractList.java:522)
	at kotlin.jvm.internal.Intrinsics.areEqual(Intrinsics.java:167)
	at androidx.compose.runtime.StructuralEqualityPolicy.equivalent(SnapshotMutationPolicy.kt:90)
	at androidx.compose.runtime.StructuralEqualityPolicy.equivalent(SnapshotMutationPolicy.kt:90)
	at androidx.compose.runtime.SnapshotMutableStateImpl.setValue(SnapshotState.kt:132)
	at androidx.compose.runtime.SnapshotMutableStateImpl.setValue(SnapshotState.kt:132)
	at androidx.compose.runtime.ProduceStateScopeImpl.setValue(Unknown Source:2)
	at androidx.compose.runtime.ProduceStateScopeImpl.setValue(Unknown Source:2)
	at androidx.compose.runtime.SnapshotStateKt__SnapshotFlowKt$collectAsState$1$1.emit(SnapshotFlow.kt:65)
	at androidx.compose.runtime.SnapshotStateKt__SnapshotFlowKt$collectAsState$1$1.emit(SnapshotFlow.kt:65)
	at kotlinx.coroutines.flow.StateFlowImpl.collect(StateFlow.kt:398)
	at kotlinx.coroutines.flow.StateFlowImpl$collect$1.invokeSuspend(Unknown Source:15)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at androidx.compose.ui.platform.AndroidUiDispatcher.performTrampolineDispatch(AndroidUiDispatcher.android.kt:81)
	at androidx.compose.ui.platform.AndroidUiDispatcher.access$performTrampolineDispatch(AndroidUiDispatcher.android.kt:41)
	at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.run(AndroidUiDispatcher.android.kt:57)
	at android.os.Handler.handleCallback(Handler.java:873)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:193)
	at android.app.ActivityThread.main(ActivityThread.java:6754)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@a2d7d55, androidx.compose.runtime.BroadcastFrameClock@64c736a, StandaloneCoroutine{Cancelling}@7b3a05b, AndroidUiDispatcher@3b930f8]
	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@a2d7d55, androidx.compose.runtime.BroadcastFrameClock@64c736a, StandaloneCoroutine{Cancelling}@7b3a05b, AndroidUiDispatcher@3b930f8]

with compose 1.2.1.

Message last modified on Jan 4, 2023 08:15AM

ch...@google.com <ch...@google.com> #11Jan 4, 2023 09:56PM

Comment #10 does not look like a runtime issue but rather that the list being compared is being mutated concurrently during the comparison implictly performed by snapshots. You should not pass a list that is later mutated to mutableStateOf().

12...@qq.com <12...@qq.com> #12Jan 5, 2023 05:59AM

Comment #11 It's my fault,I used mutableStateFlow() to package array list,I changed value which had an exception when high frequency.