Optimize manifest merging for apps and library [234170605]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

xa...@google.com

created issue #1

May 27, 2022 09:12PM

Using a basic project with 1 app and 1 lib, using AGP 7.4.0 alpha 2, we see the following manifest files after a build:

$ find . -name AndroidManifest.xml
./app/build/intermediates/merged_manifest/debug/AndroidManifest.xml
./app/build/intermediates/merged_manifests/debug/AndroidManifest.xml
./app/build/intermediates/packaged_manifests/debug/AndroidManifest.xml
./app/src/main/AndroidManifest.xml
./mylibrary/build/intermediates/merged_manifest/debug/AndroidManifest.xml
./mylibrary/build/intermediates/aapt_friendly_merged_manifests/debug/aapt/AndroidManifest.xml
./mylibrary/src/main/AndroidManifest.xml

The fact that we have 3 intermediate manifests in the app and (more importantly) 2 in the library is probably something we can optimize, in some cases.

The most important aspect here is the library as we need this for scaling. If the reason to have 2 is something we can put behind an opt-in feature that would be better.

Comments

je...@google.com <je...@google.com> Sep 19, 2022 04:56PM

Reassigned to al...@google.com.

al...@google.com <al...@google.com> #2Sep 22, 2022 10:18PM

I just tested with 8.1.36-dev and 8.2.0-dev and the issue is still present.

al...@google.com <al...@google.com> Oct 10, 2022 07:50PM

Accepted by al...@google.com.

al...@google.com <al...@google.com> #3Oct 18, 2022 06:39PM

Can you share a reproduction of this, if possible a compiler dump, see https://r8.googlesource.com/r8/+/refs/heads/main/doc/compilerdump.md

If not publicly, then with ricow@google.com and christofferqa@google.com

Message last modified on Oct 18, 2022 06:40PM

al...@google.com <al...@google.com> Oct 19, 2022 07:26PM

Marked as fixed.

xa...@google.com <xa...@google.com> #4Oct 19, 2022 10:04PM

I can't share a repro, and the full dump contains a lot of proprietary info. Is there a subset of the dump I can share that would be helpful?

sa...@google.com <sa...@google.com> #5Nov 2, 2022 05:32PM

Can you share the resulting apk and then the androidx.profileinstaller.ProfileInstallerInitializer$Choreographer16Impl class file from the dump (it should be in the program.jar inside the dump)

sa...@google.com <sa...@google.com> #6Nov 3, 2022 01:42PM

redacted