Fixed
Status Update
No update yet.
Comments
je...@google.com
al...@google.com
The reason this has not been seen before now is that JDK-8272564 was done for JDK-18 and that it also require min API level 28. The reason the Espresso library expose this is that (most likely) internal Google build tools have JDK-8272564 applied generating invoke-interface on Object methods.
al...@google.com
al...@google.com
Project: r8
Branch: main
commit 6041b16a28b5966e6975340c03261c4fef61b794
Author: Søren Gjesse <sgjesse@google.com>
Date: Thu Mar 02 14:39:27 2023
Also apply the rewriting for JDK-8272564 up to Andorid R
Fixes:
Change-Id: I240de7d301677668b9c13b3b49c7b7951e6434b6
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
https://r8-review.googlesource.com/76861
Branch: main
commit 6041b16a28b5966e6975340c03261c4fef61b794
Author: Søren Gjesse <sgjesse@google.com>
Date: Thu Mar 02 14:39:27 2023
Also apply the rewriting for JDK-8272564 up to Andorid R
Fixes:
Change-Id: I240de7d301677668b9c13b3b49c7b7951e6434b6
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
al...@google.com
xa...@google.com
Project: r8
Branch: main
commit 9e5692c8ce91b3ea3f4199740b41d57c097c9947
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:40:44 2023
Fix test after changing API level for rewriting of JDK-8272564
Bug:
Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653
M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java
https://r8-review.googlesource.com/76885
Branch: main
commit 9e5692c8ce91b3ea3f4199740b41d57c097c9947
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:40:44 2023
Fix test after changing API level for rewriting of JDK-8272564
Bug:
Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653
M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java
sa...@google.com
Project: r8
Branch: 8.0
commit 875ac43330d4404d3c481d7395368ec19defff9d
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:43:48 2023
Version 8.0.33
Bug:
Change-Id: I675869c3c03cce5a0e7b367981e79e47ad1048ec
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/76888
Branch: 8.0
commit 875ac43330d4404d3c481d7395368ec19defff9d
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:43:48 2023
Version 8.0.33
Bug:
Change-Id: I675869c3c03cce5a0e7b367981e79e47ad1048ec
M src/main/java/com/android/tools/r8/Version.java
sa...@google.com
Project: r8
Branch: 8.0
commit 7b9dea5b4c29b5aa9dde2e4a7db4cb28b68c9caf
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:43:32 2023
Fix test after changing API level for rewriting of JDK-8272564
Bug:
Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653
M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java
https://r8-review.googlesource.com/76887
Branch: 8.0
commit 7b9dea5b4c29b5aa9dde2e4a7db4cb28b68c9caf
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:43:32 2023
Fix test after changing API level for rewriting of JDK-8272564
Bug:
Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653
M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java
Description
Using a basic project with 1 app and 1 lib, using AGP 7.4.0 alpha 2, we see the following manifest files after a build:
The fact that we have 3 intermediate manifests in the app and (more importantly) 2 in the library is probably something we can optimize, in some cases.
The most important aspect here is the library as we need this for scaling. If the reason to have 2 is something we can put behind an opt-in feature that would be better.