Optimize manifest merging for apps and library [234170605]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

xa...@google.com

created issue #1

May 27, 2022 09:12PM

Using a basic project with 1 app and 1 lib, using AGP 7.4.0 alpha 2, we see the following manifest files after a build:

$ find . -name AndroidManifest.xml
./app/build/intermediates/merged_manifest/debug/AndroidManifest.xml
./app/build/intermediates/merged_manifests/debug/AndroidManifest.xml
./app/build/intermediates/packaged_manifests/debug/AndroidManifest.xml
./app/src/main/AndroidManifest.xml
./mylibrary/build/intermediates/merged_manifest/debug/AndroidManifest.xml
./mylibrary/build/intermediates/aapt_friendly_merged_manifests/debug/aapt/AndroidManifest.xml
./mylibrary/src/main/AndroidManifest.xml

The fact that we have 3 intermediate manifests in the app and (more importantly) 2 in the library is probably something we can optimize, in some cases.

The most important aspect here is the library as we need this for scaling. If the reason to have 2 is something we can put behind an opt-in feature that would be better.

Comments

je...@google.com <je...@google.com> Sep 19, 2022 04:56PM

Reassigned to al...@google.com.

al...@google.com <al...@google.com> #2Sep 22, 2022 10:18PM

Will be this fix also part of 4.2 please?

al...@google.com <al...@google.com> Oct 10, 2022 07:50PM

Accepted by al...@google.com.

al...@google.com <al...@google.com> #3Oct 18, 2022 06:39PM

for the "out" bundle issue, this seems indeed an issue. for the second one reported adding "debugUpdateAPKArtifact" to the path, this WAI as there can more more than one transformer and we need to automatically separate them so they do not use the same output folder. for #3, I will look at it but it might be difficult to change it at this time.

Message last modified on Oct 18, 2022 06:40PM

al...@google.com <al...@google.com> Oct 19, 2022 07:26PM

Marked as fixed.

xa...@google.com <xa...@google.com> #4Oct 19, 2022 10:04PM

I understand that if there is more transformer is necessary to make every folder different, but there is the main problem, that the final one (last transform) is inside of the intermediate folder. The last transformation should end in the standard location, right? Maybe also with the default name not?

sa...@google.com <sa...@google.com> #5Nov 2, 2022 05:32PM

Hello, this is a P1 S1 issue for a while now, and it's blocking us from upgrading to AGP 4.2 and further. What's the current status? And do you have plans to backport it to 4.2.x?

sa...@google.com <sa...@google.com> #6Nov 3, 2022 01:42PM

no we don't have a plan to backport this. why is this blocking you from upgrading ?