Support the ${applicationId} syntax in dataPattern and data attributes [234223561]

Fixed

Feature Request

Status Update

No update yet.

Description

vo...@snappmobile.io

created issue #1

May 29, 2022 05:14PM

Component used: Navigation
Version used: 2.4.2

So far the ${applicationId} placeholder is supported in the targetPackage attribute, but the placeholder doesn't work for data or dataPattern. The placeholder resolution in these attributes would be helpful for those Android intents that expect a data URI in the format of package:com.myapp.id

If implemented instead of this:

<activity
    android:id="@+id/appSettingsActivity"
    app:action="android.settings.APPLICATION_DETAILS_SETTINGS"
    app:data="package:com.myapp.id" />

We would be able to write:

<activity
    android:id="@+id/appSettingsActivity"
    app:action="android.settings.APPLICATION_DETAILS_SETTINGS"
    app:data="package:${applicationId}" />

The issue is created as a follow-up on this post: https://twitter.com/ianhlake/status/1527818781665267712

Comments

il...@google.com <il...@google.com> Jun 10, 2022 05:43PM

Assigned to cl...@google.com.

ap...@google.com <ap...@google.com> #2Jun 24, 2022 05:57PM

Marked as fixed.

Yigit, do you have time to fix it?

reemission of the same liveData is racy

jb...@google.com <jb...@google.com> #3Jun 24, 2022 05:58PM

yea i'll take it.

vo...@snappmobile.io <vo...@snappmobile.io> #4Jul 4, 2022 10:40AM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

jb...@google.com <jb...@google.com> #5Jul 6, 2022 04:19PM

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

na...@google.com <na...@google.com> #6Sep 12, 2022 05:52PM

With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)

Issue 234223561