Support the ${applicationId} syntax in dataPattern and data attributes [234223561]

Fixed

Feature Request

Status Update

No update yet.

Description

vo...@snappmobile.io

created issue #1

May 29, 2022 05:14PM

Component used: Navigation
Version used: 2.4.2

So far the ${applicationId} placeholder is supported in the targetPackage attribute, but the placeholder doesn't work for data or dataPattern. The placeholder resolution in these attributes would be helpful for those Android intents that expect a data URI in the format of package:com.myapp.id

If implemented instead of this:

<activity
    android:id="@+id/appSettingsActivity"
    app:action="android.settings.APPLICATION_DETAILS_SETTINGS"
    app:data="package:com.myapp.id" />

We would be able to write:

<activity
    android:id="@+id/appSettingsActivity"
    app:action="android.settings.APPLICATION_DETAILS_SETTINGS"
    app:data="package:${applicationId}" />

The issue is created as a follow-up on this post: https://twitter.com/ianhlake/status/1527818781665267712

Comments

il...@google.com <il...@google.com> Jun 10, 2022 05:43PM

Assigned to cl...@google.com.

ap...@google.com <ap...@google.com> #2Jun 24, 2022 05:57PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 7c6dacebb5dd68ddeec73e494c2d3b940db33b41
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Dec 02 16:04:03 2021

Prevent NavHost from compose the wrong entry

Treating the visible lists like sets to ensure that they never can
duplicate any entries and allow NavHost to choose the wrong entry to
compose.

We are opting to only treat it like a Set instead of making it into one
to ensure we will keep the snapshot funcationality of
mutableStateListOf().

RelNote: "Fixed potential crashed caused by fast switching between the
start destination and another destination using bottom nav menu items."
Test: all tests pass
Bug: 208887901

Change-Id: Ic89766e6f0527af0cd3e793643c38ea9e1f2a272

M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt

https://android-review.googlesource.com/1909652

jb...@google.com <jb...@google.com> #3Jun 24, 2022 05:58PM

This has been fixed internally and will be available in the Navigation 2.4.0-rc01 release.

vo...@snappmobile.io <vo...@snappmobile.io> #4Jul 4, 2022 10:40AM

RelNote: "When using the exact string ${applicationId} as the placeholder in the app:data and app:dataPattern attributes in the activity element of a navigation XML file, the placeholder will be automatically filled in with the packageName of the context upon inflation."

Will the app:data="package:${applicationId}" work too?

jb...@google.com <jb...@google.com> #5Jul 6, 2022 04:19PM

Inside of a navigation XML, yes that should work.

na...@google.com <na...@google.com> #6Sep 12, 2022 05:52PM

This bug was linked in a change in the following release(s):

androidx.navigation:navigation-runtime:2.6.0-alpha01

Issue 234223561