Support the ${applicationId} syntax in dataPattern and data attributes [234223561]

Fixed

Feature Request

Status Update

No update yet.

Description

vo...@snappmobile.io

created issue #1

May 29, 2022 05:14PM

Component used: Navigation
Version used: 2.4.2

So far the ${applicationId} placeholder is supported in the targetPackage attribute, but the placeholder doesn't work for data or dataPattern. The placeholder resolution in these attributes would be helpful for those Android intents that expect a data URI in the format of package:com.myapp.id

If implemented instead of this:

<activity
    android:id="@+id/appSettingsActivity"
    app:action="android.settings.APPLICATION_DETAILS_SETTINGS"
    app:data="package:com.myapp.id" />

We would be able to write:

<activity
    android:id="@+id/appSettingsActivity"
    app:action="android.settings.APPLICATION_DETAILS_SETTINGS"
    app:data="package:${applicationId}" />

The issue is created as a follow-up on this post: https://twitter.com/ianhlake/status/1527818781665267712

Comments

il...@google.com <il...@google.com> Jun 10, 2022 05:43PM

Assigned to cl...@google.com.

ap...@google.com <ap...@google.com> #2Jun 24, 2022 05:57PM

Marked as fixed.

Nested scrolling works partially (as per

http://b/122818889). Let's discuss if we need full support and if so make sure it works.

jb...@google.com <jb...@google.com> #3Jun 24, 2022 05:58PM

Hi!

What is 'partially' exactly?
How do I see it?
Thanks!

vo...@snappmobile.io <vo...@snappmobile.io> #4Jul 4, 2022 10:40AM

As of now:
- Nesting scroll views with a scroll direction perpendicular to the ViewPager2's orientation inside ViewPager2 works
- Nesting scroll views with a scroll direction parallel to the ViewPager2's orientation inside ViewPager2 does not work

jb...@google.com <jb...@google.com> #5Jul 6, 2022 04:19PM

Horizontal ViewPager2 not correctly working into a vertical RecyclerView
Set a setNestedScrollingEnabled to the RecyclerView into the ViewPager2 (across reflection) resolves the problem

na...@google.com <na...@google.com> #6Sep 12, 2022 05:52PM

ageevvalentin@gmail.com, could you provide a sample app? I'd like to learn more about the circumstances that cause the problem; putting a clean ViewPager2 inside a clean RecyclerView seems to work fine, so there must be other factors involved.

Issue 234223561