Fixed
Status Update
No update yet.
Comments
il...@google.com
Yigit, do you have time to fix it?
reemission of the same liveData is racy
reemission of the same liveData is racy
jb...@google.com
sa...@google.com
sa...@google.com
jb...@google.com
yea i'll take it.
sa...@google.com
Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.
gs...@gmail.com
just emitting same live data reproduces the issue.
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
na...@google.com
With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)
Description
Component used: Fragment
Version used: 1.5.0-rc01
Tryin to attach an
OnBackPressedDispatcherto aDialogFragment'sDialog, I have to cast the returnedDialogto aComponentDialogto be able to access the back dispatcher. I've also seen this provided as an example hereGiven that
ComponentActivityis a part of the fragment API throughFragmentActivity(e.g.ComponentDialognot a part of aDialogFragmentAPI inrequireDialog()andonCreateDialog()As extra information, there's a possible alternative to casting the dialog, by using
View.findViewTreeOnBackPressedDispatcherOwner()