Make `ComponentDialog` part of `DialogFragment`'s API [234274777]

Fixed

Feature Request

Status Update

No update yet.

Description

gs...@gmail.com

created issue #1

May 30, 2022 04:13PM

Component used: Fragment

Version used: 1.5.0-rc01

Tryin to attach an OnBackPressedDispatcher to a DialogFragment's Dialog, I have to cast the returned Dialog to a ComponentDialog to be able to access the back dispatcher. I've also seen this provided as an example here https://issuetracker.google.com/issues/149173280#comment5

Given that ComponentActivity is a part of the fragment API through FragmentActivity (e.g. requireActivity()), why is ComponentDialog not a part of a DialogFragment API in requireDialog() and onCreateDialog()

As extra information, there's a possible alternative to casting the dialog, by using View.findViewTreeOnBackPressedDispatcherOwner()

Comments

il...@google.com <il...@google.com> #2May 31, 2022 04:05PM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

jb...@google.com <jb...@google.com> Mar 16, 2023 11:52PM

Assigned to sa...@google.com.

sa...@google.com <sa...@google.com> Mar 21, 2023 09:34PM

Accepted by sa...@google.com.

sa...@google.com <sa...@google.com> Mar 23, 2023 08:56PM

Marked as fixed.

jb...@google.com <jb...@google.com> #3Mar 23, 2023 10:20PM

Great! Thanks a lot, I'll look for the live updates soon!

sa...@google.com <sa...@google.com> #4Mar 23, 2023 11:43PM

2503155: Add requireComponentDialog() API to DialogFragment | https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2503155

gs...@gmail.com <gs...@gmail.com> #5Mar 24, 2023 06:41AM

🙏

na...@google.com <na...@google.com> #6Apr 5, 2023 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.fragment:fragment:1.6.0-alpha09