Make `ComponentDialog` part of `DialogFragment`'s API [234274777]

Fixed

Feature Request

Status Update

No update yet.

Description

gs...@gmail.com

created issue #1

May 30, 2022 04:13PM

Component used: Fragment

Version used: 1.5.0-rc01

Tryin to attach an OnBackPressedDispatcher to a DialogFragment's Dialog, I have to cast the returned Dialog to a ComponentDialog to be able to access the back dispatcher. I've also seen this provided as an example here https://issuetracker.google.com/issues/149173280#comment5

Given that ComponentActivity is a part of the fragment API through FragmentActivity (e.g. requireActivity()), why is ComponentDialog not a part of a DialogFragment API in requireDialog() and onCreateDialog()

As extra information, there's a possible alternative to casting the dialog, by using View.findViewTreeOnBackPressedDispatcherOwner()

Comments

il...@google.com <il...@google.com> #2May 31, 2022 04:05PM

Jeremy, is this still an issue? I think the problem was that you had two transitions targeting the same View for the same action (e.g. two Slide() transitions).

jb...@google.com <jb...@google.com> Mar 16, 2023 11:52PM

Assigned to sa...@google.com.

sa...@google.com <sa...@google.com> Mar 21, 2023 09:34PM

Accepted by sa...@google.com.

sa...@google.com <sa...@google.com> Mar 23, 2023 08:56PM

Marked as fixed.

jb...@google.com <jb...@google.com> #3Mar 23, 2023 10:20PM

I have a similar issue with plain AnimatorSet:

set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()

doesn't play animation in resume().

sa...@google.com <sa...@google.com> #4Mar 23, 2023 11:43PM

Should clarify that if I filter out setCurrentPlayTime(0) (or replace it with setCurrentPlayTime(1)) it works well.

Also even with setCurrentPlayTime(0), onAnimationEnd is notified with correct delay (as if the animation has played).

gs...@gmail.com <gs...@gmail.com> #5Mar 24, 2023 06:41AM

@ #4:

I think that is intended for Animator. If you set the currentPlayTime to 0 or the total duration the animator completes. We do some special checks in fragments to handle it.

na...@google.com <na...@google.com> #6Apr 5, 2023 06:27PM

Did some investigation on the Fragment side and it seems like the merged transition is targeting correctly.

Exiting Transition: Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
>>>>> ExitingViews <<<<<
View: android.widget.LinearLayout{f9add3d}
Entering Transition: Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
>>>>> EnteringViews <<<<<
View: android.widget.LinearLayout{b7f24bc}
Final merged transition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
merged transition passed to controlDelayedTransition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})

Still digging.