Bottom sheets should not be full width on large screens [234927577]

Fixed

Feature Request

Status Update

No update yet.

Description

an...@microsoft.com

created issue #1

Jun 5, 2022 06:47PM

Jetpack Compose version: 1.2.0-beta02 Jetpack Compose component used: androidx.compose.material.ModalBottomSheetLayout Android Studio Build: 2022.1.1 Kotlin version: 1.6.20

Steps to Reproduce or Code Sample to Reproduce:

have a ModalBottomSheetLayout in your application
Open it on a large tablet device, its full width there are no modifiers available to change this without also changing the background scrim.

This makes it not possible to meet the quality guidelines for large screen apps in T2-1 / LS-U2:

Modals, options menus, and other secondary elements are properly formatted on all screen types and device states, for example:
- Bottom sheets are not full width on large screens. (Apply a maximum width to avoid stretching.) See Behavior in Sheets: bottom.

https://developer.android.com/docs/quality-guidelines/large-screen-app-quality?hl=en#T2-1

Comments

jo...@google.com <jo...@google.com> #2Jun 11, 2022 09:40PM

Accepted by jo...@google.com.

Hi Jomo, can you take a look at this one?

jo...@google.com <jo...@google.com> #3Aug 11, 2022 05:13PM

Currently we are filtering the flags. Maybe we should just allow -C as well?

ma...@google.com <ma...@google.com> #4
Restricted
Nov 30, 2022 05:55AM

Comment has been deleted.

ap...@google.com <ap...@google.com> #5Dec 30, 2022 04:36PM

I would love to move forward and you're able to help me with that.

Any chance for this to be solved in near future?

jo...@google.com <jo...@google.com> #6Dec 30, 2022 08:12PM

Marked as fixed.

Like in school. The best way to get a silence is to ask a question. :D

na...@google.com <na...@google.com> #7Jan 11, 2023 08:13PM

:D
It looks like a bug to me. I think it's related to the fact that we don't append arguments to the result here:

https://android.googlesource.com/platform/tools/base/+/studio-master-dev/build-system/gradle-core/src/main/java/com/android/build/gradle/internal/cxx/settings/CxxAbiModelCMakeSettingsRewriter.kt#246

se...@gmail.com <se...@gmail.com> #8May 24, 2023 03:30AM

I submitted a fix for this and it should first appear in Android Studio 4.2 beta 1. When that goes out, you may be able to just change your root build.gradle to point at that version of the Android Gradle plugin in maven and try building from the command-line. Or you can download the full Android Studio beta 1 and try it out.

All flags should be passable now, even ones like -G or -N that are likely to result in an unstable or unusable project. So, it's caveat emptor for now and I'll disallow some flags if that turns out to be too problematic.

(internal reference ag/a5f1a02d3faa4e41bacf1885efc3581c36c5c9fe)

ga...@gmail.com <ga...@gmail.com> #9May 25, 2023 01:32AM

I will test it on my machine and wait for full release to bump on build agents.

Thank you very much!

Message last modified on May 25, 2023 01:34AM

se...@outlook.de <se...@outlook.de> #10Sep 17, 2023 10:11AM

Hello. I would like to get you know than in Gradle plugin 4.2.1 -C is still removed from CMake command line.

jo...@google.com <jo...@google.com> #11Sep 18, 2023 05:57AM

I confirmed the change didn't make it into 4.2.1 but it is in Arctic Fox Beta 3.

Message last modified on Sep 18, 2023 05:58AM

sh...@gmail.com <sh...@gmail.com> #12Nov 6, 2023 10:01PM

Thank you!

Allow_overriding_default_maximum_width_for_ModalBottomSheetLayout_.patch

1.5 KB

View

Download