Can not take picture with unbind preview. [235119898]

Fixed

Bug

Status Update

No update yet.

Description

wi...@gmail.com

created issue #1

Jun 7, 2022 02:04PM

CAMERAX VERSION (ex - 1.1.0-beta01) ANDROID OS BUILD NUMBER: Android 7.1.1

DEVICE NAME: (Meizu 15)

DESCRIPTION: i want to freeze preview when taking picture so i call

cameraProvider?.unbind(preview)

imageCapture?.takePicture(builder, Executors.newSingleThreadExecutor(), callback)

OBSERVED RESULTS: freeze preview but can not take picture

EXPECTED RESULTS: freeze preview and take picture

REPRODUCIBILITY: 5 of 5

ADDITIONAL INFORMATION:

if i add this line:

cameraProvider?.unbind(preview) here:

https://github.com/android/camera-samples/blob/9a92a8a1d81b581c442f2e66c066bec8c94225fb/CameraXBasic/app/src/main/java/com/android/example/cameraxbasic/fragments/CameraFragment.kt#L473

i've got:

androidx.camera.core.ImageCaptureException: Request is canceled. at androidx.camera.core.ImageCapture$ImageCaptureRequest.lambda$notifyCallbackError$1$ImageCapture$ImageCaptureRequest(ImageCapture.java:2166) at androidx.camera.core.-$$Lambda$ImageCapture$ImageCaptureRequest$KlqAxzwB-08wcOFrjThjf8ncF2g.run(lambda) at android.os.Handler.handleCallback(Handler.java:751) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:154) at android.app.ActivityThread.main(ActivityThread.java:6394) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1000) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:890) at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:107) Caused by: java.util.concurrent.CancellationException: Request is canceled. at androidx.camera.core.ImageCapture.clearPipeline(ImageCapture.java:485) at androidx.camera.core.ImageCapture.lambda$createPipeline$3$ImageCapture(ImageCapture.java:462) at androidx.camera.core.-$$Lambda$ImageCapture$Pgyx9UAVlv_6AWTYhheL71llVHA.onError(lambda) at androidx.camera.camera2.internal.Camera2CameraImpl.lambda$postSurfaceClosedError$14(Camera2CameraImpl.java:1175) at androidx.camera.camera2.internal.-$$Lambda$Camera2CameraImpl$mXKgpn7oCoUsbBlL_FtX0cw1qkM.run(lambda) at android.os.Handler.handleCallback(Handler.java:751) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:154) at android.app.ActivityThread.main(ActivityThread.java:6394) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1000) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:890) at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:107)

and little different ImageCaptureException with my personal implementation, but same result (just stop preview and then take picture)

idx.camera.core.impl.DeferrableSurface$SurfaceClosedException: Cannot begin use on a closed surface. at androidx.camera.core.impl.DeferrableSurface.incrementUseCount(DeferrableSurface.java:232) at androidx.camera.core.impl.DeferrableSurfaces.incrementAll(DeferrableSurfaces.java:151) at androidx.camera.camera2.internal.SynchronizedCaptureSessionBaseImpl.holdDeferrableSurfaces(SynchronizedCaptureSessionBaseImpl.java:578) at androidx.camera.camera2.internal.SynchronizedCaptureSessionBaseImpl.lambda$openCaptureSession$0$androidx-camera-camera2-internal-SynchronizedCaptureSessionBaseImpl(SynchronizedCaptureSessionBaseImpl.java:152) at androidx.camera.camera2.internal.SynchronizedCaptureSessionBaseImpl$$ExternalSyntheticLambda1.attachCompleter(D8$$SyntheticClass) at androidx.concurrent.futures.CallbackToFutureAdapter.getFuture(CallbackToFutureAdapter.java:102) at androidx.camera.camera2.internal.SynchronizedCaptureSessionBaseImpl.openCaptureSession(SynchronizedCaptureSessionBaseImpl.java:147) at androidx.camera.camera2.internal.SynchronizedCaptureSessionImpl.lambda$openCaptureSession$1$androidx-camera-camera2-internal-SynchronizedCaptureSessionImpl(SynchronizedCaptureSessionImpl.java:128) at androidx.camera.camera2.internal.SynchronizedCaptureSessionImpl$$ExternalSyntheticLambda0.apply(D8$$SyntheticClass) at androidx.camera.core.impl.utils.futures.ChainingListenableFuture.run(ChainingListenableFuture.java:203) at androidx.camera.core.impl.utils.executor.DirectExecutor.execute(DirectExecutor.java:46) at androidx.concurrent.futures.AbstractResolvableFuture.executeListener(AbstractResolvableFuture.java:1053) at androidx.concurrent.futures.AbstractResolvableFuture.addListener(AbstractResolvableFuture.java:668) at androidx.concurrent.futures.CallbackToFutureAdapter$SafeFuture.addListener(CallbackToFutureAdapter.java:210) at androidx.camera.core.impl.utils.futures.ListFuture.addListener(ListFuture.java:198) at androidx.camera.core.impl.utils.futures.FutureChain.addListener(FutureChain.java:135) at androidx.camera.core.impl.utils.futures.Futures.transformAsync(Futures.java:108) at androidx.camera.core.impl.utils.futures.FutureChain.transformAsync(FutureChain.java:82) at androidx.camera.camera2.internal.SynchronizedCaptureSessionImpl.openCaptureSession(SynchronizedCaptureSessionImpl.java:127) at androidx.camera.camera2.internal.SynchronizedCaptureSessionOpener.openCaptureSession(SynchronizedCaptureSessionOpener.java:153) at androidx.camera.camera2.internal.CaptureSession.openCaptureSession(CaptureSession.java:334) at androidx.camera.camera2.internal.CaptureSession.lambda$open$0$androidx-camera-camera2-internal-CaptureSession(CaptureSession.java:210) at androidx.camera.camera2.internal.CaptureSession$$ExternalSyntheticLambda1.apply(D8$$SyntheticClass) at androidx.camera.core.impl.utils.futures.ChainingListenableFuture.run(ChainingListenableFuture.java:203) at androidx.camera.core.impl.utils.executor.SequentialExecutor$QueueWorker.workOnQueue(SequentialExecutor.java:231) at androidx.camera.core.impl.utils.executor.SequentialExecutor$QueueWorker.run(SequentialExecutor.java:173) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607) at java.lang.Thread.run(Thread.java:761)

but if i wait 50 ms for take picture, all works:

cameraProvider?.unbind(preview)

postDelayed( imageCapture?.takePicture.. , 50)

so. how i can correct freeze preview for user when i taking picture?

am i need to

subscribe to fragmentCameraBinding.viewFinder.previewStreamState
call unbind preview
wait until Streamstate changed to IDLE
and only then take picture?

this both solutions does not look like really correct

Comments

wu...@google.com <wu...@google.com> #2Jun 8, 2022 12:53AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

wu...@google.com <wu...@google.com> Jun 8, 2022 09:00AM

Reassigned to we...@google.com.

wi...@gmail.com <wi...@gmail.com> #3Jun 8, 2022 02:39PM

1.1.0-beta01

we...@google.com <we...@google.com> #4Jun 10, 2022 06:06AM

Hi, thanks to report this symptom, we are preparing a fix to re-send the request after the output stream is changed.

And I'd like to share another way to workaround the issue, you can call Preview#setSurfaceProvider(null) to stop the preview output stream.
It will stop the repeating request without re-configure the capture pipeline, so probably this would be better performance.

ap...@google.com <ap...@google.com> #5Jun 13, 2022 09:38AM

Project: platform/frameworks/support
Branch: androidx-main

commit acd0942ba065de6045a8097183a430e553a1ee8b
Author: WenHung_Teng <wenhungteng@google.com>
Date: Fri Jun 10 10:57:28 2022

Fix the take picture failure issue with unbind preview

The capture request is cancelled during the
re-creation of the pipeline.
Store the requests and resend after a new pipeline
is created.

Relnote: "Fix the issue to take picture with unbind preview"

Bug: 235119898
Test: ImageCaptureTest on lab devices
Change-Id: I1d3a2ac7a96e6692c7e3a939cac6e313311f3fc4

M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/integration-tests/coretestapp/src/androidTest/java/androidx/camera/integration/core/ImageCaptureTest.kt

https://android-review.googlesource.com/2122353

we...@google.com <we...@google.com> Jun 13, 2022 09:44AM

Marked as fixed.

ap...@google.com <ap...@google.com> #6Jun 27, 2022 11:46AM

Project: platform/frameworks/support
Branch: androidx-main

commit 03a4e4907b05a6764a5f1ea8977d86a67d7f224a
Author: WenHung_Teng <wenhungteng@google.com>
Date: Tue Jun 21 16:32:17 2022

Fix the take picture failure issue with unbind preview

The capture request is cancelled during the
re-creation of the pipeline.
Store the requests and resend after a new pipeline
is created.

Relnote: "Fix the issue to take picture with unbind preview"

Bug: 235119898
Test: ImageCaptureTest on lab devices
Change-Id: Ie70b6c269a1142e664eab5166acbb0f1788271c1

M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/integration-tests/coretestapp/src/androidTest/java/androidx/camera/integration/core/ImageCaptureTest.kt

https://android-review.googlesource.com/2133056