Fixed
Status Update
Comments
wu...@google.com <wu...@google.com> #2
With the change of lifecycle-common
to KMP, we might be able to just move this into the right spot (since it'll mirror the same structure as lifecycle-runtime
, which does work).
wu...@google.com <wu...@google.com>
wi...@gmail.com <wi...@gmail.com> #3
lifecycle-common
even after conversion to KMP is still a jar. We do not want to change that to an AAR as that is a breaking change for consumers, so i dont think we can make it work this project.
we...@google.com <we...@google.com> #4
Ah yeah good point.
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit a00e293b59bdbe5746941171fe793b863aaafabe
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Apr 11 15:42:42 2024
Move baseline-prof.txt from Lifecycle common to runtime
* Move `baseline-prof.txt` from `lifecycle-common` to `lifecycle-runtime`;
* Because there are multiple files now in `lifecycle-runtime`, group them inside a `baselineProfiles` folder.
* Rename the files to match what modules they target.
Test: N/A
Fixes: 322382422
Change-Id: Iaced653d78e6fe6c107e389ed76cd3ca37e46347
D lifecycle/lifecycle-common/src/jvmMain/baseline-prof.txt
M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/androidMain/baseline-prof.txt
https://android-review.googlesource.com/3038274
Branch: androidx-main
commit a00e293b59bdbe5746941171fe793b863aaafabe
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Apr 11 15:42:42 2024
Move baseline-prof.txt from Lifecycle common to runtime
* Move `baseline-prof.txt` from `lifecycle-common` to `lifecycle-runtime`;
* Because there are multiple files now in `lifecycle-runtime`, group them inside a `baselineProfiles` folder.
* Rename the files to match what modules they target.
Test: N/A
Fixes: 322382422
Change-Id: Iaced653d78e6fe6c107e389ed76cd3ca37e46347
D lifecycle/lifecycle-common/src/jvmMain/baseline-prof.txt
M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/androidMain/baseline-prof.txt
we...@google.com <we...@google.com>
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 03a4e4907b05a6764a5f1ea8977d86a67d7f224a
Author: WenHung_Teng <wenhungteng@google.com>
Date: Tue Jun 21 16:32:17 2022
Fix the take picture failure issue with unbind preview
The capture request is cancelled during the
re-creation of the pipeline.
Store the requests and resend after a new pipeline
is created.
Relnote: "Fix the issue to take picture with unbind preview"
Bug: 235119898
Test: ImageCaptureTest on lab devices
Change-Id: Ie70b6c269a1142e664eab5166acbb0f1788271c1
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/integration-tests/coretestapp/src/androidTest/java/androidx/camera/integration/core/ImageCaptureTest.kt
https://android-review.googlesource.com/2133056
Branch: androidx-main
commit 03a4e4907b05a6764a5f1ea8977d86a67d7f224a
Author: WenHung_Teng <wenhungteng@google.com>
Date: Tue Jun 21 16:32:17 2022
Fix the take picture failure issue with unbind preview
The capture request is cancelled during the
re-creation of the pipeline.
Store the requests and resend after a new pipeline
is created.
Relnote: "Fix the issue to take picture with unbind preview"
Bug: 235119898
Test: ImageCaptureTest on lab devices
Change-Id: Ie70b6c269a1142e664eab5166acbb0f1788271c1
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/integration-tests/coretestapp/src/androidTest/java/androidx/camera/integration/core/ImageCaptureTest.kt
Description
CAMERAX VERSION (ex - 1.1.0-beta01) ANDROID OS BUILD NUMBER: Android 7.1.1
DEVICE NAME: (Meizu 15)
DESCRIPTION: i want to freeze preview when taking picture so i call
cameraProvider?.unbind(preview)
imageCapture?.takePicture(builder, Executors.newSingleThreadExecutor(), callback)
OBSERVED RESULTS: freeze preview but can not take picture
EXPECTED RESULTS: freeze preview and take picture
REPRODUCIBILITY: 5 of 5
ADDITIONAL INFORMATION:
if i add this line:
cameraProvider?.unbind(preview)
here:i've got:
and little different ImageCaptureException with my personal implementation, but same result (just stop preview and then take picture)
but if i wait 50 ms for take picture, all works:
cameraProvider?.unbind(preview)
postDelayed( imageCapture?.takePicture.. , 50)
so. how i can correct freeze preview for user when i taking picture?
am i need to
this both solutions does not look like really correct