LazyVerticalGrid doesn't reflect horizontalArrangement. [235121277]

Fixed

Bug

Status Update

No update yet.

Description

xx...@gmail.com

created issue #1

Jun 7, 2022 06:35AM

Jetpack Compose version: 1.2.0-beta02
Jetpack Compose component used: LazyVerticalGrid
Android Studio Build: Android Studio Dolphin | 2021.3.1 Beta 2
Kotlin version: 1.6.21

Steps to Reproduce or Code Sample to Reproduce:

@Composable
fun SimpleGrid() {
  LazyVerticalGrid(
    columns = GridCells.Fixed(3),
    horizontalArrangement = Arrangement.Center
  ) {
    items(items = (1..10).toList()) {
      Button(onClick = {}, Modifier.wrapContentWidth()) {
        Text(text = "$it")
      }
    }
  }
}

I expect grid items are arranged by horizontalArrangement property. However, these items are always arranged like SpaceAround.

This may be caused by Density.arrange in Arrangement.Horizontal doesn't called by calculateItemsOffsets in LazyGridMeasure.kt when VerticalGrid.
Is anything update planned?

simple_grid.png

2.2 MB

View

Download

Comments

xx...@gmail.com <xx...@gmail.com> #2Jun 13, 2022 10:45AM

Hey Doris, any ideas on where this random animation could be coming from?

an...@elkroom.com <an...@elkroom.com> #3Jul 26, 2022 04:04AM

Re comment #1,

I tried the repro project locally. I was not able to reproduce in the the tip of tree compose code base, after dozens of attempts. It's possible the issue has been fixed recently.

Could you try the latest androidx snapshot here: https://androidx.dev/snapshots/builds and let us know if you still see the issue?

Message last modified on Jul 26, 2022 04:23AM

an...@google.com <an...@google.com> Sep 6, 2022 06:25PM

Reassigned to as...@google.com.

an...@google.com <an...@google.com> #4Feb 27, 2023 06:15PM

Status: Assigned (reopened)

Hi! Thank you for checking into it and giving it a try.

Unfortunately, the issue is still reproducible with snapshot 12123985, 2.8.0-SNAPSHOT for navigation, and 1.8.0-SNAPSHOT for compose.

I've pushed an update containing SNAPSHOT dependencies and automated reproduction attempts: https://github.com/smelfungus/NavHostAnimationIssue

Now, it's sufficient to launch the application and wait.

Here's a new video: https://drive.google.com/file/d/1q3C3ErIzPbTdfLsZH85KgPGNqmL-h1MN/view?usp=sharing

ap...@google.com <ap...@google.com> #5Mar 27, 2023 05:01PM

Marked as fixed.

Thanks for the repro in comment #4. I'm able to repro the issue with the project in #4.

Initial investigation showed that the enter/exit transitions are correct. What appears like a scale animation is a size transform. During the repeated destination change, there seems to be a frame where the new content is resolved into an empty list of measurables, which is incorrect.

Unclear what's causing this yet - either the content composable is not yet populated for that frame, or the UI tree applier deferred adding the nodes to the tree to the next frame. More investigation will be needed.

na...@google.com <na...@google.com> #6Apr 5, 2023 06:28PM

The content composable is indeed empty. It comes from currentEntry being null here: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt;l=693 Therefore, the measured size is 0, and the size animation kicks in to anmate that size change.

Over to Jeremy to investigate further in Navigation.

da...@gmail.com <da...@gmail.com> #7Nov 29, 2023 08:49AM

Is there any progress on this investigation?

Message last modified on Nov 29, 2023 08:51AM

as...@google.com <as...@google.com> #8Nov 29, 2023 01:04PM

Can we get some updates regarding this issue?

mu...@gmail.com <mu...@gmail.com> #9Jan 9, 2024 04:54AM

I'm also experiencing this issue using Navigation Compose 2.8.3 It also happens with the default animation with null transition arguments. Sometimes it just animates through scale in.

as...@google.com <as...@google.com> #10Jan 9, 2024 08:39AM

Likely this is the same issue as https://issuetracker.google.com/issues/339835189, which hasn't been fixed then.

Message last modified on Jan 9, 2024 08:40AM

le...@gmail.com <le...@gmail.com> #11May 15, 2024 03:39PM

I would say this bug was first noticed with 2.7.1

https://issuetracker.google.com/issues/297258205.

an...@google.com <an...@google.com> #12May 16, 2024 12:24PM

I'm still experiencing this issue in my app as of version 2.8.4. Seemingly at random I'll see a scale animation from the top left instead of my custom one.

Feel free to reference it here: https://github.com/t895/DNSNet/blob/30e0b1acbbbb1459a7953c7b69c05aca588817c9/app/src/main/kotlin/dev/clombardo/dnsnet/ui/Home.kt#L646