LazyVerticalGrid doesn't reflect horizontalArrangement. [235121277]

Fixed

Bug

Status Update

No update yet.

Description

xx...@gmail.com

created issue #1

Jun 7, 2022 06:35AM

Jetpack Compose version: 1.2.0-beta02
Jetpack Compose component used: LazyVerticalGrid
Android Studio Build: Android Studio Dolphin | 2021.3.1 Beta 2
Kotlin version: 1.6.21

Steps to Reproduce or Code Sample to Reproduce:

@Composable
fun SimpleGrid() {
  LazyVerticalGrid(
    columns = GridCells.Fixed(3),
    horizontalArrangement = Arrangement.Center
  ) {
    items(items = (1..10).toList()) {
      Button(onClick = {}, Modifier.wrapContentWidth()) {
        Text(text = "$it")
      }
    }
  }
}

I expect grid items are arranged by horizontalArrangement property. However, these items are always arranged like SpaceAround.

This may be caused by Density.arrange in Arrangement.Horizontal doesn't called by calculateItemsOffsets in LazyGridMeasure.kt when VerticalGrid.
Is anything update planned?

simple_grid.png

2.2 MB

View

Download

Comments

xx...@gmail.com <xx...@gmail.com> #2Jun 13, 2022 10:45AM

Project: platform/frameworks/support
Branch: androidx-main

commit cb1afd67dacbf14cd22206c6f5b543dbf18cec1f
Author: Tony Mak <tonymak@google.com>
Date: Thu Jan 06 14:52:58 2022

Deprecate all the APIs in textclassifier

Bug: 210509084

Test: Check api/current.txt and ensure all classes are deprecated

Relnote: "Deprecate all the APIs in the textclassifier module"

Change-Id: Idc18063196531c0e926162fefeadf2dc5f559da1

M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextSelection.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinks.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationSessionId.java
M textclassifier/textclassifier/api/public_plus_experimental_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassification.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationManager.java
M textclassifier/textclassifier/api/current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationContext.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinksParams.java
M textclassifier/textclassifier/api/restricted_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationAction.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassifier.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationActions.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ExtrasUtils.java

https://android-review.googlesource.com/1938773

an...@elkroom.com <an...@elkroom.com> #3Jul 26, 2022 04:04AM

Is there any update when the alpha04 will be available? We need it to target api 31 because of the PendingIntent mutability flags missing in alpha03.

Message last modified on Jul 26, 2022 04:23AM

an...@google.com <an...@google.com> Sep 6, 2022 06:25PM

Reassigned to as...@google.com.

an...@google.com <an...@google.com> #4Feb 27, 2023 06:15PM

Status: Assigned (reopened)

I'll schedule it for the next release. Note that alpha04 is a complete turn-down of the library where all APIs are marked as Deprecated, so you'll also want to start removing your usages of the library.

ap...@google.com <ap...@google.com> #5Mar 27, 2023 05:01PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 19ed7e69823a09f3c63f8c8cdf339af8ca1645ab
Author: Alan Viverette <alanv@google.com>
Date: Mon Mar 14 15:18:16 2022

Bump textclassifier for final release and turn-down

Bug: 210509084
Change-Id: Ib8b2386903bb49baa3211f7de7fe1587fdda1483
Test: ./gradlew checkApi

M libraryversions.toml

https://android-review.googlesource.com/2024823

na...@google.com <na...@google.com> #6Apr 5, 2023 06:28PM

Bugjuggler: wait until 2022-03-23

da...@gmail.com <da...@gmail.com> #7Nov 29, 2023 08:49AM

Hi. I've received your bug and will wait until 2022-03-23 00:00 -0400 EDT and then assign the bug to alanv@google.com.

Message last modified on Nov 29, 2023 08:51AM

as...@google.com <as...@google.com> #8Nov 29, 2023 01:04PM

Is there a replacement or should we just abandon TextClassifier for android older than API Level 26 ?

mu...@gmail.com <mu...@gmail.com> #9Jan 9, 2024 04:54AM

Abandon. The owning team had no plans to release a replacement library.

as...@google.com <as...@google.com> #10Jan 9, 2024 08:39AM

Fixed is always stretched to fill all available space (and fills in spacing from arrangement in between). You want to use FixedSize to ensure there's some space left instead.

Message last modified on Jan 9, 2024 08:40AM

le...@gmail.com <le...@gmail.com> #11May 15, 2024 03:39PM

it doesn't work when I set FixedSize with custom span.
@Composable
fun SimpleGrid() {
LazyVerticalGrid(
columns = GridCells.FixedSize(200.dp),
horizontalArrangement = Arrangement.SpaceBetween
) {
items(items = (1..10).toList(), span = {index -> if(index==5) {GridItemSpan(maxLineSpan)} else {GridItemSpan(1)}}) {
Button(onClick = {}, Modifier.wrapContentWidth()) {
Text(text = "$it")
}
}
}
}

an...@google.com <an...@google.com> #12May 16, 2024 12:24PM

Can you please share the screenshot of what you are getting with this code and explain what behavior do you expect instead? Thanks