AlertDialog button positions not following Material Design guideline [235454277]

Fixed

Bug

Status Update

No update yet.

Description

ch...@doist.com

created issue #1

Jun 9, 2022 06:08PM

Jetpack Compose version: 1.2.0-beta03 Jetpack Compose component used: AlertDialog (the one that accepts confirmButton and dismissButton composables) Android Studio Build: AI-213.7172.25.2211.8563311 Kotlin version: 1.6.21

Steps to Reproduce or Code Sample to Reproduce:

Use the AlertDialog composable with confirmButton and dismissButton.
Add both confirm and dismiss button composables with long text (and maybe capitalized) so that they are vertically stacked.
Then, you would notice that the dismiss button is above and the confirm button is below which is in opposition to the material design guideline: https://material.io/components/dialogs#anatomy Subsection: Stacked full-width buttons.

Comments

ma...@google.com <ma...@google.com> Jun 15, 2022 11:52AM

Assigned to sg...@google.com.

na...@gmail.com <na...@gmail.com> #2Sep 12, 2022 12:02PM

I realize this should be filed as a feature request

fa...@gmail.com <fa...@gmail.com> Jan 19, 2023 04:34PM

Screenshot_2023-01-19-21-03-16-569_com.miui.player.jpg

511 KB

View

Download

sg...@google.com <sg...@google.com> May 2, 2023 11:50PM

Accepted by sg...@google.com.

ap...@google.com <ap...@google.com> #3May 3, 2023 09:36PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit ed2450ec5d2cdf62f1ebf13a29fe04295ad65e44
Author: Anastasia Soboleva <soboleva@google.com>
Date: Thu Dec 30 19:22:41 2021

Add material decoration box for TextField and OutlinedTextField

It allows additionally to what is customisable in text fields already to customise paddings (incl. for dense text field support), border or indicator line.

In the future we could add prefix/suffix, helper message slots.

Fixes: 203764564
Fixes: 191543915
Fixes: 189971673
Fixes: 183136600
Fixes: 179882597
Fixes: 168003617
Test: TextFieldTest and OutlinedTextFieldTest
Test: new tests TextFieldDecorationBoxTest
Relnote: "Added TextFieldDecorationBox and
OutlinedTextFieldDecorationBox. Using them together with BasicTextField
will help you build custom text field based on Material Design text
fields but with more options for customisation."
Relnote: "Provided a way to adjust horizontal and vertical paddings in text fields."

Change-Id: I8c9f168a687e337670c266e1eb3e985da6aebdc3

M compose/material/material/samples/src/main/java/androidx/compose/material/samples/TextFieldSamples.kt
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/TextFieldTest.kt
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/api/public_plus_experimental_current.txt
A compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/1934969

ju...@google.com <ju...@google.com> #4May 24, 2023 07:37PM

Could be also great if the indicator lines can be a Brush not just a Color

Issue 235454277