AlertDialog button positions not following Material Design guideline [235454277]

Fixed

Bug

Status Update

No update yet.

Description

ch...@doist.com

created issue #1

Jun 9, 2022 06:08PM

Jetpack Compose version: 1.2.0-beta03 Jetpack Compose component used: AlertDialog (the one that accepts confirmButton and dismissButton composables) Android Studio Build: AI-213.7172.25.2211.8563311 Kotlin version: 1.6.21

Steps to Reproduce or Code Sample to Reproduce:

Use the AlertDialog composable with confirmButton and dismissButton.
Add both confirm and dismiss button composables with long text (and maybe capitalized) so that they are vertically stacked.
Then, you would notice that the dismiss button is above and the confirm button is below which is in opposition to the material design guideline: https://material.io/components/dialogs#anatomy Subsection: Stacked full-width buttons.

Comments

ma...@google.com <ma...@google.com> Jun 15, 2022 11:52AM

Assigned to sg...@google.com.

na...@gmail.com <na...@gmail.com> #2Sep 12, 2022 12:02PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020

IconButton / IconToggleButton API scrub

Test: ./gradlew updateApi
Bug:

b/161809385

Bug:

b/161807956

Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt

https://android-review.googlesource.com/1394868

fa...@gmail.com <fa...@gmail.com> Jan 19, 2023 04:34PM

Screenshot_2023-01-19-21-03-16-569_com.miui.player.jpg

511 KB

View

Download

sg...@google.com <sg...@google.com> May 2, 2023 11:50PM

Accepted by sg...@google.com.

ap...@google.com <ap...@google.com> #3May 3, 2023 09:36PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 30ba03579a399ae7a79d4acf32c6f83c3b6a8f5e
Author: Shalom Gibly <sgibly@google.com>
Date: Tue May 02 17:22:51 2023

Fixes AlertDialog dismiss actions with long text

This CL fix M2 and M3 AlertDialogs to ensure that when the dismiss and
confirm actions are stacked above each other in cases where their text
is long, the dismiss action appears on the bottom as specified by the
Material Design spec.

https://m3.material.io/components/dialogs/guidelines

Fixes: 235454277
Test: AlertDialogTest
Relnote: "Fixed the AlertDialog dismiss action to appear below the
confirm action when the actions stacked over each other to fit into the
dialog's width. This fix align the implementation with the Material
Design spec."

Change-Id: I029ded5c6dd79f38b1a060afb3d24dcfb9cf119a

M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/AlertDialogTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AlertDialog.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/AlertDialogTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AlertDialog.kt

https://android-review.googlesource.com/2576871

ju...@google.com <ju...@google.com> #4May 24, 2023 07:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.5.0-beta01
androidx.compose.material3:material3:1.2.0-alpha02
androidx.compose.material3:material3-android:1.2.0-alpha02

Issue 235454277