IssueTracker

Component used: RecyclerView
Version used: 1.2.1
Devices/Android versions reproduced on: all versions

I am developing some trivial accordion component, and I have this issue, at androidx.RecyclerView 1.2.1, with LinearLayoutManager, happens only to, recycled and than restored from scrap viewholders, when calling, notifyItemChanged(previousPosition) from onBindViewHolder(holder, position) , reproduced after 30 seconds of expanding and collapsing items, manually, this bug somehow connected to Item decorator, ItemDecorator must be present to make bug happen, actual reason, viewholder is not temporary detached, as it should be, while, another onBindViewHolder() after calling notifyItemChanged(previousPosition) from onBindViewHolder() and showing another current item animation, inside hand made accordion component, based on recycler view, one Item Expanding, another collapsing

problematic place in your code: RecyclerView.java(v1.2.1):line 952
            @Override
            public void attachViewToParent(View child, int index,
                    ViewGroup.LayoutParams layoutParams) {
                final ViewHolder vh = getChildViewHolderInt(child);
                if (vh != null) {
                    if (!vh.isTmpDetached() && !vh.shouldIgnore()) {
                        throw new IllegalArgumentException("Called attach on a child which is not"
                                + " detached: " + vh + exceptionLabel());
                    }
                    if (DEBUG) {
                        Log.d(TAG, "reAttach " + vh);
                    }
                    vh.clearTmpDetachFlag();
                }
                RecyclerView.this.attachViewToParent(child, index, layoutParams);
            }

please fix !!!

below crash log:

2022-06-10 08:54:04.753 12061-12061/jijiit5.jiji.app D/AndroidRuntime: Shutting down VM
   
   
    --------- beginning of crash
2022-06-10 08:54:04.756 12061-12061/my.app E/AndroidRuntime: FATAL EXCEPTION: main
    Process: my.app, PID: 12061
    java.lang.IllegalArgumentException: Called attach on a child which is not detached: MyGuideViewHolder{84e92f4 position=4 id=-1, oldPos=-1, pLpos:4 no parent} androidx.recyclerview.widget.RecyclerView{e56681e VFED..... ......ID 0,0-1080,1731 #7f0904c3 app:id/list}, adapter:my.app.pages.my_guides.adapters.MyGuidesAdapter@3b7a8ff, layout:androidx.recyclerview.widget.LinearLayoutManager@eead6cc, context:my.app.MyActivity@85d1f7
        at androidx.recyclerview.widget.RecyclerView$5.attachViewToParent(RecyclerView.java:953)
        at androidx.recyclerview.widget.ChildHelper.attachViewToParent(ChildHelper.java:239)
        at androidx.recyclerview.widget.RecyclerView$LayoutManager.addViewInt(RecyclerView.java:8883)
        at androidx.recyclerview.widget.RecyclerView$LayoutManager.addView(RecyclerView.java:8860)
        at androidx.recyclerview.widget.RecyclerView$LayoutManager.addView(RecyclerView.java:8848)
        at androidx.recyclerview.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1645)
        at androidx.recyclerview.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1591)
        at androidx.recyclerview.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:668)
        at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep1(RecyclerView.java:4255)
        at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:4010)
        at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4578)
        at android.view.View.layout(View.java:21912)
        at android.view.ViewGroup.layout(ViewGroup.java:6260)
        at androidx.swiperefreshlayout.widget.SwipeRefreshLayout.onLayout(SwipeRefreshLayout.java:625)
        at android.view.View.layout(View.java:21912)
        at android.view.ViewGroup.layout(ViewGroup.java:6260)
        at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
        at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
        at android.view.View.layout(View.java:21912)
        at android.view.ViewGroup.layout(ViewGroup.java:6260)
        at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
        at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
        at android.view.View.layout(View.java:21912)
        at android.view.ViewGroup.layout(ViewGroup.java:6260)
        at android.widget.RelativeLayout.onLayout(RelativeLayout.java:1103)
        at android.view.View.layout(View.java:21912)
        at android.view.ViewGroup.layout(ViewGroup.java:6260)
        at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
        at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
        at android.view.View.layout(View.java:21912)
        at android.view.ViewGroup.layout(ViewGroup.java:6260)
        at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1829)
        at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1673)
        at android.widget.LinearLayout.onLayout(LinearLayout.java:1582)
        at android.view.View.layout(View.java:21912)
        at android.view.ViewGroup.layout(ViewGroup.java:6260)
        at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
        at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
        at com.android.internal.policy.DecorView.onLayout(DecorView.java:779)
        at android.view.View.layout(View.java:21912)
        at android.view.ViewGroup.layout(ViewGroup.java:6260)
        at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:3080)
        at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2590)
        at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1721)
        at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7598)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:966)
        at android.view.Choreographer.doCallbacks(Choreographer.java:790)
        at android.view.Choreographer.doFrame(Choreographer.java:725)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:951)
        at android.os.Handler.handleCallback(Handler.java:883)
        at android.os.Handler.dispatchMessage(Handler.java:100)
        at android.os.Looper.loop(Looper.java:214)
2022-06-10 08:54:04.756 12061-12061/my.app E/AndroidRuntime:     at android.app.ActivityThread.main(ActivityThread.java:7356)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)
2022-06-10 08:54:04.902 2045-9695/? W/ActivityTaskManager:   Force finishing activity my.app/my.app.MyActivity
2022-06-10 08:54:04.902 2045-12385/? I/DropBoxManagerService: add tag=data_app_crash isTagEnabled=true flags=0x2
2022-06-10 08:54:04.903 12061-12061/my.app I/Process: Sending signal. PID: 12061 SIG: 9