Paging should allow enabling debug logging [235527159]

Fixed

Feature Request

adexe s nau

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jun 9, 2022 11:22PM

Component used: Paging

Version used: 3.2.0-alpha01

Similar to what is available in FragmentManager logging, it would be helpful if Paging had a way to enable debug and verbose logging that would help with figuring out what is happening internally within Paging without having to recompile the app or make changes to the Paging library simply by running an adb shell command:

adb shell setprop log.tag.Paging DEBUG

Ideally this should have more critical logging at the DEBUG level while having more detailed logging of events at the VERBOSE level.

Comments

ap...@google.com <ap...@google.com> #2Jul 8, 2022 06:18PM

Note: I know alpha-02 has a fix for a biometric related leak: https://android-review.googlesource.com/c/platform/frameworks/support/+/1382564/

However that change did not fix the leak reported here, as BiometricViewModel is still tied to the activity lifecycle no matter what and will hold the clientCallback reference until the activity is destroyed.

ap...@google.com <ap...@google.com> #3Jul 8, 2022 06:19PM

Any news/possible for this issue?

ap...@google.com <ap...@google.com> #4Jul 8, 2022 11:14PM

Can confirm that it still happens in 1.1.0-beta01

ap...@google.com <ap...@google.com> #5Jul 19, 2022 04:54PM

Project: platform/frameworks/support
Branch: androidx-main

commit fcbbd9368d75b736de4b92d067be84421376b294
Author: Curtis Belmonte <curtislb@google.com>
Date: Wed Jan 20 15:54:34 2021

Reset BiometricViewModel callback in Fragment#onDestroy()

Currently, the client callback reference held by BiometricViewModel is
retained for the lifecycle of the hosting activity. In the (likely) case
that a client is using a fragment within that activity to host
BiometricPrompt and passes an AuthenticationCallback with a reference to
that fragment, this will cause the fragment to leak.

This commit applies a minimal fix for the issue by resetting the
callback reference held by the view model when the host fragment is
destroyed (via a LifecycleObserver). This shouldn't affect the prompt's
behavior across configuration changes such as device rotation, since the
callback should be reinitialized by the client in onCreate() or similar.

Test: Biometric integration test app on API 27-30.
Test: ./gradlew biometric:biometric:test
Test: ./gradlew biometric:biometric:connectedAndroidTest
Test: ./gradlew biometric:integration-tests:testapp:connectedAndroidTest

Bug: 167014923
Change-Id: I7086460fac3921a490f4e2abf0671adec5c146bd

M biometric/biometric/src/main/java/androidx/biometric/BiometricPrompt.java
M biometric/biometric/src/main/java/androidx/biometric/BiometricViewModel.java

https://android-review.googlesource.com/1555701

ap...@google.com <ap...@google.com> #6Jul 29, 2022 12:03AM

I don't use Fragments and use a View-based solutions instead. I create prompt like this:

BiometricPrompt(requireActivity, myAuthCallback)

So it is tied to the activity and it still leaks my view-based screens (1.2.0-alpha02). Ideally there would be a way to reset this callback. Latest commit fixes this leak only for Fragments (sadly).

Is there any workaround maybe? Dirty (but working) ones would do too ;)

ap...@google.com <ap...@google.com> #7Jul 29, 2022 10:28PM

Ditto with the above comment. We're a compose-only app, and use `BiometricPrompt` with the `Activity` context as opposed to passing in a Fragment. This results in leaks, as the callback held by `BiometricViewModel` is never cleared.

An API allowing developers to pass in their own `LifecycleOwner` to set up the `ResetCallbackObserver` observer would be a relatively quick and easy fix for this. I'm more than happy to draft a change for this and submit it via GitHub!

ap...@google.com <ap...@google.com> #8Aug 2, 2022 05:31PM

Marked as fixed.

Any updates on this?