Fix flaking androidx.wear.compose.material.ScalingLazyListLayoutInfoTest#visibleItemsAreCorrect [235531540]

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Jun 10, 2022 01:16AM

expected: 0
expected: 0
but was : -1
	at androidx.wear.compose.material.ScalingLazyListLayoutInfoTest$visibleItemsAreCorrect$3.invoke(ScalingLazyListLayoutInfoTest.kt:92)
	at androidx.wear.compose.material.ScalingLazyListLayoutInfoTest$visibleItemsAreCorrect$3.invoke(ScalingLazyListLayoutInfoTest.kt:90)
	at androidx.compose.ui.test.junit4.AndroidSynchronization_androidKt.runOnUiThread$lambda-0(AndroidSynchronization.android.kt:37)
	at androidx.compose.ui.test.junit4.AndroidSynchronization_androidKt.$r8$lambda$JHfZTn-RG8lrYeP9BZG_AgROyug(Unknown Source:0)
	at androidx.compose.ui.test.junit4.AndroidSynchronization_androidKt$$ExternalSyntheticLambda0.call(Unknown Source:2)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:462)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:2214)
	at android.os.Handler.handleCallback(Handler.java:883)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7356)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

example flaky runs

Comments

ap...@google.com <ap...@google.com> #2Jun 10, 2022 03:57PM

That's correct, we have not yet updated the Wear Compose Navigation library to support the type-safety that's now supported on the compose navhost. It's on the roadmap, but unlikely to make it as part of our 1.5 release.

jn...@google.com <jn...@google.com> Jun 14, 2022 04:46PM

Assigned to jn...@google.com.

jn...@google.com <jn...@google.com> #3Jun 15, 2022 03:54PM

Any guesses, on which date 1.5 version can be released?

jn...@google.com <jn...@google.com> #4Jun 16, 2022 07:59AM

You should use

import com.google.android.horologist.compose.nav.SwipeDismissableNavHost
import com.google.android.horologist.compose.nav.composable

instead of

import androidx.wear.compose.navigation.SwipeDismissableNavHost
import androidx.wear.compose.navigation.composable

Message last modified on Jun 16, 2022 07:59AM

jn...@google.com <jn...@google.com> Jul 25, 2022 11:43AM

Status: Duplicate of

239965750

jn...@google.com <jn...@google.com> Jul 28, 2022 12:26PM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #5Jul 28, 2022 02:53PM

Which dependency I have to add for "com.google.android.horologist.compose.nav.SwipeDismissableNavHost"? Also, does it support for wear navigation compose?

jn...@google.com <jn...@google.com> #6Oct 4, 2022 02:59PM

Here it is:

com.google.android.horologist:horologist-compose-layout:0.6.17

https://github.com/google/horologist/blob/main/docs/compose-layout.md#typesafe-navigation

It works for me at least :)

is...@google.com <is...@google.com> Oct 8, 2024 07:17AM

Status: New